From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C81C433EF for ; Wed, 23 Mar 2022 17:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239545AbiCWRgX (ORCPT ); Wed, 23 Mar 2022 13:36:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235963AbiCWRgV (ORCPT ); Wed, 23 Mar 2022 13:36:21 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9DBF44A2D for ; Wed, 23 Mar 2022 10:34:50 -0700 (PDT) Received: from zn.tnic (p2e55dff8.dip0.t-ipconnect.de [46.85.223.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 810961EC0537; Wed, 23 Mar 2022 18:34:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1648056885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sfbR0Soh68TUYijdA/+0QkJKYVaQ1ddLqZqmPkKqxAI=; b=ehq1BYR0JjZuLvvWaJylDNE61BuT7NSuPCSwizK7d12diSnYwLGPPaeqjMaimB+NQ+gfpw 8alFTVh1fHFYtyHa/XNzeSPU5BqgwGpns4NDCu/9t4n8WKtEGRU3iSVJprRaK2OmQFxx3J hEc6RUle8pXo6Y+bOP9ixzeRheg3i4g= Date: Wed, 23 Mar 2022 18:34:45 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: Naveen Krishna Chatradhi , linux-edac@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org, Muralidhara M K Subject: Re: [PATCH 02/14] EDAC/amd64: Add get_base_mask() into pvt->ops Message-ID: References: <20220228161354.54923-1-nchatrad@amd.com> <20220228161354.54923-3-nchatrad@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Mar 23, 2022 at 05:33:18PM +0000, Yazen Ghannam wrote: > The commit message should include why the change is needed and not just what > the change is. A few of my patches have similar feedback, so it's fresh in my > mind. :) Good. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette