From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F115B7A for ; Thu, 24 Mar 2022 06:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Az4s3bgnP2MWmqVLeQ9zbh1ptxR6Ja+G4u6TZKomgpM=; b=b9oW72pO9kcKe2RPoYFeS5RvI5 v5/A8SCcQHs6Jg3mpv4MUevHfq/A2ays5LMEi/XH6sS6+1klLfjAufAcDkzQHjpQKKVXI2kWoj2lc mjzJpmns+bOtpgCk/CqrN/DjKKIvLPhsOyDv9pTxVP24GO+kyu2b9+Vix2CrKNG9aHjhlEgLBAewa VkFk4hWpVd6mS7Z7POqqk42oWB3QzppS4ZF78V3mUxoLfp8zztpbtGcquBebQjaHY3Ilo41f4tsqn oRnbNQdJV8/KpAYrKyA6F7G59QeYDOyJysI/pG4UP0F1JphgVEJEtdO+p0r/kOLGZm+FXx6+mueiG drV5ia6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXH6I-00FrP2-JJ; Thu, 24 Mar 2022 06:37:38 +0000 Date: Wed, 23 Mar 2022 23:37:38 -0700 From: Christoph Hellwig To: Jane Chu Cc: Christoph Hellwig , "david@fromorbit.com" , "djwong@kernel.org" , "dan.j.williams@intel.com" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "ira.weiny@intel.com" , "willy@infradead.org" , "vgoyal@redhat.com" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Message-ID: References: <20220319062833.3136528-1-jane.chu@oracle.com> <20220319062833.3136528-5-jane.chu@oracle.com> <3dabd58b-70f2-12af-419f-a7dfc07fbb1c@oracle.com> <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Mar 23, 2022 at 06:43:06PM +0000, Jane Chu wrote: > > it onto ->direct_access. But nothing in this series actually checks > > for it as far as I can tell. > > The flag is checked here, again, I'll spell out the flag rather than > using it as a boolean. Yes. The whole point of a flags value is that it is extensible.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A570C433EF for ; Thu, 24 Mar 2022 07:04:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-ggul0yHjMHCO6Utl4laLAQ-1; Thu, 24 Mar 2022 03:04:30 -0400 X-MC-Unique: ggul0yHjMHCO6Utl4laLAQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79993185A7A4; Thu, 24 Mar 2022 07:04:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C7FA4021DE; Thu, 24 Mar 2022 07:04:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 22A90194034B; Thu, 24 Mar 2022 07:04:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F3C871940347 for ; Thu, 24 Mar 2022 07:04:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6818B1400E70; Thu, 24 Mar 2022 07:04:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63E5E1427B27 for ; Thu, 24 Mar 2022 07:04:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 499053C153AC for ; Thu, 24 Mar 2022 07:04:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-UFsQHd-mMeGwxXAFRi6ueQ-1; Thu, 24 Mar 2022 03:04:19 -0400 X-MC-Unique: UFsQHd-mMeGwxXAFRi6ueQ-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXH6I-00FrP2-JJ; Thu, 24 Mar 2022 06:37:38 +0000 Date: Wed, 23 Mar 2022 23:37:38 -0700 From: Christoph Hellwig To: Jane Chu Message-ID: References: <20220319062833.3136528-1-jane.chu@oracle.com> <20220319062833.3136528-5-jane.chu@oracle.com> <3dabd58b-70f2-12af-419f-a7dfc07fbb1c@oracle.com> <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> MIME-Version: 1.0 In-Reply-To: <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Subject: Re: [dm-devel] [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "nvdimm@lists.linux.dev" , "dave.jiang@intel.com" , "snitzer@redhat.com" , "djwong@kernel.org" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "willy@infradead.org" , Christoph Hellwig , "dm-devel@redhat.com" , "vgoyal@redhat.com" , "vishal.l.verma@intel.com" , "linux-fsdevel@vger.kernel.org" , "dan.j.williams@intel.com" , "ira.weiny@intel.com" , "linux-xfs@vger.kernel.org" , "agk@redhat.com" Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Mar 23, 2022 at 06:43:06PM +0000, Jane Chu wrote: > > it onto ->direct_access. But nothing in this series actually checks > > for it as far as I can tell. > > The flag is checked here, again, I'll spell out the flag rather than > using it as a boolean. Yes. The whole point of a flags value is that it is extensible.. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel