From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE10C433F5 for ; Thu, 24 Mar 2022 17:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352086AbiCXRI3 (ORCPT ); Thu, 24 Mar 2022 13:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346584AbiCXRI2 (ORCPT ); Thu, 24 Mar 2022 13:08:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31FAB18A8; Thu, 24 Mar 2022 10:06:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A612B824D1; Thu, 24 Mar 2022 17:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AEC6C340ED; Thu, 24 Mar 2022 17:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648141614; bh=ZDw+3izesL2vgyZeSm6CI/oUxoTlv6vJLD9ct8D7oYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2PotNKeoYZJjB9A6IF7QsqbM4/seux9QfK7sD07Q8N7amZ/y4wk1DNkt4aQdB1E9 Nouod4FXw44GWk5W0RjJFGFGeYhfUzGDefN9YGnB0eAQZwCYleg9qIjljuQZL9tcJ6 RThfsvE1pI9lXOPHQv/bRiWAjXPk7y+FEp2R5pY0= Date: Thu, 24 Mar 2022 18:06:50 +0100 From: Greg Kroah-Hartman To: Jinlong Mao Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. Message-ID: References: <20220324121734.21531-1-quic_jinlmao@quicinc.com> <20220324121734.21531-2-quic_jinlmao@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 24, 2022 at 10:23:19PM +0800, Jinlong Mao wrote: > Hi Greg, > > Thanks for your review. > > On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote: > > On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote: > > > Use hash length of the source's device name to map to the pointer > > > of the enabled path. Using IDR will be more efficient than using > > > the list. And there could be other sources except STM and CPU etms > > > in the new HWs. It is better to maintain all the paths together. > > > > > > Signed-off-by: Mao Jinlong > > > --- > > > drivers/hwtracing/coresight/coresight-core.c | 75 +++++++------------- > > > 1 file changed, 26 insertions(+), 49 deletions(-) > > Your subject line is odd. Please put back the driver subsystem in the > > subject line so that it makes more sense. > I will update the subject in next version. > > > > And how have you measured "more efficient"? > > Using IDR would be better than doing a sequential search as there will be > much more device  in future. How many "more"? Where does the trade off of speed for complexity help? How much faster is this really? You can't claim performance improvements without any proof :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24837C433EF for ; Thu, 24 Mar 2022 17:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J31D0ooSYhrMgahR7WRkO5RyUM9aAMkQwqRBG4SCH/k=; b=Esu2TsP1/UtoWU o2rvyN08qospO1UTCxUMzua8USgyXA3ba/fsGHRTqzb4d7CgXz/IBkI2IVTydl/Qwtt13coRnLYif LuaVPOND/+SNKuehNRwxJXGQ0DGiZskANVV5vBfIFVp6GETE6BMWpo2n57Q6Q6W8x550g9Uzg97Kv Ok+CDxcpXKJrB/dgPva7t4QE5cK+rInom17qXVbrW7omopcPrO2ZR1UNLwZi4AO7lwrrSfFJDcL/9 KRSie32X0t7H+059AzOwN+GViOk/kKseJhVsf3isH6st8RKz7H3SDn2o30sbkWWGiUOn6UwyeI1F2 /l8TZcGpb6xtzVIUaMhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXQvU-00HImv-I4; Thu, 24 Mar 2022 17:07:08 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXQvI-00HIjN-Qz for linux-arm-kernel@lists.infradead.org; Thu, 24 Mar 2022 17:06:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59F31B8244A; Thu, 24 Mar 2022 17:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AEC6C340ED; Thu, 24 Mar 2022 17:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648141614; bh=ZDw+3izesL2vgyZeSm6CI/oUxoTlv6vJLD9ct8D7oYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2PotNKeoYZJjB9A6IF7QsqbM4/seux9QfK7sD07Q8N7amZ/y4wk1DNkt4aQdB1E9 Nouod4FXw44GWk5W0RjJFGFGeYhfUzGDefN9YGnB0eAQZwCYleg9qIjljuQZL9tcJ6 RThfsvE1pI9lXOPHQv/bRiWAjXPk7y+FEp2R5pY0= Date: Thu, 24 Mar 2022 18:06:50 +0100 From: Greg Kroah-Hartman To: Jinlong Mao Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. Message-ID: References: <20220324121734.21531-1-quic_jinlmao@quicinc.com> <20220324121734.21531-2-quic_jinlmao@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_100657_049049_9F46CE41 X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 24, 2022 at 10:23:19PM +0800, Jinlong Mao wrote: > Hi Greg, > = > Thanks for your review. > = > On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote: > > On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote: > > > Use hash length of the source's device name to map to the pointer > > > of the enabled path. Using IDR will be more efficient than using > > > the list. And there could be other sources except STM and CPU etms > > > in the new HWs. It is better to maintain all the paths together. > > > = > > > Signed-off-by: Mao Jinlong > > > --- > > > drivers/hwtracing/coresight/coresight-core.c | 75 +++++++----------= --- > > > 1 file changed, 26 insertions(+), 49 deletions(-) > > Your subject line is odd. Please put back the driver subsystem in the > > subject line so that it makes more sense. > I will update the subject in next version. > > = > > And how have you measured "more efficient"? > = > Using IDR would be better than doing a sequential search as there will be > much more device=A0 in future. How many "more"? Where does the trade off of speed for complexity help? How much faster is this really? You can't claim performance improvements without any proof :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel