From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA26BC433F5 for ; Thu, 24 Mar 2022 22:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353015AbiCXWNc (ORCPT ); Thu, 24 Mar 2022 18:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355238AbiCXWNc (ORCPT ); Thu, 24 Mar 2022 18:13:32 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5963AF1D3 for ; Thu, 24 Mar 2022 15:11:58 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id m18so1320179plx.3 for ; Thu, 24 Mar 2022 15:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rgB6wQBNZL5Us/fhN+fvZAq6CyINYkA8oSSRX75u7u0=; b=FWvB3+owZDEtQZt08RkXl+l2pBVX3KtwfEnkTGRa3UK4p02H5FqNfJpFP6v5y8ezIL //skUivcm8U+2qGTCUXClU2OxpXrpo/PN61DdNAHt7mAX5fkfrTsK/ZmPgV51vaKMAC7 2pKRH6b/hw1n6J1a4n9yeBETeYFp7PQt2b7fU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rgB6wQBNZL5Us/fhN+fvZAq6CyINYkA8oSSRX75u7u0=; b=usLhlwdSjQe+RqOXpyAvxmIKD8vS8SqL/Wc9liK9mtXkT260Vq5LqbCheyw39O0VqD kUF5e2oOA197sQ9jJ9Wvwk+ei3sp+U9XsPBaAcgCYHlfeys9qim1iTJ39OhPQ4Ed3t44 ZdOpgscVsvxnYvMDyBt7umQ3a220Fu2bgSHtps0MyFaQf18CwzyhwoypHTJoOzJpOCao 3hVfWkNKQoKiWIdX7cQXoI4sx1MlqlH104CYylsG9ZXuTtZEhHEvfgaLiMznwQ8uRRM7 eiPbJ8dMl0Xn//LfmpP6G574yegsMYxYlCe/UBL/QzH/vD16A+3S6/S4qm/3uevnlhUl fHLw== X-Gm-Message-State: AOAM530fW+N7j6ZZITa3M7Uaq+4Ioegj5IitbhWxzPs3fC6W0uR9SVLp 5rPaIXwtU4UieDYt2LdcE+7bjQ== X-Google-Smtp-Source: ABdhPJxPOu1ylzQy8wNkSGs4G0tUp4V0n/Yovs3nCbtGMhnLDP7RAXe8IHk/7EftxQpLPqaX0v9Mtw== X-Received: by 2002:a17:903:3091:b0:153:9dcf:de71 with SMTP id u17-20020a170903309100b001539dcfde71mr8127700plc.7.1648159918355; Thu, 24 Mar 2022 15:11:58 -0700 (PDT) Received: from localhost ([2620:15c:202:201:690f:642:3ebe:c89d]) by smtp.gmail.com with UTF8SMTPSA id q7-20020a056a00084700b004faeee0fcdfsm3633994pfk.33.2022.03.24.15.11.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 15:11:57 -0700 (PDT) Date: Thu, 24 Mar 2022 15:11:55 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Stephen Boyd , LKML , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Add device tree for herobrine villager Message-ID: References: <20220324101242.v1.1.Iebdb5af0db7d3d6364cb229a27cd7c668f1063ae@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 24, 2022 at 12:59:51PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Mar 24, 2022 at 10:13 AM Matthias Kaehlcke wrote: > > > > Add a basic device tree for the herobrine villager board. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > .../dts/qcom/sc7280-herobrine-villager-r0.dts | 274 ++++++++++++++++++ > > 2 files changed, 275 insertions(+) > > Question: how does this interact with the patch: > > https://lore.kernel.org/r/20220316172814.v1.3.Iad21bd53f3ac14956b8dbbf3825fc7ab29abdf97@changeid/ > > Specifically, if that patch lands first don't you need to add a patch > to turn on "pp3300_codec" ? Right, I missed that. I'll add it in the next version, thanks! > I was also looking at whether we should be enabling the wf_cam > regulators for villager. I believe that answer is "no", I agree to keep them disabled. > but _also_ I believe that we should be _disabling_ the uf_cam > regulators for villager, right? it is not clear yo me which regulator you have in mind for the UF cam, could you clarify? > > + "MOS_LAA_AS_EN", /* 90 */ > > + "SD_CD_ODL", > > I was somewhat surprised that "SD_CD_ODL" was listed here since, > diffing this with Herobrine, it appears that Villager doesn't have SD. > I checked the schematics, though, and I can confirm that the GPIO is > named this even if it just goes to a testpoint on the board. ;-) ...so > I'm fine keeping it here. :)