Re: [PATCH v5.10] PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup"

[Greg KH <greg@kroah.com>]

On Tue, Apr 05, 2022 at 09:34:19AM -0600, dann frazier wrote:
> From: Marc Zyngier <maz@kernel.org>
> 
> commit 1874b6d7ab1bdc900e8398026350313ac29caddb upstream.
> 
> Commit 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> killed PCIe on my XGene-1 box (a Mustang board). The machine itself
> is still alive, but half of its storage (over NVMe) is gone, and the
> NVMe driver just times out.
> 
> Note that this machine boots with a device tree provided by the
> UEFI firmware (2016 vintage), which could well be non conformant
> with the spec, hence the breakage.
> 
> With the patch reverted, the box boots 5.17-rc8 with flying colors.
> 
> Link: https://lore.kernel.org/all/Yf2wTLjmcRj+AbDv@xps13.dannf
> Link: https://lore.kernel.org/r/20220321104843.949645-2-maz@kernel.org
> Fixes: 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: stable@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: Toan Le <toan@os.amperecomputing.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Krzysztof Wilczyński <kw@linux.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Stéphane Graber <stgraber@ubuntu.com>
> Cc: dann frazier <dann.frazier@canonical.com>
> [dannf: minor context adjustment]
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
>  drivers/pci/controller/pci-xgene.c | 33 ++++++++++++++++++++----------
>  1 file changed, 22 insertions(+), 11 deletions(-)

All now queued up, thanks.

greg k-h