All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Kevin Tian" <kevin.tian@intel.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	"Paul Durrant" <paul@xen.org>
Subject: Re: [PATCH 2/2] VT-d: avoid infinite recursion on domain_context_mapping_one() error path
Date: Wed, 6 Apr 2022 16:03:11 +0200	[thread overview]
Message-ID: <Yk2dnzI4WSm1xMdP@Air-de-Roger> (raw)
In-Reply-To: <535d1050-e5e0-6e1f-5299-f41b84350ca0@suse.com>

On Wed, Apr 06, 2022 at 02:25:13PM +0200, Jan Beulich wrote:
> Despite the comment there infinite recursion was still possible, by
> flip-flopping between two domains. This is because prev_dom is derived
> from the DID found in the context entry, which was already updated by
> the time error recovery is invoked. Simply introduce yet another mode
> flag to detect the situation and cancel further recursion attempts.
> 
> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


      reply	other threads:[~2022-04-06 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 12:22 [PATCH 0/2] VT-d: address fallout from XSA-400 Jan Beulich
2022-04-06 12:24 ` [PATCH 1/2] VT-d: avoid NULL deref on domain_context_mapping_one() error paths Jan Beulich
2022-04-06 13:36   ` Roger Pau Monné
2022-04-06 14:07     ` Jan Beulich
2022-04-06 15:01       ` Roger Pau Monné
2022-04-06 15:35         ` Jan Beulich
2022-04-06 12:25 ` [PATCH 2/2] VT-d: avoid infinite recursion on domain_context_mapping_one() error path Jan Beulich
2022-04-06 14:03   ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk2dnzI4WSm1xMdP@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=paul@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.