From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0994DC433EF for ; Wed, 6 Apr 2022 14:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=crS61kpoE+tv693wH/wZjhvUL4s2p0eQAtq1QvvLS5I=; b=eJW4fetiZhbQpV Lmg1ZKXh9y58vCIjaCcDd9igTiic2e0KNrMsTrRQ07+h9BOcj1GEa6tmROoY2FcpuVZPqtDrRnqjC dYM2/Kc6dVBfyAtHP93Hc8nNJc2EL4yVkEWoEawTxxu89IwxZr0Nh2+TKsIAdKXD2PwwTQzP1fKz2 W1MC6WgJj4+2vqKfmAeUeVW7Uz54BtAkMWNNvLI+FpsJRsUvuOSdOVQl3tPqVigjtxXDUZD9OS758 EH0jvt1RLEn38kLTekY4CP3deYHK/8earVACGdymvyKgT8q8J98g5Us4Os7FicqQ9+pwMIHU3QBzq z8afJfcLkwv2E/JCpoQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc6Yj-006Tjs-94; Wed, 06 Apr 2022 14:22:57 +0000 Received: from mail-oa1-f53.google.com ([209.85.160.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc6YU-006TaC-82 for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2022 14:22:43 +0000 Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-dacc470e03so3046512fac.5 for ; Wed, 06 Apr 2022 07:22:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=upTPlbVTcoTdM5tQWTg7uD8+/IP0VcvCWUQLr9HKbxM=; b=B6V1xnVbMFClghlfU0t0Ymxdm8r+ulSKvLgKMXDpYP6/goRrOVjSXFJAZ3vKqicn0J Rpga/GHSmx6klNrDqgqKMmxGw7eEVY9xUv50Q93ettZg4Zr5qCx908XR/tjycL+aCMHn JJmqmt1OMOyx2Pb00+luNwLBfnG/KbVCepsrNfKvPgnxZKzDdXI1o2AHJUTTWDPGnur+ aFt09b0BufSvqKMs1P1rFGKFEVRAnV6Xz4v72OmlH6BjyxlYmqbzh7WX3EJYNrBCKeq2 lDCYOZ3tUVM9hbY9FumbkBw8490A/D8RUrdhX5oqSPuWoBqIgh8l6vp8R26yMyXvbpNC bk5g== X-Gm-Message-State: AOAM531akEBMJi+0AUSdHF9QgXajsnm9R6NBZfHRKo6VnwbfMq5yrvCb 2v6o+9EzHbYBNhf1AtdySg== X-Google-Smtp-Source: ABdhPJz801q89hxI79GF6DWkpTX3UDIx7GJZaV661AWppiUek8v/hqfiKWFiWpj87fhVQ/EWRwRVqg== X-Received: by 2002:a05:6871:793:b0:db:360c:7f5e with SMTP id o19-20020a056871079300b000db360c7f5emr3985800oap.218.1649254960113; Wed, 06 Apr 2022 07:22:40 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id g18-20020a9d6c52000000b005af7c7cb702sm6734042otq.34.2022.04.06.07.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 07:22:39 -0700 (PDT) Received: (nullmailer pid 2191905 invoked by uid 1000); Wed, 06 Apr 2022 14:22:38 -0000 Date: Wed, 6 Apr 2022 09:22:38 -0500 From: Rob Herring To: Sudeep Holla Cc: Rui Miguel Silva , Liviu Dudau , Lorenzo Pieralisi , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree Message-ID: References: <20220330131053.1122502-1-rui.silva@linaro.org> <20220330131053.1122502-4-rui.silva@linaro.org> <20220331104854.sffey43mlxlg343o@bogus> <20220331112414.cediztrnxaoihdgq@arch-thunder> <20220401105322.k7ob3w2t5stuhhay@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220401105322.k7ob3w2t5stuhhay@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_072242_331797_EDCB6C24 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 01, 2022 at 11:53:22AM +0100, Sudeep Holla wrote: > On Thu, Mar 31, 2022 at 12:24:14PM +0100, Rui Miguel Silva wrote: > > On Thu, Mar 31, 2022 at 11:48:54AM +0100, Sudeep Holla wrote: > > > On Wed, Mar 30, 2022 at 02:10:53PM +0100, Rui Miguel Silva wrote: > > > > + > > > > + mhu_hse1: mailbox@1b820000 { > > > > + compatible = "arm,mhuv2-tx", "arm,primecell"; > > > > + reg = <0x1b820000 0x1000>; > > > > + clocks = <&refclk100mhz>; > > > > + clock-names = "apb_pclk"; > > > > + interrupts = ; > > > > + #mbox-cells = <2>; > > > > + arm,mhuv2-protocols = <0 0>; > > > > + secure-status = "okay"; /* secure-world-only */ > > > > > > Please drop the above. Though I see it is in the binding, no one uses > > > it in the kernel and I prefer not to have this. > > > > the secure partitions in secure world use this mailbox to > > doorbell the secure enclave so, after talking with Rob he suggested to > > use this bindings to make this clear. So, I will keep this ones. > > > Hi Rob, > > Since this is first user of this binding(which is there for a while, but > no users in the kernel code base), are you fine with this ? The general rule is 'don't put status in examples'. I think the same should apply here as that is outside the scope of the binding. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641CFC433EF for ; Wed, 6 Apr 2022 16:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238311AbiDFQ7W (ORCPT ); Wed, 6 Apr 2022 12:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238352AbiDFQ7Q (ORCPT ); Wed, 6 Apr 2022 12:59:16 -0400 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA5D4E7F45 for ; Wed, 6 Apr 2022 07:22:40 -0700 (PDT) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-de3eda6b5dso3106381fac.0 for ; Wed, 06 Apr 2022 07:22:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=upTPlbVTcoTdM5tQWTg7uD8+/IP0VcvCWUQLr9HKbxM=; b=Ph1vBUXRYtRsvC2oKxNmpvI2sL8M4LHuuL4fFCoO9XqBpUrgi16cUWX4XgweiiwcIx IIU01F5uIxj+AxBl1Ek7dtTGPd6zq4JJDwHIk21eJ2tv02y09CSGCpepySJf+Yu0pYOB 1G0Ef0LgBwQP66thaXvLocRpNl2WSb/YGEqR3X98KxsiTXvhCNx5we+01Qhhr/jmpvMm +/+ahFZ+BW2SaNSJivoN4R1yBz996Vf1bAt/3GOAUEvl5khHzzjB4u8xTeTzb7bkWHh4 h4cDgQ64WkZtP9yYCi/ZoS0PPl2g375ouQdY+9uTm5CzhxVlOBOvtGtY9/5pluIcZ4pD ZxlQ== X-Gm-Message-State: AOAM532sBpv/USyhtTFXb1kXBFCg1VYaeV2rp5CxGoidjz0+BHreHVKm w2l1TMO5Wrzs9pu20eH+wg== X-Google-Smtp-Source: ABdhPJz801q89hxI79GF6DWkpTX3UDIx7GJZaV661AWppiUek8v/hqfiKWFiWpj87fhVQ/EWRwRVqg== X-Received: by 2002:a05:6871:793:b0:db:360c:7f5e with SMTP id o19-20020a056871079300b000db360c7f5emr3985800oap.218.1649254960113; Wed, 06 Apr 2022 07:22:40 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id g18-20020a9d6c52000000b005af7c7cb702sm6734042otq.34.2022.04.06.07.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 07:22:39 -0700 (PDT) Received: (nullmailer pid 2191905 invoked by uid 1000); Wed, 06 Apr 2022 14:22:38 -0000 Date: Wed, 6 Apr 2022 09:22:38 -0500 From: Rob Herring To: Sudeep Holla Cc: Rui Miguel Silva , Liviu Dudau , Lorenzo Pieralisi , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree Message-ID: References: <20220330131053.1122502-1-rui.silva@linaro.org> <20220330131053.1122502-4-rui.silva@linaro.org> <20220331104854.sffey43mlxlg343o@bogus> <20220331112414.cediztrnxaoihdgq@arch-thunder> <20220401105322.k7ob3w2t5stuhhay@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220401105322.k7ob3w2t5stuhhay@bogus> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Apr 01, 2022 at 11:53:22AM +0100, Sudeep Holla wrote: > On Thu, Mar 31, 2022 at 12:24:14PM +0100, Rui Miguel Silva wrote: > > On Thu, Mar 31, 2022 at 11:48:54AM +0100, Sudeep Holla wrote: > > > On Wed, Mar 30, 2022 at 02:10:53PM +0100, Rui Miguel Silva wrote: > > > > + > > > > + mhu_hse1: mailbox@1b820000 { > > > > + compatible = "arm,mhuv2-tx", "arm,primecell"; > > > > + reg = <0x1b820000 0x1000>; > > > > + clocks = <&refclk100mhz>; > > > > + clock-names = "apb_pclk"; > > > > + interrupts = ; > > > > + #mbox-cells = <2>; > > > > + arm,mhuv2-protocols = <0 0>; > > > > + secure-status = "okay"; /* secure-world-only */ > > > > > > Please drop the above. Though I see it is in the binding, no one uses > > > it in the kernel and I prefer not to have this. > > > > the secure partitions in secure world use this mailbox to > > doorbell the secure enclave so, after talking with Rob he suggested to > > use this bindings to make this clear. So, I will keep this ones. > > > Hi Rob, > > Since this is first user of this binding(which is there for a while, but > no users in the kernel code base), are you fine with this ? The general rule is 'don't put status in examples'. I think the same should apply here as that is outside the scope of the binding. Rob