From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1E5C433F5 for ; Thu, 7 Apr 2022 10:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233688AbiDGKXq (ORCPT ); Thu, 7 Apr 2022 06:23:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244186AbiDGKXn (ORCPT ); Thu, 7 Apr 2022 06:23:43 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187941AB9FE; Thu, 7 Apr 2022 03:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649326902; x=1680862902; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=14uR+X8D1hFafUVEmn6fSTwQ5pea2ecTUrj5n9ZrzLQ=; b=lSVOjOVSyIDMpxpVb+NikGKkdpG14vXVIfX4V47zzxc/kBUU5Wcdhclo HSkg8qNaoGvKy1L5rqgHhETS9JMPxyyTLIpkuIKuAYv0VeZJ7q4sBD57D CHsxB5odDR8Y1aD8mljOzV3UKT6FxoocWmnn26mWSclkbeUkTwlBEVDgm usqXlO90hwXJdlCXVZ9vxgO0kAyHGlOCVhbQNbbY6oFN09Z/lHghiPbtl t+MDrg2h2RYZZk4FQbilPmkv4QeYWt6mVVZ8+sgiNvulivCeed2YB0KIM qK1IMAkqOHbV4ct4LZSNwP1GOc77198KEVCBkhl8MqNC4xcKGqNA2NjGi A==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="248809078" X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="248809078" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 03:21:18 -0700 X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="722903528" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 03:21:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1ncPEu-000KjM-I7; Thu, 07 Apr 2022 13:19:44 +0300 Date: Thu, 7 Apr 2022 13:19:44 +0300 From: Andy Shevchenko To: Michael Walle Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Nuno =?iso-8859-1?Q?S=E1?= Subject: Re: [PATCH v5 1/4] device property: Allow error pointer to be passed to fwnode APIs Message-ID: References: <20220406130552.30930-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Apr 06, 2022 at 08:05:23PM +0200, Michael Walle wrote: ... > > + if (IS_ERR_OR_NULL(fwnode)) > > + return -ENOENT; > > + > > ret = fwnode_call_int_op(fwnode, get_reference_args, prop, nargs_prop, > > nargs, index, args); > > + if (ret == 0) > > + return ret; > > > > - if (ret < 0 && !IS_ERR_OR_NULL(fwnode) && > > - !IS_ERR_OR_NULL(fwnode->secondary)) > > - ret = fwnode_call_int_op(fwnode->secondary, get_reference_args, > > - prop, nargs_prop, nargs, index, args); > > + if (IS_ERR_OR_NULL(fwnode->secondary)) > > + return -ENOENT; > > Doesn't this mean you overwrite any return code != 0 with -ENOENT? > Is this intended? Indeed, it would shadow the error code. So, it should go with if (IS_ERR_OR_NULL(fwnode->secondary)) return ret; then. > In any case: > Tested-by: Michael Walle Thanks! -- With Best Regards, Andy Shevchenko