From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4526DC433F5 for ; Thu, 7 Apr 2022 07:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241826AbiDGHc6 (ORCPT ); Thu, 7 Apr 2022 03:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241814AbiDGHcv (ORCPT ); Thu, 7 Apr 2022 03:32:51 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8421C45AE8; Thu, 7 Apr 2022 00:30:52 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 52E14499; Thu, 7 Apr 2022 09:30:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649316650; bh=1eYFzMoK6H6YYEen2Elb5S6MFSJv6PvKrhbGFK6YAmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CDNK07HLiQt8KNFejRu9SlEOiqnqmisrPh8vREkV5t2BWV3Ne7HUmKOhvOS+kiwRe UVr59wrSJ7lKyu5DTFTkE8l9d62e65coFCQMDDmdsOANTjLbkkFgtY+d0vQ3xf4rZv Dor/3DxdKtAjB5H95KydaMJWpt222kn0AuKAE1v4= Date: Thu, 7 Apr 2022 10:30:46 +0300 From: Laurent Pinchart To: "H. Nikolaus Schaller" Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Paul Boddie , Jernej Skrabec , David Airlie , Daniel Vetter , Paul Cercueil , Maxime Ripard , Kieran Bingham , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikolaus, Thank you for the patch. On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote: > "hdmi-connector.yaml" bindings defines an optional property > "ddc-en-gpios" for a single gpio to enable DDC operation. > > Usually this controls +5V power on the HDMI connector. > This +5V may also be needed for HPD. > > This was not reflected in code but is needed to make the CI20 > board work. > > Now, the driver activates the ddc gpio after probe and > deactivates after remove so it is "almost on". > > But only if this driver is loaded (and not e.g. blacklisted > as module). > > Signed-off-by: H. Nikolaus Schaller Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/display-connector.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c > index d24f5b90feabf..e4d52a7e31b71 100644 > --- a/drivers/gpu/drm/bridge/display-connector.c > +++ b/drivers/gpu/drm/bridge/display-connector.c > @@ -24,6 +24,7 @@ struct display_connector { > int hpd_irq; > > struct regulator *dp_pwr; > + struct gpio_desc *ddc_en; > }; > > static inline struct display_connector * > @@ -345,6 +346,17 @@ static int display_connector_probe(struct platform_device *pdev) > } > } > > + /* enable DDC */ > + if (type == DRM_MODE_CONNECTOR_HDMIA) { > + conn->ddc_en = devm_gpiod_get_optional(&pdev->dev, "ddc-en", > + GPIOD_OUT_HIGH); > + > + if (IS_ERR(conn->ddc_en)) { > + dev_err(&pdev->dev, "Couldn't get ddc-en gpio\n"); > + return PTR_ERR(conn->ddc_en); > + } > + } > + > conn->bridge.funcs = &display_connector_bridge_funcs; > conn->bridge.of_node = pdev->dev.of_node; > > @@ -373,6 +385,9 @@ static int display_connector_remove(struct platform_device *pdev) > { > struct display_connector *conn = platform_get_drvdata(pdev); > > + if (conn->ddc_en) > + gpiod_set_value(conn->ddc_en, 0); > + > if (conn->dp_pwr) > regulator_disable(conn->dp_pwr); > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A31AFC433EF for ; Thu, 7 Apr 2022 07:30:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BD8510E543; Thu, 7 Apr 2022 07:30:54 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F07610E543 for ; Thu, 7 Apr 2022 07:30:52 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 52E14499; Thu, 7 Apr 2022 09:30:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649316650; bh=1eYFzMoK6H6YYEen2Elb5S6MFSJv6PvKrhbGFK6YAmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CDNK07HLiQt8KNFejRu9SlEOiqnqmisrPh8vREkV5t2BWV3Ne7HUmKOhvOS+kiwRe UVr59wrSJ7lKyu5DTFTkE8l9d62e65coFCQMDDmdsOANTjLbkkFgtY+d0vQ3xf4rZv Dor/3DxdKtAjB5H95KydaMJWpt222kn0AuKAE1v4= Date: Thu, 7 Apr 2022 10:30:46 +0300 From: Laurent Pinchart To: "H. Nikolaus Schaller" Subject: Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Boddie , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Jonas Karlman , linux-kernel@vger.kernel.org, Jernej Skrabec , linux-mips@vger.kernel.org, Paul Cercueil , Kieran Bingham , Robert Foss , Andrzej Hajda , letux-kernel@openphoenux.org, Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nikolaus, Thank you for the patch. On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote: > "hdmi-connector.yaml" bindings defines an optional property > "ddc-en-gpios" for a single gpio to enable DDC operation. > > Usually this controls +5V power on the HDMI connector. > This +5V may also be needed for HPD. > > This was not reflected in code but is needed to make the CI20 > board work. > > Now, the driver activates the ddc gpio after probe and > deactivates after remove so it is "almost on". > > But only if this driver is loaded (and not e.g. blacklisted > as module). > > Signed-off-by: H. Nikolaus Schaller Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/display-connector.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c > index d24f5b90feabf..e4d52a7e31b71 100644 > --- a/drivers/gpu/drm/bridge/display-connector.c > +++ b/drivers/gpu/drm/bridge/display-connector.c > @@ -24,6 +24,7 @@ struct display_connector { > int hpd_irq; > > struct regulator *dp_pwr; > + struct gpio_desc *ddc_en; > }; > > static inline struct display_connector * > @@ -345,6 +346,17 @@ static int display_connector_probe(struct platform_device *pdev) > } > } > > + /* enable DDC */ > + if (type == DRM_MODE_CONNECTOR_HDMIA) { > + conn->ddc_en = devm_gpiod_get_optional(&pdev->dev, "ddc-en", > + GPIOD_OUT_HIGH); > + > + if (IS_ERR(conn->ddc_en)) { > + dev_err(&pdev->dev, "Couldn't get ddc-en gpio\n"); > + return PTR_ERR(conn->ddc_en); > + } > + } > + > conn->bridge.funcs = &display_connector_bridge_funcs; > conn->bridge.of_node = pdev->dev.of_node; > > @@ -373,6 +385,9 @@ static int display_connector_remove(struct platform_device *pdev) > { > struct display_connector *conn = platform_get_drvdata(pdev); > > + if (conn->ddc_en) > + gpiod_set_value(conn->ddc_en, 0); > + > if (conn->dp_pwr) > regulator_disable(conn->dp_pwr); > -- Regards, Laurent Pinchart