From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0A7C433F5 for ; Thu, 7 Apr 2022 11:08:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239865AbiDGLKJ (ORCPT ); Thu, 7 Apr 2022 07:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240469AbiDGLKI (ORCPT ); Thu, 7 Apr 2022 07:10:08 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 72359AAC99; Thu, 7 Apr 2022 04:08:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id ADB298125; Thu, 7 Apr 2022 11:05:43 +0000 (UTC) Date: Thu, 7 Apr 2022 14:08:05 +0300 From: Tony Lindgren To: Maxime Ripard Cc: Marek Szyprowski , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220407075356.lmqnax35cewiwh4k@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org * Tony Lindgren [220407 08:23]: > Hi, > > * Maxime Ripard [220407 07:51]: > > I haven't been able to find an omap3 board or a qemu target that could > > help me debug this, but I fixed a few issues already that could fix omap > > as well. > > > > Could you test today's > > https://github.com/mripard/linux/tree/rpi/clk-improvements-more-fixes > > > > And let me know if it works? > > Yes sorry I've been meaning to try your fixes but had some file system > issues on my build box after a power cut while updating the system. All > good now though, I should be able to give it a try this afternoon. It now boots, but does a lot of checks on the clocks before the timers get initialized compared to v5.18-rc1. And then there's this: [ 2.532501] clk_core_set_rate_nolock +2293: ssi_ssr_fck_3430es2 affected! ... [ 2.554443] unwind_backtrace from show_stack+0x10/0x14 [ 2.559875] show_stack from dump_stack_lvl+0x40/0x4c [ 2.565093] dump_stack_lvl from clk_core_set_rate_nolock+0x278/0x2c4 [ 2.571777] clk_core_set_rate_nolock from clk_set_rate_range_nolock.part.0+0x154/0x384 [ 2.580047] clk_set_rate_range_nolock.part.0 from __clk_put+0x64/0x174 [ 2.586853] __clk_put from clk_add_alias+0x48/0x5c [ 2.591918] clk_add_alias from _add_clkdev.part.0+0x94/0x154 [ 2.597869] _add_clkdev.part.0 from omap_device_alloc+0x88/0x114 [ 2.604156] omap_device_alloc from _omap_device_notifier_call+0x25c/0x3b4 [ 2.611236] _omap_device_notifier_call from blocking_notifier_call_chain+0x6c/0x90 [ 2.619140] blocking_notifier_call_chain from device_add+0x360/0x894 [ 2.625823] device_add from of_platform_device_create_pdata+0x8c/0xb8 [ 2.632568] of_platform_device_create_pdata from of_platform_bus_create+0x194/0x22c [ 2.640563] of_platform_bus_create from of_platform_bus_create+0x1e0/0x22c [ 2.647735] of_platform_bus_create from of_platform_populate+0x60/0xb8 [ 2.654571] of_platform_populate from pdata_quirks_init+0xb4/0xe0 [ 2.660980] pdata_quirks_init from omap_generic_init+0xc/0x18 [ 2.666992] omap_generic_init from customize_machine+0x1c/0x30 [ 2.673126] customize_machine from do_one_initcall+0x44/0x24c [ 2.679138] do_one_initcall from kernel_init_freeable+0x1e8/0x298 [ 2.685546] kernel_init_freeable from kernel_init+0x14/0x140 [ 2.691467] kernel_init from ret_from_fork+0x14/0x24 I'll email you the full log separately to look at. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3EB1C433F5 for ; Thu, 7 Apr 2022 11:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUrk9w3W2wR9wo0rcg5dreWoENI1vLv+MbXLqagjZrg=; b=mZmcIVXij/6tfj oXPVQyU1kO2Pp0safmUtI8XI+63TrmAs9fzZRH2Aj2Wl9pt9jY0yso4hHPQsKILYnhSH01kRnqVMd 39n7BLimIStx86JIG5lC+53Exj07ciYkPYCmtIlCOjYCTWsPGaSsvLs+28/wZ3CAN+5Ko9dI/UHgB YHZt6OI+//g3JPtU2zyBrAdkEvbvjxhI9mLlq2uVgkXMuJeLZVfP3ZW4ImZ0ZhkOTKvjMK4m4riN+ m+2SfTDaLtOzo1EP4nYj556tKZ1DtQpySn/50LQjFbgZfa7iEOfZrZiSK0w0G8wJOUBms5FRfCfIs dgHNsnv62wDgKUgqIxsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPzm-00BTpZ-N6; Thu, 07 Apr 2022 11:08:10 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPzj-00BTo8-IC; Thu, 07 Apr 2022 11:08:09 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id ADB298125; Thu, 7 Apr 2022 11:05:43 +0000 (UTC) Date: Thu, 7 Apr 2022 14:08:05 +0300 From: Tony Lindgren To: Maxime Ripard Cc: Marek Szyprowski , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220407075356.lmqnax35cewiwh4k@houat> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_040807_693433_0878F918 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org * Tony Lindgren [220407 08:23]: > Hi, > > * Maxime Ripard [220407 07:51]: > > I haven't been able to find an omap3 board or a qemu target that could > > help me debug this, but I fixed a few issues already that could fix omap > > as well. > > > > Could you test today's > > https://github.com/mripard/linux/tree/rpi/clk-improvements-more-fixes > > > > And let me know if it works? > > Yes sorry I've been meaning to try your fixes but had some file system > issues on my build box after a power cut while updating the system. All > good now though, I should be able to give it a try this afternoon. It now boots, but does a lot of checks on the clocks before the timers get initialized compared to v5.18-rc1. And then there's this: [ 2.532501] clk_core_set_rate_nolock +2293: ssi_ssr_fck_3430es2 affected! ... [ 2.554443] unwind_backtrace from show_stack+0x10/0x14 [ 2.559875] show_stack from dump_stack_lvl+0x40/0x4c [ 2.565093] dump_stack_lvl from clk_core_set_rate_nolock+0x278/0x2c4 [ 2.571777] clk_core_set_rate_nolock from clk_set_rate_range_nolock.part.0+0x154/0x384 [ 2.580047] clk_set_rate_range_nolock.part.0 from __clk_put+0x64/0x174 [ 2.586853] __clk_put from clk_add_alias+0x48/0x5c [ 2.591918] clk_add_alias from _add_clkdev.part.0+0x94/0x154 [ 2.597869] _add_clkdev.part.0 from omap_device_alloc+0x88/0x114 [ 2.604156] omap_device_alloc from _omap_device_notifier_call+0x25c/0x3b4 [ 2.611236] _omap_device_notifier_call from blocking_notifier_call_chain+0x6c/0x90 [ 2.619140] blocking_notifier_call_chain from device_add+0x360/0x894 [ 2.625823] device_add from of_platform_device_create_pdata+0x8c/0xb8 [ 2.632568] of_platform_device_create_pdata from of_platform_bus_create+0x194/0x22c [ 2.640563] of_platform_bus_create from of_platform_bus_create+0x1e0/0x22c [ 2.647735] of_platform_bus_create from of_platform_populate+0x60/0xb8 [ 2.654571] of_platform_populate from pdata_quirks_init+0xb4/0xe0 [ 2.660980] pdata_quirks_init from omap_generic_init+0xc/0x18 [ 2.666992] omap_generic_init from customize_machine+0x1c/0x30 [ 2.673126] customize_machine from do_one_initcall+0x44/0x24c [ 2.679138] do_one_initcall from kernel_init_freeable+0x1e8/0x298 [ 2.685546] kernel_init_freeable from kernel_init+0x14/0x140 [ 2.691467] kernel_init from ret_from_fork+0x14/0x24 I'll email you the full log separately to look at. Regards, Tony _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2550C433F5 for ; Thu, 7 Apr 2022 11:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZZUqKFheE3IhpT7FZVqTF8QpLs9NRRWCJHLi6q0DIFM=; b=tM4c+qRHKtEU0F OT/eqIegLw7gIwTnMYKH26q8XJXovwxNzyEOktMxLoWfSPn4CSa1/0tiwnHW0nqWGVV8KUCOUPnB0 kaUfQksexkzMydCpx4tX2HFoB1YxePYMMC4eBGDv+8oLnrDWsY9zXkZg5FosGH7JiqKU0scUAGx7i S3rEP9/IinPusq3Dxuvh9pMbyx8c3d80oI48aQ0TFjUH6Ytc562ewG5Fqcg/wn0mB+KLpK4HR2U1C C+Hl1WyyqdAzg/NuPXrkv2wyKJ4nBzLVif5Z1EVuE5hhW8SQWE9kAQTS+iAwsnCI8wmu4OMpPhlp+ /9WDTv4B8t6LrJ1itTOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPzo-00BTpv-Af; Thu, 07 Apr 2022 11:08:12 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPzj-00BTo8-IC; Thu, 07 Apr 2022 11:08:09 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id ADB298125; Thu, 7 Apr 2022 11:05:43 +0000 (UTC) Date: Thu, 7 Apr 2022 14:08:05 +0300 From: Tony Lindgren To: Maxime Ripard Cc: Marek Szyprowski , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220407075356.lmqnax35cewiwh4k@houat> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_040807_693433_0878F918 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [220407 08:23]: > Hi, > > * Maxime Ripard [220407 07:51]: > > I haven't been able to find an omap3 board or a qemu target that could > > help me debug this, but I fixed a few issues already that could fix omap > > as well. > > > > Could you test today's > > https://github.com/mripard/linux/tree/rpi/clk-improvements-more-fixes > > > > And let me know if it works? > > Yes sorry I've been meaning to try your fixes but had some file system > issues on my build box after a power cut while updating the system. All > good now though, I should be able to give it a try this afternoon. It now boots, but does a lot of checks on the clocks before the timers get initialized compared to v5.18-rc1. And then there's this: [ 2.532501] clk_core_set_rate_nolock +2293: ssi_ssr_fck_3430es2 affected! ... [ 2.554443] unwind_backtrace from show_stack+0x10/0x14 [ 2.559875] show_stack from dump_stack_lvl+0x40/0x4c [ 2.565093] dump_stack_lvl from clk_core_set_rate_nolock+0x278/0x2c4 [ 2.571777] clk_core_set_rate_nolock from clk_set_rate_range_nolock.part.0+0x154/0x384 [ 2.580047] clk_set_rate_range_nolock.part.0 from __clk_put+0x64/0x174 [ 2.586853] __clk_put from clk_add_alias+0x48/0x5c [ 2.591918] clk_add_alias from _add_clkdev.part.0+0x94/0x154 [ 2.597869] _add_clkdev.part.0 from omap_device_alloc+0x88/0x114 [ 2.604156] omap_device_alloc from _omap_device_notifier_call+0x25c/0x3b4 [ 2.611236] _omap_device_notifier_call from blocking_notifier_call_chain+0x6c/0x90 [ 2.619140] blocking_notifier_call_chain from device_add+0x360/0x894 [ 2.625823] device_add from of_platform_device_create_pdata+0x8c/0xb8 [ 2.632568] of_platform_device_create_pdata from of_platform_bus_create+0x194/0x22c [ 2.640563] of_platform_bus_create from of_platform_bus_create+0x1e0/0x22c [ 2.647735] of_platform_bus_create from of_platform_populate+0x60/0xb8 [ 2.654571] of_platform_populate from pdata_quirks_init+0xb4/0xe0 [ 2.660980] pdata_quirks_init from omap_generic_init+0xc/0x18 [ 2.666992] omap_generic_init from customize_machine+0x1c/0x30 [ 2.673126] customize_machine from do_one_initcall+0x44/0x24c [ 2.679138] do_one_initcall from kernel_init_freeable+0x1e8/0x298 [ 2.685546] kernel_init_freeable from kernel_init+0x14/0x140 [ 2.691467] kernel_init from ret_from_fork+0x14/0x24 I'll email you the full log separately to look at. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel