From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B49C433FE for ; Thu, 7 Apr 2022 11:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244801AbiDGLdf (ORCPT ); Thu, 7 Apr 2022 07:33:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235988AbiDGLdd (ORCPT ); Thu, 7 Apr 2022 07:33:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83DFA2E9F3; Thu, 7 Apr 2022 04:31:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1819661E80; Thu, 7 Apr 2022 11:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C7CAC385A0; Thu, 7 Apr 2022 11:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649331093; bh=pAQlo9VKRGjLf7hnntocI7qznMtnPAZRWg9jZ+ojOHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELW66sYnXkyaAVA6351QFt8aTuVYZDHX90TAc0q6uqjOSULQtghTxPjdV/qy+SAo/ HoyD6rDG4velCLBWezYrwYqeHgbbTR9uCVGIhRTZkeT8CWooM7d8aEupyk334z6Cr7 p54bLIzW0sofu1S9R5dtzmq47Oh32ESQ8FTJz9HudovtfZv0hXKCm7s0DU7zcEROSF iCHfd1Ilb4jEIh0DPDxmKRjt+YH0N4rEOshJGQhu8lsLFx+MDlrI5fKsnNsfRmlluz D4Dm1GOn6azBLG8sa+VKFIPKiNNYdSOpR/4130NxD/qIGlQ5+0WaPc+Wd1R11TW8jB dch9f06RJOn/Q== Date: Thu, 7 Apr 2022 12:31:26 +0100 From: Mark Brown To: Michael Walle Cc: Manohar.Puri@microchip.com, UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, devicetree@vger.kernel.org, kavyasree.kotagiri@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, nicolas.ferre@microchip.com, robh+dt@kernel.org, tudor.ambarus@microchip.com Subject: Re: [PATCH] spi: atmel,quadspi: Define lan966x QSPI Message-ID: References: <20220407112345.148316-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="70S9eEVN4l3t2VB6" Content-Disposition: inline In-Reply-To: <20220407112345.148316-1-michael@walle.cc> X-Cookie: Look ere ye leap. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --70S9eEVN4l3t2VB6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2022 at 01:23:45PM +0200, Michael Walle wrote: > > > + - microchip,lan966x-qspi > > Generally DT compatibles should be for specific SoCs rather than having > > wildcards in them, even if that means you have to list a lot of SoCs. > > Having used wildcards in the past doesn't mean it's a good idea to > > continue adding them! > The subject should also be prefixed with "dt-bindings: ". I tend to complain about people doing that. > Mark, I did a git log on > Documentation/devicetree/bindings/spi/atmel,quadspi.yaml and all the > subjects are without "dt-bindings:" although the original patch was with > that prefix [1]. Is that intended? Yes. --70S9eEVN4l3t2VB6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJOy44ACgkQJNaLcl1U h9CK0Qf/eynzvwn+qunlhuPIQLhYf6kD/1JDE42i7LImEZFGGG9ob3onn3C3rbg5 m0sbxoHJNz9VbUGKJmUy4A66/QyJP8bJApwnQwatPocPaNmgsroJ/Llh1lsvUajG AefNPi+c1lsM9iyn3Gth6Ayu0+UJitpDlLOGOVqzPv0dfS7TumeguofMOnaa8VEI OnUbmD37HW2UabIeGbExxv1kywu5ZESKlOK482er+mhomgH2L2KvLDYX5a4c28kE H/bL0V5TKaJC7y+FF9nVJ6sk17xDL+cma0hx2m2ADj5lShT/ZuYJPsQGfIR/8h6e b8Wfd6g+R0bCFExvIAyGNZdSYPkh/Q== =/+W7 -----END PGP SIGNATURE----- --70S9eEVN4l3t2VB6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA158C433EF for ; Thu, 7 Apr 2022 11:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pnQ1bCyo5A6Vb1UUnkXOkC2lqUw7GwQP440iAXqJcCU=; b=c9MVBQnOFd5Pj7AxjPS2X07BAL +1/9GEPlvLeEZbRXIJ0T7bcUHf+9frEe5cTA4WzUsjLl7tdiFfoPe5+wdHWN+VEmX2E6KJbwgZChF ENY54Tao/cWbHbsYrSfjXRejUH/e1t0lWfMFCWCnMGmI+TD6gOO3PFO3xuwiQZX63uMHVsKDJraYz Mtgfwxhs0FC+nQoGYe0LLLmDJJw07AiZO7RxVzSZbV2FZ86zKnZu53veho0dsB2UWpP0MzWQebEs+ JrfRHkzhXiU6osYISN5+kdz2FekKhUklChZwg0kg+OUSjoFNRVYIv90fRWraD3kyiQaRy5Xq0YLhk rMuEDdoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncQMU-00BYux-N8; Thu, 07 Apr 2022 11:31:38 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncQMR-00BYtm-VL for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 11:31:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0096B826BA; Thu, 7 Apr 2022 11:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C7CAC385A0; Thu, 7 Apr 2022 11:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649331093; bh=pAQlo9VKRGjLf7hnntocI7qznMtnPAZRWg9jZ+ojOHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELW66sYnXkyaAVA6351QFt8aTuVYZDHX90TAc0q6uqjOSULQtghTxPjdV/qy+SAo/ HoyD6rDG4velCLBWezYrwYqeHgbbTR9uCVGIhRTZkeT8CWooM7d8aEupyk334z6Cr7 p54bLIzW0sofu1S9R5dtzmq47Oh32ESQ8FTJz9HudovtfZv0hXKCm7s0DU7zcEROSF iCHfd1Ilb4jEIh0DPDxmKRjt+YH0N4rEOshJGQhu8lsLFx+MDlrI5fKsnNsfRmlluz D4Dm1GOn6azBLG8sa+VKFIPKiNNYdSOpR/4130NxD/qIGlQ5+0WaPc+Wd1R11TW8jB dch9f06RJOn/Q== Date: Thu, 7 Apr 2022 12:31:26 +0100 From: Mark Brown To: Michael Walle Subject: Re: [PATCH] spi: atmel,quadspi: Define lan966x QSPI Message-ID: References: <20220407112345.148316-1-michael@walle.cc> MIME-Version: 1.0 In-Reply-To: <20220407112345.148316-1-michael@walle.cc> X-Cookie: Look ere ye leap. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_043136_230217_A9A79BBF X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, tudor.ambarus@microchip.com, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, robh+dt@kernel.org, kavyasree.kotagiri@microchip.com, Manohar.Puri@microchip.com, krzk+dt@kernel.org, linux-spi@vger.kernel.org, claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3951499501341458736==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3951499501341458736== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="70S9eEVN4l3t2VB6" Content-Disposition: inline --70S9eEVN4l3t2VB6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2022 at 01:23:45PM +0200, Michael Walle wrote: > > > + - microchip,lan966x-qspi > > Generally DT compatibles should be for specific SoCs rather than having > > wildcards in them, even if that means you have to list a lot of SoCs. > > Having used wildcards in the past doesn't mean it's a good idea to > > continue adding them! > The subject should also be prefixed with "dt-bindings: ". I tend to complain about people doing that. > Mark, I did a git log on > Documentation/devicetree/bindings/spi/atmel,quadspi.yaml and all the > subjects are without "dt-bindings:" although the original patch was with > that prefix [1]. Is that intended? Yes. --70S9eEVN4l3t2VB6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJOy44ACgkQJNaLcl1U h9CK0Qf/eynzvwn+qunlhuPIQLhYf6kD/1JDE42i7LImEZFGGG9ob3onn3C3rbg5 m0sbxoHJNz9VbUGKJmUy4A66/QyJP8bJApwnQwatPocPaNmgsroJ/Llh1lsvUajG AefNPi+c1lsM9iyn3Gth6Ayu0+UJitpDlLOGOVqzPv0dfS7TumeguofMOnaa8VEI OnUbmD37HW2UabIeGbExxv1kywu5ZESKlOK482er+mhomgH2L2KvLDYX5a4c28kE H/bL0V5TKaJC7y+FF9nVJ6sk17xDL+cma0hx2m2ADj5lShT/ZuYJPsQGfIR/8h6e b8Wfd6g+R0bCFExvIAyGNZdSYPkh/Q== =/+W7 -----END PGP SIGNATURE----- --70S9eEVN4l3t2VB6-- --===============3951499501341458736== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3951499501341458736==--