From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75D6C433EF for ; Thu, 7 Apr 2022 13:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340D16B0072; Thu, 7 Apr 2022 09:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EEE66B0073; Thu, 7 Apr 2022 09:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B8ED6B0074; Thu, 7 Apr 2022 09:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 082476B0072 for ; Thu, 7 Apr 2022 09:11:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C59E3AC513 for ; Thu, 7 Apr 2022 13:11:31 +0000 (UTC) X-FDA: 79330119582.25.D1827E2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id C890D180002 for ; Thu, 7 Apr 2022 13:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gTvjrZ7F7Zu4dVHJoV+PDwd6CzIlGFxcOeVnzI7w7Lk=; b=tJuy0C2VKfCz538H5dZoS/wYQ3 sLvpnEG3a7z6NkOKMEJTHfkRpaAbgHKBNeGA1/BGALXCPcRuZ1Dc/T7b6+yFUT2Tyb/rgawTuXMb0 Y3+36sZ/XwDrNGaiOzALm2hoxJPaDbKcFOkRUz8GLS9zB5h0rn0o0j1ZtRgv90hYeutJHO+Cwa8bt +ig9B90VGIzC+IUY6Xp3WTgImdJmbyaUkcdoMS6ID3sNWQSqxVKmVz2z02R5Sbsu+XM712eY5zPhB zunD3TFBqAyXL3EGKG6gnSa5lLV4qTdwsxrffp3aUoJ/BKB7GbCC6/zawPQAlc035nOPAqhZIoDUI YXJ2EX/A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncRv5-008qxW-EV; Thu, 07 Apr 2022 13:11:27 +0000 Date: Thu, 7 Apr 2022 14:11:27 +0100 From: Matthew Wilcox To: Zi Yan Cc: linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 4/4] mm/mempolicy: Use vma_alloc_folio() in new_page() Message-ID: References: <20220404193006.1429250-1-willy@infradead.org> <20220404193006.1429250-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: wyfootw7qoky86j6bpd5ncx9n5sbnpqb Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tJuy0C2V; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C890D180002 X-HE-Tag: 1649337090-815299 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 04, 2022 at 03:51:30PM -0400, Zi Yan wrote: > On 4 Apr 2022, at 15:30, Matthew Wilcox (Oracle) wrote: > > > > - if (PageHuge(page)) { > > - return alloc_huge_page_vma(page_hstate(compound_head(page)), > > + if (folio_test_hugetlb(src)) { > > + return alloc_huge_page_vma(page_hstate(&src->page), > > vma, address); > > - } else if (PageTransHuge(page)) { > > - struct page *thp; > > - > > - thp = alloc_hugepage_vma(GFP_TRANSHUGE, vma, address, > > - HPAGE_PMD_ORDER); > > - if (!thp) > > - return NULL; > > - prep_transhuge_page(thp); > > - return thp; > > + } else if (folio_test_large(src)) { > > + gfp = GFP_TRANSHUGE; > > } > > Nit. The two bracket pairs from the two ifs can be removed. Even better, the first is a return, so it can simply be: if (folio_test_hugetlb(src)) return alloc_huge_page_vma(page_hstate(&src->page), vma, address); if (folio_test_large(src)) gfp = GFP_TRANSHUGE; dst = vma_alloc_folio(gfp, folio_order(src), vma, address, folio_test_large(src));