* [PATCH] rtw89: ser: add a break statement
@ 2022-04-07 17:53 Tom Rix
2022-04-07 18:01 ` Nathan Chancellor
2022-04-12 13:37 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2022-04-07 17:53 UTC (permalink / raw)
To: pkshih, kvalo, davem, kuba, pabeni, nathan, ndesaulniers
Cc: linux-wireless, netdev, linux-kernel, llvm, Tom Rix
The clang build fails with
ser.c:397:2: error: unannotated fall-through
between switch labels [-Werror,-Wimplicit-fallthrough]
default:
^
The case above the default does not have a break.
So add one.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/realtek/rtw89/ser.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c
index 25d1df10f226..5aebd6839d29 100644
--- a/drivers/net/wireless/realtek/rtw89/ser.c
+++ b/drivers/net/wireless/realtek/rtw89/ser.c
@@ -394,6 +394,7 @@ static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)
break;
case SER_EV_STATE_OUT:
rtw89_hci_recovery_start(rtwdev);
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw89: ser: add a break statement
2022-04-07 17:53 [PATCH] rtw89: ser: add a break statement Tom Rix
@ 2022-04-07 18:01 ` Nathan Chancellor
2022-04-12 13:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2022-04-07 18:01 UTC (permalink / raw)
To: Tom Rix
Cc: pkshih, kvalo, davem, kuba, pabeni, ndesaulniers, linux-wireless,
netdev, linux-kernel, llvm
On Thu, Apr 07, 2022 at 01:53:49PM -0400, Tom Rix wrote:
> The clang build fails with
> ser.c:397:2: error: unannotated fall-through
> between switch labels [-Werror,-Wimplicit-fallthrough]
> default:
> ^
> The case above the default does not have a break.
> So add one.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
There is also https://lore.kernel.org/r/20220407132316.61132-2-pkshih@realtek.com/.
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
I have been using Documentation/process/deprecated.rst as justification
for the extra break, warning aside, as all case statements must end in
one of the following:
break
fallthrough
continue
goto
return
> ---
> drivers/net/wireless/realtek/rtw89/ser.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c
> index 25d1df10f226..5aebd6839d29 100644
> --- a/drivers/net/wireless/realtek/rtw89/ser.c
> +++ b/drivers/net/wireless/realtek/rtw89/ser.c
> @@ -394,6 +394,7 @@ static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)
> break;
> case SER_EV_STATE_OUT:
> rtw89_hci_recovery_start(rtwdev);
> + break;
> default:
> break;
> }
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw89: ser: add a break statement
2022-04-07 17:53 [PATCH] rtw89: ser: add a break statement Tom Rix
2022-04-07 18:01 ` Nathan Chancellor
@ 2022-04-12 13:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-04-12 13:37 UTC (permalink / raw)
To: Tom Rix
Cc: pkshih, davem, kuba, pabeni, nathan, ndesaulniers,
linux-wireless, netdev, linux-kernel, llvm, Tom Rix
Tom Rix <trix@redhat.com> wrote:
> The clang build fails with
> ser.c:397:2: error: unannotated fall-through
> between switch labels [-Werror,-Wimplicit-fallthrough]
> default:
> ^
> The case above the default does not have a break.
> So add one.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
I took Zong's version:
https://patchwork.kernel.org/project/linux-wireless/patch/20220408001353.17188-2-pkshih@realtek.com/
Patch set to Superseded.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220407175349.3053362-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-12 13:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 17:53 [PATCH] rtw89: ser: add a break statement Tom Rix
2022-04-07 18:01 ` Nathan Chancellor
2022-04-12 13:37 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.