From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317AEC433EF for ; Mon, 28 Mar 2022 03:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237742AbiC1DGc (ORCPT ); Sun, 27 Mar 2022 23:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233861AbiC1DG2 (ORCPT ); Sun, 27 Mar 2022 23:06:28 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDE7750050; Sun, 27 Mar 2022 20:04:47 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0V8KicJN_1648436681; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0V8KicJN_1648436681) by smtp.aliyun-inc.com(127.0.0.1); Mon, 28 Mar 2022 11:04:44 +0800 Date: Mon, 28 Mar 2022 11:04:41 +0800 From: Gao Xiang To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v6 15/22] erofs: register cookie context for bootstrap blob Message-ID: Mail-Followup-To: Jeffle Xu , dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220325122223.102958-1-jefflexu@linux.alibaba.com> <20220325122223.102958-16-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220325122223.102958-16-jefflexu@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 08:22:16PM +0800, Jeffle Xu wrote: > Registers fscache_cookie for the bootstrap blob file. The bootstrap blob > file can be specified by a new mount option, which is going to be > introduced by a following patch. > > Something worth mentioning about the cleanup routine. > > 1. The init routine is prior to when the root inode gets initialized, > and thus the corresponding cleanup routine shall be placed inside > .kill_sb() callback. > > 2. The init routine will instantiate anonymous inodes under the > super_block, and thus .put_super() callback shall also contain the > cleanup routine. Or we'll get "VFS: Busy inodes after unmount." warning. > > Signed-off-by: Jeffle Xu > --- > fs/erofs/internal.h | 3 +++ > fs/erofs/super.c | 17 +++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index 459f31803c3b..d8c886a7491e 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -73,6 +73,7 @@ struct erofs_mount_opts { > /* threshold for decompression synchronously */ > unsigned int max_sync_decompress_pages; > #endif > + char *tag; > unsigned int mount_opt; > }; > > @@ -151,6 +152,8 @@ struct erofs_sb_info { > /* sysfs support */ > struct kobject s_kobj; /* /sys/fs/erofs/ */ > struct completion s_kobj_unregister; > + > + struct erofs_fscache *bootstrap; the concept of bootstrap is nydus-specific. Actually here we need a fscache context of the primary device. So I prefer struct erofs_fscache *s_fscache; Also please help revise the subject and commit message about bootstrap. Thanks, Gao Xiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3F39C433EF for ; Mon, 28 Mar 2022 03:05:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRcxt3BXrz3c1f for ; Mon, 28 Mar 2022 14:05:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.42; helo=out30-42.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=) Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KRcxk6cpHz2ymw for ; Mon, 28 Mar 2022 14:04:52 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R181e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04394; MF=hsiangkao@linux.alibaba.com; NM=1; PH=DS; RN=19; SR=0; TI=SMTPD_---0V8KicJN_1648436681; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0V8KicJN_1648436681) by smtp.aliyun-inc.com(127.0.0.1); Mon, 28 Mar 2022 11:04:44 +0800 Date: Mon, 28 Mar 2022 11:04:41 +0800 From: Gao Xiang To: Jeffle Xu Subject: Re: [PATCH v6 15/22] erofs: register cookie context for bootstrap blob Message-ID: Mail-Followup-To: Jeffle Xu , dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220325122223.102958-1-jefflexu@linux.alibaba.com> <20220325122223.102958-16-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220325122223.102958-16-jefflexu@linux.alibaba.com> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tianzichen@kuaishou.com, linux-erofs@lists.ozlabs.org, fannaihao@baidu.com, willy@infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, joseph.qi@linux.alibaba.com, linux-cachefs@redhat.com, gregkh@linuxfoundation.org, linux-fsdevel@vger.kernel.org, luodaowen.backend@bytedance.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Fri, Mar 25, 2022 at 08:22:16PM +0800, Jeffle Xu wrote: > Registers fscache_cookie for the bootstrap blob file. The bootstrap blob > file can be specified by a new mount option, which is going to be > introduced by a following patch. > > Something worth mentioning about the cleanup routine. > > 1. The init routine is prior to when the root inode gets initialized, > and thus the corresponding cleanup routine shall be placed inside > .kill_sb() callback. > > 2. The init routine will instantiate anonymous inodes under the > super_block, and thus .put_super() callback shall also contain the > cleanup routine. Or we'll get "VFS: Busy inodes after unmount." warning. > > Signed-off-by: Jeffle Xu > --- > fs/erofs/internal.h | 3 +++ > fs/erofs/super.c | 17 +++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index 459f31803c3b..d8c886a7491e 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -73,6 +73,7 @@ struct erofs_mount_opts { > /* threshold for decompression synchronously */ > unsigned int max_sync_decompress_pages; > #endif > + char *tag; > unsigned int mount_opt; > }; > > @@ -151,6 +152,8 @@ struct erofs_sb_info { > /* sysfs support */ > struct kobject s_kobj; /* /sys/fs/erofs/ */ > struct completion s_kobj_unregister; > + > + struct erofs_fscache *bootstrap; the concept of bootstrap is nydus-specific. Actually here we need a fscache context of the primary device. So I prefer struct erofs_fscache *s_fscache; Also please help revise the subject and commit message about bootstrap. Thanks, Gao Xiang