From: Wolfram Sang <wsa@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Sean Nyekjaer <sean@geanix.com>,
devicetree@vger.kernel.org, Jose Cazarin <joseespiriki@gmail.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1.1 2/2] iio: dac: dac5571: Fix chip id detection for OF devices
Date: Mon, 28 Mar 2022 11:20:54 +0200 [thread overview]
Message-ID: <YkF99t+NlO+IKMXg@ninjato> (raw)
In-Reply-To: <YRwoAgie/mDDunn9@pendragon.ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
> My point is that this patch shouldn't be needed. I'd like if the I2C
> core could get the driver data from the i2c_device_id table instead of
> duplicating it in the of_device_id. This isn't possible today as
> i2c_match_id() doesn't have the fallback mechanism that OF matching has.
I think the proper fix would be naming the I2C client after the actually
matched compatible property, and not after the first one? I am a bit
afraid of regressions when we change that, however...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-28 9:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 18:31 [PATCH 0/2] iio: ti-dac5571: Add TI DAC081C081 support Laurent Pinchart
2021-07-23 18:31 ` [PATCH 1/2] dt-bindings: iio: dac: ti,dac5571: " Laurent Pinchart
2021-07-29 21:26 ` Rob Herring
2021-07-23 18:31 ` [PATCH 2/2] iio: dac: dac5571: Fix chip id detection for OF devices Laurent Pinchart
2021-07-23 23:06 ` kernel test robot
2021-07-23 23:06 ` kernel test robot
2021-07-23 23:06 ` kernel test robot
2021-07-23 23:06 ` kernel test robot
2021-07-24 0:06 ` [PATCH v1.1 " Laurent Pinchart
2021-07-24 14:43 ` Jonathan Cameron
2021-07-24 23:14 ` Laurent Pinchart
2021-08-17 20:44 ` Wolfram Sang
2021-08-17 20:52 ` Laurent Pinchart
2021-08-17 20:58 ` Wolfram Sang
2021-08-17 21:20 ` Laurent Pinchart
2022-03-24 23:25 ` Laurent Pinchart
2022-03-28 9:20 ` Wolfram Sang [this message]
2022-03-28 10:04 ` Laurent Pinchart
2022-03-28 12:22 ` Wolfram Sang
2022-03-29 0:44 ` Laurent Pinchart
2022-03-29 8:59 ` Wolfram Sang
2021-07-24 14:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkF99t+NlO+IKMXg@ninjato \
--to=wsa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joseespiriki@gmail.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.