Re: [PATCH v2] IB/SA: replace usage of found with dedicated list iterator variable

From: Leon Romanovsky <leon@kernel.org>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: "Jason Gunthorpe" <jgg@ziepe.ca>,
	"Håkon Bugge" <haakon.bugge@oracle.com>,
	"Mark Zhang" <markzhang@nvidia.com>,
	"Mark Bloch" <mbloch@nvidia.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Mike Rapoport" <rppt@kernel.org>,
	"Brian Johannesmeyer" <bjohannesmeyer@gmail.com>,
	"Cristiano Giuffrida" <c.giuffrida@vu.nl>,
	"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH v2] IB/SA: replace usage of found with dedicated list iterator variable
Date: Mon, 28 Mar 2022 09:27:18 +0300	[thread overview]
Message-ID: <YkFVRgZpfbsbpGuH@unreal> (raw)
In-Reply-To: <20220327212943.2165728-1-jakobkoschel@gmail.com>

On Sun, Mar 27, 2022 at 11:29:43PM +0200, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> v1->v2:
> - set query correctly (Mark Zhang)
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---

Please put changelog and Link after "---" section, as we don't need it
in git commit history.

>  drivers/infiniband/core/sa_query.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

The change itself is LGTM.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>