Re: [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc

From: Vinod Koul <vkoul@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc
Date: Mon, 28 Mar 2022 22:44:13 +0530	[thread overview]
Message-ID: <YkHs5TuYBKmOLrHO@matsya> (raw)
In-Reply-To: <3cc9c1a0-45f3-cb1b-1991-f51da4789afd@linaro.org>

On 28-03-22, 17:14, Krzysztof Kozlowski wrote:
> On 28/03/2022 16:30, Vinod Koul wrote:
> > The soc node expects all the nodes to have unit addresses. The sound
> > node does not have that which causes warnings:
> > 
> > arch/arm64/boot/dts/qcom/sm8250.dtsi:2806.16-2807.5:
> > Warning (simple_bus_reg): /soc@0/sound: missing or empty reg/ranges property
> > 
> > Move sound node out of soc to fix this
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> 
> I don't know the SM8250, but usually the sound node (e.g. containing
> audio-codec) is not part of SoC. I propose to remove it entirely from
> DTSI and define in same place in each DTS. It makes more sense logically
> in such case - one clearly see which board defines the sounds, which
> does not.

Most of our boards have sound, should we duplicate it in all the
boards..? Bjorn..?

-- 
~Vinod