From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C38FC433F5 for ; Mon, 28 Mar 2022 20:16:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KS3qn3x19z3c8q for ; Tue, 29 Mar 2022 07:16:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=ctPAHr89; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=peterz@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=ctPAHr89; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KS3q65NPhz3c00 for ; Tue, 29 Mar 2022 07:15:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+SAmBHZ787xIZLUQH99HC86IVadAYShzQii7C3N8Zz4=; b=ctPAHr89/2z5b/JrYQDfDyYfm8 sfsDL+i4qNHs46+uxU6vH/P/JPVpvPiPvdexoTrVQhLO3kYD/epcLhRtM3tiYj0qB2VLe3+QUpAFS N8SkUjogqhPs6nnIyYcIvkxmCFlsBY0zHS3uhsVHfzP2XErqL0f5Ea6BADc62Db88AvAcZZCEyvC/ 2QcSmbY2iyUDSvFZUfeQoDATSr43YUxbacg5Ic6gnO0hnV9HmIYoH8QIDmi2LrxfVz0JXGjVM3017 pRzf7SmVwpzksOpYBXVl6AZftXd6Z18J1dpXepJdzEGVX7O5tze+PC3tTCsrOTD9TVc0PiWN2GO/E Cl0zGrFg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvm3-00HEQd-GO; Mon, 28 Mar 2022 20:15:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 26BC4300237; Mon, 28 Mar 2022 22:15:35 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0A218205DA138; Mon, 28 Mar 2022 22:15:35 +0200 (CEST) Date: Mon, 28 Mar 2022 22:15:34 +0200 From: Peter Zijlstra To: Josh Poimboeuf Subject: Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions Message-ID: References: <20220318105140.43914-1-sv@linux.ibm.com> <20220318105140.43914-4-sv@linux.ibm.com> <0b55f122-4760-c1ba-840a-0911cefec2ad@csgroup.eu> <20220328195920.dqlfra3lcardko6r@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "aik@ozlabs.ru" , Will Deacon , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , Sathvika Vasireddy , "naveen.n.rao@linux.vnet.ibm.com" , "linuxppc-dev@lists.ozlabs.org" , ardb@kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" +arm64 people... On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > > > I'm not making any major changes to the code, just shuffling things > > around to make the interface more modular. I hope to have something > > soon (this week). Peter recently added a big feature (Intel IBT) which > > is already in -next. > > Hit Linus' tree yesterday :-) > > > Some years ago Kamalesh Babulal had a prototype of objtool for ppc64le > > which did the full stack validation. I'm not sure what ever became of > > that. > > I've also heard chatter about s390. > > > FWIW, there have been some objtool patches for arm64 stack validation, > > but the arm64 maintainers have been hesitant to get on board with > > objtool, as it brings a certain maintenance burden. Especially for the > > full stack validation and ORC unwinder. But if you only want inline > > static calls and/or mcount then it'd probably be much easier to > > maintain. > > IIRC the major stumbling block for arm64 is the whole jump-table thing. > Either they need to rely on compiler plugins to provide objtool that > data (yuck, since we support at least 2 different compilers), disable > jump-tables (yuck, for that limits code-gen just to please a tool) or > use DWARF (yuck, because build times). > > There was a little talk about an impromptu 'abi' to communicate > jump-table details to objtool without going full on DWARF, but that > seems to have hit a dead end again. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA73C433EF for ; Mon, 28 Mar 2022 20:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344387AbiC1URg (ORCPT ); Mon, 28 Mar 2022 16:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234040AbiC1URe (ORCPT ); Mon, 28 Mar 2022 16:17:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F38D626AD6 for ; Mon, 28 Mar 2022 13:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+SAmBHZ787xIZLUQH99HC86IVadAYShzQii7C3N8Zz4=; b=ctPAHr89/2z5b/JrYQDfDyYfm8 sfsDL+i4qNHs46+uxU6vH/P/JPVpvPiPvdexoTrVQhLO3kYD/epcLhRtM3tiYj0qB2VLe3+QUpAFS N8SkUjogqhPs6nnIyYcIvkxmCFlsBY0zHS3uhsVHfzP2XErqL0f5Ea6BADc62Db88AvAcZZCEyvC/ 2QcSmbY2iyUDSvFZUfeQoDATSr43YUxbacg5Ic6gnO0hnV9HmIYoH8QIDmi2LrxfVz0JXGjVM3017 pRzf7SmVwpzksOpYBXVl6AZftXd6Z18J1dpXepJdzEGVX7O5tze+PC3tTCsrOTD9TVc0PiWN2GO/E Cl0zGrFg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvm3-00HEQd-GO; Mon, 28 Mar 2022 20:15:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 26BC4300237; Mon, 28 Mar 2022 22:15:35 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0A218205DA138; Mon, 28 Mar 2022 22:15:35 +0200 (CEST) Date: Mon, 28 Mar 2022 22:15:34 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: Christophe Leroy , "aik@ozlabs.ru" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "naveen.n.rao@linux.vnet.ibm.com" , "linuxppc-dev@lists.ozlabs.org" , Sathvika Vasireddy , Will Deacon , Mark Rutland , ardb@kernel.org Subject: Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions Message-ID: References: <20220318105140.43914-1-sv@linux.ibm.com> <20220318105140.43914-4-sv@linux.ibm.com> <0b55f122-4760-c1ba-840a-0911cefec2ad@csgroup.eu> <20220328195920.dqlfra3lcardko6r@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +arm64 people... On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > > > I'm not making any major changes to the code, just shuffling things > > around to make the interface more modular. I hope to have something > > soon (this week). Peter recently added a big feature (Intel IBT) which > > is already in -next. > > Hit Linus' tree yesterday :-) > > > Some years ago Kamalesh Babulal had a prototype of objtool for ppc64le > > which did the full stack validation. I'm not sure what ever became of > > that. > > I've also heard chatter about s390. > > > FWIW, there have been some objtool patches for arm64 stack validation, > > but the arm64 maintainers have been hesitant to get on board with > > objtool, as it brings a certain maintenance burden. Especially for the > > full stack validation and ORC unwinder. But if you only want inline > > static calls and/or mcount then it'd probably be much easier to > > maintain. > > IIRC the major stumbling block for arm64 is the whole jump-table thing. > Either they need to rely on compiler plugins to provide objtool that > data (yuck, since we support at least 2 different compilers), disable > jump-tables (yuck, for that limits code-gen just to please a tool) or > use DWARF (yuck, because build times). > > There was a little talk about an impromptu 'abi' to communicate > jump-table details to objtool without going full on DWARF, but that > seems to have hit a dead end again.