From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC063C433EF for ; Mon, 28 Mar 2022 20:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345273AbiC1U2Q (ORCPT ); Mon, 28 Mar 2022 16:28:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345122AbiC1U2M (ORCPT ); Mon, 28 Mar 2022 16:28:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46F5766612; Mon, 28 Mar 2022 13:26:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E84E9B81107; Mon, 28 Mar 2022 20:26:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58486C34100; Mon, 28 Mar 2022 20:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648499187; bh=JbZmSa9juiLf0oAIpCV18B8Gsa8QNhEYAXYAWPoGCjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIshgBsAthZuhsL1QUYnPtPpeH8E4IrAr2ib6qONsURzkGABcvVjzKbKyWBMtcTA1 vK+4LI8FpxEdrpOfm2xZMgMNCWUm/Nr3r2g5NdExEjBAEY93bhy5PB6vwR59LrAeiA KHjwP9cHKcwehG0hQZA4FRfVPYssYmIm0K1+8yfzQNDnMXSTPKL3t5vPoQzlUwAXme mr1qd2zFrVsZwtZlvxfxPMP3ZHSHYQxc0n2hgO2+ndP/1EER7wuBEDlYYm5iJV4ITB 2R7gEsMrsYFHbk6zJlzIQKw+ZUDTjQupKHZ0a4pAjoh2FJAsXzaEkrQerdT7zfl/82 oh14FN2Roaclw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D9D9940407; Mon, 28 Mar 2022 17:26:24 -0300 (-03) Date: Mon, 28 Mar 2022 17:26:24 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. Message-ID: References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220328062414.1893550-3-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Mar 27, 2022 at 11:24:11PM -0700, Ian Rogers escreveu: > perf_cpu_map__merge will reuse one of its arguments if they are equal or > the other argument is NULL. The arguments could be reused if it is known > one set of values is a subset of the other. For example, a map of 0-1 > and a map of just 0 when merged yields the map of 0-1. Currently a new > map is created rather than adding a reference count to the original 0-1 > map. > > Signed-off-by: Ian Rogers > --- > tools/lib/perf/cpumap.c | 38 ++++++++++++++++++++++++++++---------- > 1 file changed, 28 insertions(+), 10 deletions(-) > > diff --git a/tools/lib/perf/cpumap.c b/tools/lib/perf/cpumap.c > index ee66760f1e63..953bc50b0e41 100644 > --- a/tools/lib/perf/cpumap.c > +++ b/tools/lib/perf/cpumap.c > @@ -319,6 +319,29 @@ struct perf_cpu perf_cpu_map__max(struct perf_cpu_map *map) > return map->nr > 0 ? map->map[map->nr - 1] : result; > } > > +/** Is 'b' a subset of 'a'. */ > +static bool perf_cpu_map__is_subset(const struct perf_cpu_map *a, > + const struct perf_cpu_map *b) > +{ > + int i, j; > + > + if (a == b || !b) > + return true; > + if (!a || b->nr > a->nr) > + return false; > + j = 0; > + for (i = 0; i < a->nr; i++) { Since the kernel bumped the minimum gcc version to one that supports declaring loop variables locally and that perf has been using this since forever: ⬢[acme@toolbox perf]$ grep -r '(int [[:alpha:]] = 0;' tools/perf tools/perf/util/block-info.c: for (int i = 0; i < nr_hpps; i++) tools/perf/util/block-info.c: for (int i = 0; i < nr_hpps; i++) { tools/perf/util/block-info.c: for (int i = 0; i < nr_reps; i++) tools/perf/util/stream.c: for (int i = 0; i < nr_evsel; i++) tools/perf/util/stream.c: for (int i = 0; i < nr_evsel; i++) { tools/perf/util/stream.c: for (int i = 0; i < els->nr_evsel; i++) { tools/perf/util/stream.c: for (int i = 0; i < es_pair->nr_streams; i++) { tools/perf/util/stream.c: for (int i = 0; i < es_base->nr_streams; i++) { tools/perf/util/cpumap.c: for (int j = 0; j < c->nr; j++) { tools/perf/util/mem-events.c: for (int j = 0; j < PERF_MEM_EVENTS__MAX; j++) { tools/perf/util/header.c: for (int i = 0; i < ff->ph->env.nr_hybrid_cpc_nodes; i++) { tools/perf/builtin-diff.c: for (int i = 0; i < num; i++) tools/perf/builtin-diff.c: for (int i = 0; i < pair->block_info->num; i++) { tools/perf/builtin-stat.c: for (int i = 0; i < perf_cpu_map__nr(a->core.cpus); i++) { ⬢[acme@toolbox perf]$ And this builds on all my test containers, please use: for (int i = 0, j = 0; i < a->nr; i++) In this case to make the source code more compact. > + if (a->map[i].cpu > b->map[j].cpu) > + return false; > + if (a->map[i].cpu == b->map[j].cpu) { > + j++; > + if (j == b->nr) > + return true; Ok, as its guaranteed that cpu_maps are ordered. > + } > + } > + return false; > +} > + > /* > * Merge two cpumaps > * > @@ -335,17 +358,12 @@ struct perf_cpu_map *perf_cpu_map__merge(struct perf_cpu_map *orig, > int i, j, k; > struct perf_cpu_map *merged; > > - if (!orig && !other) > - return NULL; > - if (!orig) { > - perf_cpu_map__get(other); > - return other; > - } > - if (!other) > - return orig; > - if (orig->nr == other->nr && > - !memcmp(orig->map, other->map, orig->nr * sizeof(struct perf_cpu))) > + if (perf_cpu_map__is_subset(orig, other)) > return orig; Can't we have first the introduction of perf_cpu_map__is_subset() and then another patch that gets the refcount, i.e. the four lines below? > + if (perf_cpu_map__is_subset(other, orig)) { > + perf_cpu_map__put(orig); > + return perf_cpu_map__get(other); > + } > > tmp_len = orig->nr + other->nr; > tmp_cpus = malloc(tmp_len * sizeof(struct perf_cpu)); > -- > 2.35.1.1021.g381101b075-goog -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9FE3C433EF for ; Mon, 28 Mar 2022 20:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vplCgypNdaC1P44y+LES20kDORzitpbSro1s4uvYkiY=; b=OoamcRyEKHIahj 5EJRZ14xNxTkzpfBTrF5BrleHk27SLCV5TxzWXhjzSBUYUylYIbSuKbNpYUIdQyDM2CIDoGjgCCtD ZuPaVPWqDZvnD/MM8zEOGZemXlAAaTOpGY0ALNQmhVZrPDrlMrEwY3DWsJlVTBmUQ3URSc0TKKr3e yyGDDZAxJWKlzOMQdVlszf2OF42MXzqTlbyH+bEJV5WctVGAx6/u/i2t4XdSBHVSWdq9mL4eqObWA qLx20VOLAcVhwx5ESARxlmcjoOzoToZktaiJvMiX0DEX7IVQtJNGcmcX/aagR9F7Aq+BkOsydte9X gpih/6C/ABMH2zZ8PEOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvwf-00A3np-Bm; Mon, 28 Mar 2022 20:26:33 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvwd-00A3mz-94 for linux-arm-kernel@bombadil.infradead.org; Mon, 28 Mar 2022 20:26:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=w7L4bOWVuXyvWlj78AVnxPFGtvx1dbfaVL4usOP93Lk=; b=CCY6522VVwE6gCR2SNYYzamlfQ QrAbCc7hMsYYHgtLOVHP0JHdc8JvaFWehd5UcFaiL7MClEBC9c6aVJ8gV4a+7UNNbAEVszOf07EkT 1Ase2GF+kkHbQ/lSdfcugUu0E6ToWkhhQ5V/O2woWpN/b3bivrTkNJIk+CHjF/4YyxJO9VwDmm+Ku 8BEBDTvPvcjj17QNqW5NuoeyQ81YHJOsyQGFyuFR8NUDhYMqeGfkHSGokrNiXCS6eUTS3u05/Ll+V UIyo5bXAmw0i8/Cm4B2zerZPkpwjipDF6e/oLQ9Mc/S9qyyKQ/DQrMNPyN+SHAb9iPh5x3DrOQp+e Ss3oO8sg==; Received: from [187.19.239.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvwb-005YAd-66; Mon, 28 Mar 2022 20:26:29 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D9D9940407; Mon, 28 Mar 2022 17:26:24 -0300 (-03) Date: Mon, 28 Mar 2022 17:26:24 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. Message-ID: References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220328062414.1893550-3-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gU3VuLCBNYXIgMjcsIDIwMjIgYXQgMTE6MjQ6MTFQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBwZXJmX2NwdV9tYXBfX21lcmdlIHdpbGwgcmV1c2Ugb25lIG9mIGl0cyBhcmd1bWVu dHMgaWYgdGhleSBhcmUgZXF1YWwgb3IKPiB0aGUgb3RoZXIgYXJndW1lbnQgaXMgTlVMTC4gVGhl IGFyZ3VtZW50cyBjb3VsZCBiZSByZXVzZWQgaWYgaXQgaXMga25vd24KPiBvbmUgc2V0IG9mIHZh bHVlcyBpcyBhIHN1YnNldCBvZiB0aGUgb3RoZXIuIEZvciBleGFtcGxlLCBhIG1hcCBvZiAwLTEK PiBhbmQgYSBtYXAgb2YganVzdCAwIHdoZW4gbWVyZ2VkIHlpZWxkcyB0aGUgbWFwIG9mIDAtMS4g Q3VycmVudGx5IGEgbmV3Cj4gbWFwIGlzIGNyZWF0ZWQgcmF0aGVyIHRoYW4gYWRkaW5nIGEgcmVm ZXJlbmNlIGNvdW50IHRvIHRoZSBvcmlnaW5hbCAwLTEKPiBtYXAuCj4gCj4gU2lnbmVkLW9mZi1i eTogSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29nbGUuY29tPgo+IC0tLQo+ICB0b29scy9saWIvcGVy Zi9jcHVtYXAuYyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvdG9vbHMvbGliL3BlcmYvY3B1bWFwLmMgYi90b29scy9saWIvcGVyZi9jcHVt YXAuYwo+IGluZGV4IGVlNjY3NjBmMWU2My4uOTUzYmM1MGIwZTQxIDEwMDY0NAo+IC0tLSBhL3Rv b2xzL2xpYi9wZXJmL2NwdW1hcC5jCj4gKysrIGIvdG9vbHMvbGliL3BlcmYvY3B1bWFwLmMKPiBA QCAtMzE5LDYgKzMxOSwyOSBAQCBzdHJ1Y3QgcGVyZl9jcHUgcGVyZl9jcHVfbWFwX19tYXgoc3Ry dWN0IHBlcmZfY3B1X21hcCAqbWFwKQo+ICAJcmV0dXJuIG1hcC0+bnIgPiAwID8gbWFwLT5tYXBb bWFwLT5uciAtIDFdIDogcmVzdWx0Owo+ICB9Cj4gIAo+ICsvKiogSXMgJ2InIGEgc3Vic2V0IG9m ICdhJy4gKi8KPiArc3RhdGljIGJvb2wgcGVyZl9jcHVfbWFwX19pc19zdWJzZXQoY29uc3Qgc3Ry dWN0IHBlcmZfY3B1X21hcCAqYSwKPiArCQkJCSAgICBjb25zdCBzdHJ1Y3QgcGVyZl9jcHVfbWFw ICpiKQo+ICt7Cj4gKwlpbnQgaSwgajsKPiArCj4gKwlpZiAoYSA9PSBiIHx8ICFiKQo+ICsJCXJl dHVybiB0cnVlOwo+ICsJaWYgKCFhIHx8IGItPm5yID4gYS0+bnIpCj4gKwkJcmV0dXJuIGZhbHNl Owo+ICsJaiA9IDA7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgYS0+bnI7IGkrKykgewoKU2luY2UgdGhl IGtlcm5lbCBidW1wZWQgdGhlIG1pbmltdW0gZ2NjIHZlcnNpb24gdG8gb25lIHRoYXQgc3VwcG9y dHMKZGVjbGFyaW5nIGxvb3AgdmFyaWFibGVzIGxvY2FsbHkgYW5kIHRoYXQgcGVyZiBoYXMgYmVl biB1c2luZyB0aGlzIHNpbmNlCmZvcmV2ZXI6CgrirKJbYWNtZUB0b29sYm94IHBlcmZdJCBncmVw IC1yICcoaW50IFtbOmFscGhhOl1dID0gMDsnIHRvb2xzL3BlcmYKdG9vbHMvcGVyZi91dGlsL2Js b2NrLWluZm8uYzoJZm9yIChpbnQgaSA9IDA7IGkgPCBucl9ocHBzOyBpKyspCnRvb2xzL3BlcmYv dXRpbC9ibG9jay1pbmZvLmM6CWZvciAoaW50IGkgPSAwOyBpIDwgbnJfaHBwczsgaSsrKSB7CnRv b2xzL3BlcmYvdXRpbC9ibG9jay1pbmZvLmM6CWZvciAoaW50IGkgPSAwOyBpIDwgbnJfcmVwczsg aSsrKQp0b29scy9wZXJmL3V0aWwvc3RyZWFtLmM6CWZvciAoaW50IGkgPSAwOyBpIDwgbnJfZXZz ZWw7IGkrKykKdG9vbHMvcGVyZi91dGlsL3N0cmVhbS5jOglmb3IgKGludCBpID0gMDsgaSA8IG5y X2V2c2VsOyBpKyspIHsKdG9vbHMvcGVyZi91dGlsL3N0cmVhbS5jOglmb3IgKGludCBpID0gMDsg aSA8IGVscy0+bnJfZXZzZWw7IGkrKykgewp0b29scy9wZXJmL3V0aWwvc3RyZWFtLmM6CWZvciAo aW50IGkgPSAwOyBpIDwgZXNfcGFpci0+bnJfc3RyZWFtczsgaSsrKSB7CnRvb2xzL3BlcmYvdXRp bC9zdHJlYW0uYzoJZm9yIChpbnQgaSA9IDA7IGkgPCBlc19iYXNlLT5ucl9zdHJlYW1zOyBpKysp IHsKdG9vbHMvcGVyZi91dGlsL2NwdW1hcC5jOgkJZm9yIChpbnQgaiA9IDA7IGogPCBjLT5ucjsg aisrKSB7CnRvb2xzL3BlcmYvdXRpbC9tZW0tZXZlbnRzLmM6CWZvciAoaW50IGogPSAwOyBqIDwg UEVSRl9NRU1fRVZFTlRTX19NQVg7IGorKykgewp0b29scy9wZXJmL3V0aWwvaGVhZGVyLmM6CWZv ciAoaW50IGkgPSAwOyBpIDwgZmYtPnBoLT5lbnYubnJfaHlicmlkX2NwY19ub2RlczsgaSsrKSB7 CnRvb2xzL3BlcmYvYnVpbHRpbi1kaWZmLmM6CWZvciAoaW50IGkgPSAwOyBpIDwgbnVtOyBpKysp CnRvb2xzL3BlcmYvYnVpbHRpbi1kaWZmLmM6CQlmb3IgKGludCBpID0gMDsgaSA8IHBhaXItPmJs b2NrX2luZm8tPm51bTsgaSsrKSB7CnRvb2xzL3BlcmYvYnVpbHRpbi1zdGF0LmM6CWZvciAoaW50 IGkgPSAwOyBpIDwgcGVyZl9jcHVfbWFwX19ucihhLT5jb3JlLmNwdXMpOyBpKyspIHsK4qyiW2Fj bWVAdG9vbGJveCBwZXJmXSQKCkFuZCB0aGlzIGJ1aWxkcyBvbiBhbGwgbXkgdGVzdCBjb250YWlu ZXJzLCBwbGVhc2UgdXNlOgoKCWZvciAoaW50IGkgPSAwLCBqID0gMDsgaSA8IGEtPm5yOyBpKysp CgpJbiB0aGlzIGNhc2UgdG8gbWFrZSB0aGUgc291cmNlIGNvZGUgbW9yZSBjb21wYWN0LgoKPiAr CQlpZiAoYS0+bWFwW2ldLmNwdSA+IGItPm1hcFtqXS5jcHUpCj4gKwkJCXJldHVybiBmYWxzZTsK PiArCQlpZiAoYS0+bWFwW2ldLmNwdSA9PSBiLT5tYXBbal0uY3B1KSB7Cj4gKwkJCWorKzsKPiAr CQkJaWYgKGogPT0gYi0+bnIpCj4gKwkJCQlyZXR1cm4gdHJ1ZTsKCk9rLCBhcyBpdHMgZ3VhcmFu dGVlZCB0aGF0IGNwdV9tYXBzIGFyZSBvcmRlcmVkLgoKPiArCQl9Cj4gKwl9Cj4gKwlyZXR1cm4g ZmFsc2U7Cj4gK30KPiArCj4gIC8qCj4gICAqIE1lcmdlIHR3byBjcHVtYXBzCj4gICAqCj4gQEAg LTMzNSwxNyArMzU4LDEyIEBAIHN0cnVjdCBwZXJmX2NwdV9tYXAgKnBlcmZfY3B1X21hcF9fbWVy Z2Uoc3RydWN0IHBlcmZfY3B1X21hcCAqb3JpZywKPiAgCWludCBpLCBqLCBrOwo+ICAJc3RydWN0 IHBlcmZfY3B1X21hcCAqbWVyZ2VkOwo+ICAKPiAtCWlmICghb3JpZyAmJiAhb3RoZXIpCj4gLQkJ cmV0dXJuIE5VTEw7Cj4gLQlpZiAoIW9yaWcpIHsKPiAtCQlwZXJmX2NwdV9tYXBfX2dldChvdGhl cik7Cj4gLQkJcmV0dXJuIG90aGVyOwo+IC0JfQo+IC0JaWYgKCFvdGhlcikKPiAtCQlyZXR1cm4g b3JpZzsKPiAtCWlmIChvcmlnLT5uciA9PSBvdGhlci0+bnIgJiYKPiAtCSAgICAhbWVtY21wKG9y aWctPm1hcCwgb3RoZXItPm1hcCwgb3JpZy0+bnIgKiBzaXplb2Yoc3RydWN0IHBlcmZfY3B1KSkp Cj4gKwlpZiAocGVyZl9jcHVfbWFwX19pc19zdWJzZXQob3JpZywgb3RoZXIpKQo+ICAJCXJldHVy biBvcmlnOwoKQ2FuJ3Qgd2UgaGF2ZSBmaXJzdCB0aGUgaW50cm9kdWN0aW9uIG9mIHBlcmZfY3B1 X21hcF9faXNfc3Vic2V0KCkgYW5kCnRoZW4gYW5vdGhlciBwYXRjaCB0aGF0IGdldHMgdGhlIHJl ZmNvdW50LCBpLmUuIHRoZSBmb3VyIGxpbmVzIGJlbG93PwoKPiArCWlmIChwZXJmX2NwdV9tYXBf X2lzX3N1YnNldChvdGhlciwgb3JpZykpIHsKPiArCQlwZXJmX2NwdV9tYXBfX3B1dChvcmlnKTsK PiArCQlyZXR1cm4gcGVyZl9jcHVfbWFwX19nZXQob3RoZXIpOwo+ICsJfQo+ICAKPiAgCXRtcF9s ZW4gPSBvcmlnLT5uciArIG90aGVyLT5ucjsKPiAgCXRtcF9jcHVzID0gbWFsbG9jKHRtcF9sZW4g KiBzaXplb2Yoc3RydWN0IHBlcmZfY3B1KSk7Cj4gLS0gCj4gMi4zNS4xLjEwMjEuZzM4MTEwMWIw NzUtZ29vZwoKLS0gCgotIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK