From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E162310E8C5
 for <igt-dev@lists.freedesktop.org>; Tue, 29 Mar 2022 15:31:17 +0000 (UTC)
Date: Tue, 29 Mar 2022 17:31:13 +0200
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Message-ID: <YkMmQQhCrWaZYr3C@kamilkon-DESK1>
References: <20220311063453.180090-1-priyanka.dandamudi@intel.com>
 <20220311063453.180090-2-priyanka.dandamudi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220311063453.180090-2-priyanka.dandamudi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_wait: Add description for
 test and subtests
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

Hi Priyanka,

Dnia 2022-03-11 at 12:04:52 +0530, priyanka.dandamudi@intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Add description for test and all the subtests
> 
> v2: Rebase
> 
> v3: Modified descriptions
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh@intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> ---
>  tests/i915/gem_wait.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
> index b17927b6..860a615c 100644
> --- a/tests/i915/gem_wait.c
> +++ b/tests/i915/gem_wait.c
> @@ -32,6 +32,8 @@
>  #include "igt.h"
>  #include "igt_vgem.h"
>  
> +IGT_TEST_DESCRIPTION("Tests the GEM_WAIT ioctl");
> +
>  static int __gem_wait(int fd, struct drm_i915_gem_wait *w)
>  {
>  	int err;
> @@ -185,9 +187,11 @@ igt_main
>  		ctx = intel_ctx_create_all_physical(fd);
>  	}
>  
> +	igt_describe("Verify that GEM_WAIT called with invalid flag will fail.");
>  	igt_subtest("invalid-flags")
>  		invalid_flags(fd);
>  
> +	igt_describe("Verify that GEM_WAIT called with invalid buffer object will fail.");
>  	igt_subtest("invalid-buf")
>  		invalid_buf(fd);
>  
> @@ -209,8 +213,11 @@ igt_main
>  			igt_fork_signal_helper();
>  		}
>  
> -		for (const typeof(*tests) *t = tests; t->name; t++)
> +		for (const typeof(*tests) *t = tests; t->name; t++) {
> +			igt_describe_f("Verify GEM_WAIT basic functionality in"
------------------------------------------------------- ^
imho remove "basic" from here, as you did below. With this fixed
you can add my r-b tag.

Regards,
Kamil

> +				       " %s mode.", t->name);
>  			test_all_engines(t->name, fd, ctx, t->flags);
> +		}
>  
>  		igt_fixture {
>  			igt_stop_signal_helper();
> @@ -236,8 +243,11 @@ igt_main
>  			igt_fork_signal_helper();
>  		}
>  
> -		for (const typeof(*tests) *t = tests; t->name; t++)
> +		for (const typeof(*tests) *t = tests; t->name; t++) {
> +			igt_describe_f("Verify GEM_WAIT functionality in %s mode,"
> +				       " when hang is allowed.", (t->name+5));
>  			test_all_engines(t->name, fd, ctx, t->flags);
> +		}
>  
>  		igt_fixture {
>  			igt_stop_signal_helper();
> -- 
> 2.25.1
>