From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9899C433EF for ; Tue, 29 Mar 2022 15:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238840AbiC2PqU (ORCPT ); Tue, 29 Mar 2022 11:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235919AbiC2PqT (ORCPT ); Tue, 29 Mar 2022 11:46:19 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9EEE12097; Tue, 29 Mar 2022 08:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648568676; x=1680104676; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1eyN9S0VYCjwyCwpGV/EAhe6tNDLsqDHkUFt5FhErFc=; b=go6KHNnloIJi6TgK2WzbMJu19TtUXHGc40RHsTyDiE9JzL/intWg4kIx IUXk5tzO7UxpHB2uvg3SiRLCiSa9B581JR+GfFUztMXzmREsYNBKG2R5F XKZJx7NAfVvpcbJ7MbP34k1NdbKNPzuW3wki8I0CEAozxXvpzMHLZfBjX KOwzkb7SXQCGK+wTMl/U7uDUOOIHa/AmCz8Ykgb9A+p1fqtntl7BEZlJx E7FgIcLet3JnrQrKmttUm14WEQwr/ePgxTbshIwM8RvX8FTmAfQUvfY5/ PeBIIGxoSNfeKDatgRkOe1Q6mLkCR+4X2UOeo1thBDdq/eqRaz3tJoQHm Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="258994634" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="258994634" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 08:44:36 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="649491727" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 08:44:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZE0l-008pwc-Jr; Tue, 29 Mar 2022 18:43:59 +0300 Date: Tue, 29 Mar 2022 18:43:59 +0300 From: Andy Shevchenko To: Miquel Raynal Cc: Geert Uytterhoeven , Magnus Damm , Greg Kroah-Hartman , Jiri Slaby , linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org, Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger Subject: Re: [PATCH v3 03/10] serial: 8250: dw: Change the quirks type to unsigned int Message-ID: References: <20220329152430.756947-1-miquel.raynal@bootlin.com> <20220329152430.756947-4-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329152430.756947-4-miquel.raynal@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, Mar 29, 2022 at 05:24:23PM +0200, Miquel Raynal wrote: > Unsigned int is better than unsigned long as its size does not change > between setups and we don't really need this variable to be more than a > few bits wide for now. > > Suggested-by: Suggested-by: Andy Shevchenko One tag is enough :-) Looking into the following patch, I think you may squash this one into it, just add an explanation in the commit message that you reduced variable for quirks. -- With Best Regards, Andy Shevchenko