* [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
@ 2022-03-29 14:00 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2022-03-29 14:00 UTC (permalink / raw)
To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar
Cc: Mark Brown, linux-mtd, linux-spi, linux-renesas-soc, Geert Uytterhoeven
If rpcif_hw_init() fails, Runtime PM is left enabled.
Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For the mtd tree.
drivers/mtd/hyperbus/rpc-if.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c
index 6e08ec1d4f098c80..b70d259e48a7c728 100644
--- a/drivers/mtd/hyperbus/rpc-if.c
+++ b/drivers/mtd/hyperbus/rpc-if.c
@@ -134,7 +134,7 @@ static int rpcif_hb_probe(struct platform_device *pdev)
error = rpcif_hw_init(&hyperbus->rpc, true);
if (error)
- return error;
+ goto out_disable_rpm;
hyperbus->hbdev.map.size = hyperbus->rpc.size;
hyperbus->hbdev.map.virt = hyperbus->rpc.dirmap;
@@ -145,8 +145,12 @@ static int rpcif_hb_probe(struct platform_device *pdev)
hyperbus->hbdev.np = of_get_next_child(pdev->dev.parent->of_node, NULL);
error = hyperbus_register_device(&hyperbus->hbdev);
if (error)
- rpcif_disable_rpm(&hyperbus->rpc);
+ goto out_disable_rpm;
+
+ return 0;
+out_disable_rpm:
+ rpcif_disable_rpm(&hyperbus->rpc);
return error;
}
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-03-29 14:00 ` Geert Uytterhoeven
-1 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2022-03-29 14:00 UTC (permalink / raw)
To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar
Cc: Mark Brown, linux-mtd, linux-spi, linux-renesas-soc, Geert Uytterhoeven
If rpcif_hw_init() fails, Runtime PM is left enabled.
Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For the spi tree.
drivers/spi/spi-rpc-if.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c
index fe82f3575df4f386..24ec1c83f379ceec 100644
--- a/drivers/spi/spi-rpc-if.c
+++ b/drivers/spi/spi-rpc-if.c
@@ -158,14 +158,18 @@ static int rpcif_spi_probe(struct platform_device *pdev)
error = rpcif_hw_init(rpc, false);
if (error)
- return error;
+ goto out_disable_rpm;
error = spi_register_controller(ctlr);
if (error) {
dev_err(&pdev->dev, "spi_register_controller failed\n");
- rpcif_disable_rpm(rpc);
+ goto out_disable_rpm;
}
+ return 0;
+
+out_disable_rpm:
+ rpcif_disable_rpm(rpc);
return error;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
@ 2022-03-29 14:00 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2022-03-29 14:00 UTC (permalink / raw)
To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar
Cc: Mark Brown, linux-mtd, linux-spi, linux-renesas-soc, Geert Uytterhoeven
If rpcif_hw_init() fails, Runtime PM is left enabled.
Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For the spi tree.
drivers/spi/spi-rpc-if.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c
index fe82f3575df4f386..24ec1c83f379ceec 100644
--- a/drivers/spi/spi-rpc-if.c
+++ b/drivers/spi/spi-rpc-if.c
@@ -158,14 +158,18 @@ static int rpcif_spi_probe(struct platform_device *pdev)
error = rpcif_hw_init(rpc, false);
if (error)
- return error;
+ goto out_disable_rpm;
error = spi_register_controller(ctlr);
if (error) {
dev_err(&pdev->dev, "spi_register_controller failed\n");
- rpcif_disable_rpm(rpc);
+ goto out_disable_rpm;
}
+ return 0;
+
+out_disable_rpm:
+ rpcif_disable_rpm(rpc);
return error;
}
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-03-29 19:31 ` Wolfram Sang
-1 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2022-03-29 19:31 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Krzysztof Kozlowski, Lad Prabhakar, Mark Brown, linux-mtd,
linux-spi, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Tue, Mar 29, 2022 at 04:00:39PM +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
@ 2022-03-29 19:31 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2022-03-29 19:31 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Krzysztof Kozlowski, Lad Prabhakar, Mark Brown, linux-mtd,
linux-spi, linux-renesas-soc
[-- Attachment #1.1: Type: text/plain, Size: 337 bytes --]
On Tue, Mar 29, 2022 at 04:00:39PM +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-04-04 13:37 ` Lad, Prabhakar
-1 siblings, 0 replies; 14+ messages in thread
From: Lad, Prabhakar @ 2022-04-04 13:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar, Mark Brown,
linux-mtd, linux-spi, Linux-Renesas
On Tue, Mar 29, 2022 at 8:13 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For the spi tree.
>
> drivers/spi/spi-rpc-if.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] spi: rpc-if: Fix RPM imbalance in probe error path
@ 2022-04-04 13:37 ` Lad, Prabhakar
0 siblings, 0 replies; 14+ messages in thread
From: Lad, Prabhakar @ 2022-04-04 13:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar, Mark Brown,
linux-mtd, linux-spi, Linux-Renesas
On Tue, Mar 29, 2022 at 8:13 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For the spi tree.
>
> drivers/spi/spi-rpc-if.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-03-29 19:30 ` Wolfram Sang
-1 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2022-03-29 19:30 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Krzysztof Kozlowski, Lad Prabhakar, Mark Brown, linux-mtd,
linux-spi, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Tue, Mar 29, 2022 at 04:00:38PM +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Good catch!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
@ 2022-03-29 19:30 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2022-03-29 19:30 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Krzysztof Kozlowski, Lad Prabhakar, Mark Brown, linux-mtd,
linux-spi, linux-renesas-soc
[-- Attachment #1.1: Type: text/plain, Size: 352 bytes --]
On Tue, Mar 29, 2022 at 04:00:38PM +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Good catch!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-04-04 13:34 ` Lad, Prabhakar
-1 siblings, 0 replies; 14+ messages in thread
From: Lad, Prabhakar @ 2022-04-04 13:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar, Mark Brown,
linux-mtd, linux-spi, Linux-Renesas
On Tue, Mar 29, 2022 at 3:09 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For the mtd tree.
>
> drivers/mtd/hyperbus/rpc-if.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
@ 2022-04-04 13:34 ` Lad, Prabhakar
0 siblings, 0 replies; 14+ messages in thread
From: Lad, Prabhakar @ 2022-04-04 13:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger, Biju Das,
Wolfram Sang, Krzysztof Kozlowski, Lad Prabhakar, Mark Brown,
linux-mtd, linux-spi, Linux-Renesas
On Tue, Mar 29, 2022 at 3:09 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
> Fixes: b04cc0d912eb80d3 ("memory: renesas-rpc-if: Add support for RZ/G2L")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For the mtd tree.
>
> drivers/mtd/hyperbus/rpc-if.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: (subset) [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
2022-03-29 14:00 ` Geert Uytterhoeven
@ 2022-04-05 9:32 ` Mark Brown
-1 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2022-04-05 9:32 UTC (permalink / raw)
To: vigneshr, richard, wsa+renesas, geert+renesas, biju.das.jz,
prabhakar.mahadev-lad.rj, miquel.raynal, krzk
Cc: linux-spi, linux-mtd, linux-renesas-soc
On Tue, 29 Mar 2022 16:00:38 +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[2/2] spi: rpc-if: Fix RPM imbalance in probe error path
commit: 2f8cf5f642e80f8b6b0e660a9c86924a1f41cd80
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: (subset) [PATCH 1/2] mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path
@ 2022-04-05 9:32 ` Mark Brown
0 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2022-04-05 9:32 UTC (permalink / raw)
To: vigneshr, richard, wsa+renesas, geert+renesas, biju.das.jz,
prabhakar.mahadev-lad.rj, miquel.raynal, krzk
Cc: linux-spi, linux-mtd, linux-renesas-soc
On Tue, 29 Mar 2022 16:00:38 +0200, Geert Uytterhoeven wrote:
> If rpcif_hw_init() fails, Runtime PM is left enabled.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[2/2] spi: rpc-if: Fix RPM imbalance in probe error path
commit: 2f8cf5f642e80f8b6b0e660a9c86924a1f41cd80
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 14+ messages in thread