All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steve French <smfrench@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	CIFS <linux-cifs@vger.kernel.org>,
	Namjae Jeon <linkinjeon@kernel.org>
Subject: Re: [GIT PULL] ksmbd server fixes
Date: Wed, 30 Mar 2022 02:17:28 -0700	[thread overview]
Message-ID: <YkQgKKmPYxzcf19t@infradead.org> (raw)
In-Reply-To: <CAHk-=whvfwQdpHv0E6UmaSeYKRYFL_CmaiGa8beCXdtX93U32w@mail.gmail.com>

On Tue, Mar 29, 2022 at 06:48:51PM -0700, Linus Torvalds wrote:
> On Mon, Mar 28, 2022 at 6:39 PM Steve French <smfrench@gmail.com> wrote:
> >
> > - four patches relating to dentry race
> 
> I took a look at this, and I absolutely hate it.
> 
> You are basically exporting vfs-internal functions (__lookup_hash() in
> particular) that really shouldn't be exported.

It really shouldn't indeed, and I'm rather worried that this pull
request just exports it without any relevant ACKs.

> And the _reason_ you are exporting them seems to be that you have
> copied most of do_renameat2() as ksmbd_vfs_rename() but then made
> various small changes.
> 
> This all makes me _very_ uncomfortable.
> 
> I really get the feeling that we'd be much better off exporting
> something that is just a bigger part of that rename logic, not that
> really low-level __lookup_hash() thing.

Agreed.

  parent reply	other threads:[~2022-03-30  9:17 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  1:39 [GIT PULL] ksmbd server fixes Steve French
2022-03-30  1:48 ` Linus Torvalds
2022-03-30  1:57   ` Steve French
2022-03-30  2:23   ` Linus Torvalds
2022-03-30  9:18     ` Christoph Hellwig
2022-03-30  9:17   ` Christoph Hellwig [this message]
2022-04-01  1:20   ` Al Viro
2022-04-01 12:52     ` Namjae Jeon
2022-04-01 13:34       ` Al Viro
2022-04-01 14:58         ` Namjae Jeon
  -- strict thread matches above, loose matches on Subject: below --
2024-04-22 23:20 Steve French
2024-04-22 23:51 ` pr-tracker-bot
2024-04-05  3:15 Steve French
2024-04-05 17:09 ` pr-tracker-bot
2024-03-20 17:06 Steve French
2024-03-20 23:46 ` pr-tracker-bot
2024-02-10  1:45 Steve French
2024-02-10 16:26 ` pr-tracker-bot
2024-01-27  7:20 Steve French
2024-01-27 17:21 ` pr-tracker-bot
2024-01-18  0:39 Steve French
2024-01-19 18:03 ` pr-tracker-bot
2024-01-11 14:20 Steve French
2024-01-12  5:07 ` pr-tracker-bot
2023-11-27 21:00 Steve French
2023-11-28  1:26 ` pr-tracker-bot
2023-11-10  7:16 Steve French
2023-11-10 18:47 ` pr-tracker-bot
2023-11-02  2:46 Steve French
2023-11-02 18:38 ` pr-tracker-bot
2023-10-15  2:46 Steve French
2023-10-15  2:52 ` pr-tracker-bot
2023-10-08  4:27 Steve French
2023-10-08 18:06 ` pr-tracker-bot
2023-09-29 22:11 Steve French
2023-09-29 23:59 ` pr-tracker-bot
2023-09-17  1:55 Steve French
2023-09-17 18:24 ` pr-tracker-bot
2023-08-09 23:11 Steve French
2023-08-10  5:02 ` pr-tracker-bot
2023-07-26  6:17 Steve French
2023-07-26 18:42 ` pr-tracker-bot
2023-06-30  5:59 Steve French
2023-07-01  5:04 ` pr-tracker-bot
2023-06-20  4:45 Steve French
2023-06-20 19:01 ` pr-tracker-bot
2023-06-11  1:59 Steve French
2023-06-11 17:43 ` pr-tracker-bot
2023-05-21  5:14 Steve French
2023-05-21 18:06 ` Linus Torvalds
2023-05-21 18:32   ` Linus Torvalds
2023-05-21 19:03   ` Steve French
2023-05-21 19:21     ` Linus Torvalds
2023-05-22  4:38       ` Steve French
2023-05-22  8:04         ` ronnie sahlberg
2023-05-21 18:09 ` pr-tracker-bot
2023-05-06  0:19 Steve French
2023-05-06  2:20 ` pr-tracker-bot
2023-04-27  2:11 Steve French
2023-04-29 18:19 ` pr-tracker-bot
2023-04-07  4:16 Steve French
2023-04-07 20:56 ` pr-tracker-bot
2023-03-25  0:00 Steve French
2023-03-25  1:18 ` pr-tracker-bot
2023-02-22  4:15 Steve French
2023-02-22 22:26 ` pr-tracker-bot
2023-01-28  1:45 Steve French
2023-01-28 19:33 ` pr-tracker-bot
2023-01-10  3:13 Steve French
2023-01-10 11:36 ` pr-tracker-bot
2022-12-15  3:18 Steve French
2022-12-15 17:32 ` Linus Torvalds
2022-12-15 18:28 ` pr-tracker-bot
2022-10-06 23:53 Steve French
2022-10-07 17:00 ` pr-tracker-bot
2022-08-19  5:03 Steve French
2022-08-19 21:14 ` pr-tracker-bot
2022-08-08 20:00 Steve French
2022-08-09  3:20 ` pr-tracker-bot
2022-06-28 22:07 Steve French
2022-06-29 16:44 ` pr-tracker-bot
2022-06-01  6:20 Steve French
2022-06-01 19:34 ` pr-tracker-bot
2022-04-24  0:10 Steve French
2022-04-24  0:32 ` pr-tracker-bot
2022-04-01 18:40 Steve French
2022-04-01 21:41 ` Linus Torvalds
2022-04-01 21:45 ` pr-tracker-bot
2022-02-07 21:04 Steve French
2022-02-07 23:34 ` pr-tracker-bot
2021-11-27 21:43 Steve French
2021-11-27 22:52 ` pr-tracker-bot
2021-09-26 12:13 Steve French
2021-09-26 21:11 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkQgKKmPYxzcf19t@infradead.org \
    --to=hch@infradead.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.