From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D07DC433EF for ; Wed, 30 Mar 2022 14:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347022AbiC3OmT (ORCPT ); Wed, 30 Mar 2022 10:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244124AbiC3OmP (ORCPT ); Wed, 30 Mar 2022 10:42:15 -0400 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6A453B7C; Wed, 30 Mar 2022 07:40:30 -0700 (PDT) Received: by mail-ot1-f54.google.com with SMTP id i23-20020a9d6117000000b005cb58c354e6so15035492otj.10; Wed, 30 Mar 2022 07:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WluG5A3Su9h6kButSakciwh97/HOUIf+fbIX970BGps=; b=5UTR25fk0eCnYZHCswINXb8g2foHBrXOVsMdSRzVUaORw2clQLqpLUgBG2LoeaCCzo EevNGFJJoBSjQB2pAuFldOplvxp4xr/gkkC7/kzaS548SLyJx6O0NHKXxswIkjFtLFyZ I+9SswivJELTcXkF1utwG/TuiAB+bwR1movajntxM8CJNemuoP8DBumnRbyB1WBpOGRE +fiaP54AnHFXJxyHOyfcOB93YTq0IJUh9lIJRuVaWAB28PHJWO8lRdsZyoQMzaRxevLZ QT4ncJVmBFglKkAV18ERMwPwG7KdYOQDoQ4JiJWiRfWyKGu9vDg6jYNUjOdaqTeqn1Qe JPeA== X-Gm-Message-State: AOAM533aGvwqtlAnTrNU74BwhSrg6RtzwjzMRqRN5WR2cAFuusVDCGI+ 14o9Nj0mLz807tVeq1XNTw== X-Google-Smtp-Source: ABdhPJwBBRjRl69m95mUWUdtBlAPdWiXCOSKHrQW8piO6H7rRiDBWu53Pcr1z0ZJDoY2oW17y4smCA== X-Received: by 2002:a9d:74da:0:b0:5cd:b164:6daf with SMTP id a26-20020a9d74da000000b005cdb1646dafmr3414136otl.231.1648651229564; Wed, 30 Mar 2022 07:40:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c3-20020a056808138300b002f76b9a9ef6sm2137595oiw.10.2022.03.30.07.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 07:40:27 -0700 (PDT) Received: (nullmailer pid 3015921 invoked by uid 1000); Wed, 30 Mar 2022 14:40:27 -0000 Date: Wed, 30 Mar 2022 09:40:27 -0500 From: Rob Herring To: Chris Packham Cc: Krzysztof Kozlowski , "andrew@lunn.ch" , "ulf.hansson@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" , "gregory.clement@bootlin.com" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "krzk+dt@kernel.org" , "huziji@marvell.com" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Message-ID: References: <20220329000231.3544810-1-chris.packham@alliedtelesis.co.nz> <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> <1648554629.870840.350362.nullmailer@robh.at.kernel.org> <6e118704-3c63-929e-ebf0-9a78fbed5daa@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e118704-3c63-929e-ebf0-9a78fbed5daa@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 07:50:59PM +0000, Chris Packham wrote: > > On 30/03/22 02:14, Krzysztof Kozlowski wrote: > > On 29/03/2022 13:50, Rob Herring wrote: > >> On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote: > >>> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the > >>> in-tree dts files don't validate because they use sdhci@ instead of mmc@ > >>> as required by the generic mmc-controller schema. > >>> > >>> The compatible "marvell,sdhci-xenon" was not documented in the old > >>> binding but it accompanies the of "marvell,armada-3700-sdhci" in the > >>> armada-37xx SoC dtsi so this combination is added to the new binding > >>> document. > >>> > >>> Signed-off-by: Chris Packham > >>> Reviewed-by: Krzysztof Kozlowski > >>> --- > >>> > >>> Notes: > >>> Changes in v4: > >>> - Add review from Krzysztof > >>> - Squash in addition of marvell,sdhci-xenon with an explanation in the > >>> commit message > >>> Changes in v3: > >>> - Don't accept ap807 without ap806 > >>> - Add ref: string for pad-type > >>> Changes in v2: > >>> - Update MAINTAINERS entry > >>> - Incorporate feedback from Krzysztof > >>> > >>> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ----------- > >>> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++ > >>> MAINTAINERS | 2 +- > >>> 3 files changed, 276 insertions(+), 174 deletions(-) > >>> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > >>> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >>> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed: > >> ['marvell,armada-3700-sdhci'] is too short > >> 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > >> 'marvell,armada-ap807-sdhci' was expected > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed: > >> ['marvell,armada-3700-sdhci'] is too short > >> 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > >> 'marvell,armada-ap807-sdhci' was expected > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >> > >> doc reference errors (make refcheckdocs): > > Chris, your own dt binding does not pass it's check (example)... > > > > After updating the compatibles, you need to check the example. The > > examples are anyway duplicating common stuff, so half of them could be > > removed. > > Yeah silly me. I started taking short cuts to run dt_binding_check > dtbs_check as one command but then the dt_bindings_check output scrolled > off the top of my terminal. > > As for the examples themselves I want to leave what's there as a fairly > direct translation of the old binding. If we consider them unnecessary > removing them can be done as a follow-up. The examples cannot have warnings/errors. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6071EC433F5 for ; Wed, 30 Mar 2022 14:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=swtVpyLaHSWrRfp2Id2t24hFJxkonMrhkiQkGMkDXV8=; b=pRQCMoNa8PfVmO gsp21ljp/9i4i+ZQ3oMK4/vYIHVO+ZwS7wOs9jIjVGUNsC0MBQNO7fAnBGZkxqUqbaxKR8bqfR+GZ pYnkK02Lw7hpR/rLBatJBcPG1W/vb9FVrMMxfTwbrgm8v3Uvz4IEACdGgm8pMl3CiGSebodTD61zO 71b8vQEmHMY2J+v616pfYKr4DyTNS1wBT0NXJN1xLuPMp9hxVkyWV0emKbOn71Z5qiTx6CrHaZoq+ qiJGcd8F+R+YXAnLNwG9P406X01MNIJrb7RnS2X2247RHvcGxNDur3NWoX37NWFcFVzJ0bYSW4HEL dVHgZZ2S3IBBfkH0twrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZZUx-00GGl2-R4; Wed, 30 Mar 2022 14:40:35 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZZUu-00GGjt-B2 for linux-arm-kernel@lists.infradead.org; Wed, 30 Mar 2022 14:40:33 +0000 Received: by mail-ot1-f42.google.com with SMTP id y3-20020a056830070300b005cd9c4d03feso15037027ots.3 for ; Wed, 30 Mar 2022 07:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WluG5A3Su9h6kButSakciwh97/HOUIf+fbIX970BGps=; b=dJEDjj5SkqPnokAZIzlIYnrV5JRyD0piWtU09VswrClmOYLevZXa3/UFEVJf0aTdHT KB47wcvyBWoVxnMafPwf2ifWVV3YQAvkMOB8DBlXpf6Nyxi2wZLgJ8tWPGRTLLJckzTG 5fFt04HL2w1eyvkYWDWtNLG7AjWW24TtNxTJEp/Q/aM09R9Jr2pEjXfalDFtHHCjZXKu D+D54Sb9+XWMa9DzSGnEHZvTWBrmLgwEY/h5acx2OcUEq3QMguulcRF/x4ZS3gg31YZR 4+4HbNqbx5yuwGwOh43Y9vvuRCJfSV1BKcoFP20PrnS8l1qDP9Qhjc+OhFBC19QP5pVu o+Uw== X-Gm-Message-State: AOAM530OHac4V2CJ0nFdSEgu4HnBgnv7xkpWF92OWnOsOX7pWEcvWMW2 lIVSqXI4zZNVUmi3OmHn3A== X-Google-Smtp-Source: ABdhPJwBBRjRl69m95mUWUdtBlAPdWiXCOSKHrQW8piO6H7rRiDBWu53Pcr1z0ZJDoY2oW17y4smCA== X-Received: by 2002:a9d:74da:0:b0:5cd:b164:6daf with SMTP id a26-20020a9d74da000000b005cdb1646dafmr3414136otl.231.1648651229564; Wed, 30 Mar 2022 07:40:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c3-20020a056808138300b002f76b9a9ef6sm2137595oiw.10.2022.03.30.07.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 07:40:27 -0700 (PDT) Received: (nullmailer pid 3015921 invoked by uid 1000); Wed, 30 Mar 2022 14:40:27 -0000 Date: Wed, 30 Mar 2022 09:40:27 -0500 From: Rob Herring To: Chris Packham Cc: Krzysztof Kozlowski , "andrew@lunn.ch" , "ulf.hansson@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" , "gregory.clement@bootlin.com" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "krzk+dt@kernel.org" , "huziji@marvell.com" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Message-ID: References: <20220329000231.3544810-1-chris.packham@alliedtelesis.co.nz> <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> <1648554629.870840.350362.nullmailer@robh.at.kernel.org> <6e118704-3c63-929e-ebf0-9a78fbed5daa@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6e118704-3c63-929e-ebf0-9a78fbed5daa@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220330_074032_411785_94970D84 X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 29, 2022 at 07:50:59PM +0000, Chris Packham wrote: > > On 30/03/22 02:14, Krzysztof Kozlowski wrote: > > On 29/03/2022 13:50, Rob Herring wrote: > >> On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote: > >>> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the > >>> in-tree dts files don't validate because they use sdhci@ instead of mmc@ > >>> as required by the generic mmc-controller schema. > >>> > >>> The compatible "marvell,sdhci-xenon" was not documented in the old > >>> binding but it accompanies the of "marvell,armada-3700-sdhci" in the > >>> armada-37xx SoC dtsi so this combination is added to the new binding > >>> document. > >>> > >>> Signed-off-by: Chris Packham > >>> Reviewed-by: Krzysztof Kozlowski > >>> --- > >>> > >>> Notes: > >>> Changes in v4: > >>> - Add review from Krzysztof > >>> - Squash in addition of marvell,sdhci-xenon with an explanation in the > >>> commit message > >>> Changes in v3: > >>> - Don't accept ap807 without ap806 > >>> - Add ref: string for pad-type > >>> Changes in v2: > >>> - Update MAINTAINERS entry > >>> - Incorporate feedback from Krzysztof > >>> > >>> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ----------- > >>> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++ > >>> MAINTAINERS | 2 +- > >>> 3 files changed, 276 insertions(+), 174 deletions(-) > >>> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > >>> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >>> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed: > >> ['marvell,armada-3700-sdhci'] is too short > >> 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > >> 'marvell,armada-ap807-sdhci' was expected > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed: > >> ['marvell,armada-3700-sdhci'] is too short > >> 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] > >> 'marvell,armada-ap807-sdhci' was expected > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > >> > >> doc reference errors (make refcheckdocs): > > Chris, your own dt binding does not pass it's check (example)... > > > > After updating the compatibles, you need to check the example. The > > examples are anyway duplicating common stuff, so half of them could be > > removed. > > Yeah silly me. I started taking short cuts to run dt_binding_check > dtbs_check as one command but then the dt_bindings_check output scrolled > off the top of my terminal. > > As for the examples themselves I want to leave what's there as a fairly > direct translation of the old binding. If we consider them unnecessary > removing them can be done as a follow-up. The examples cannot have warnings/errors. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel