From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38BAC433EF for ; Wed, 30 Mar 2022 18:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349646AbiC3SEB (ORCPT ); Wed, 30 Mar 2022 14:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349634AbiC3SD7 (ORCPT ); Wed, 30 Mar 2022 14:03:59 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D785103BBC for ; Wed, 30 Mar 2022 11:02:12 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id bx5so21461153pjb.3 for ; Wed, 30 Mar 2022 11:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1t7ZTcfgKbtCrh+Z8QzaoA6bXs0GJ9EG7KZ7T9mNkyo=; b=Qnc0FbV8QW9nWNUOQwd6/VL3i7W1mRJNkjUHl2lrMu1esd+LZ8H5X7HdBuqE7iT02e BbcHWea0WsPYpgJZd1t1tLzqf8zAvoF3JrXkRfv9Qf3rD2plPb0pqBL5YozYI77OG0Jm inbNIW+pd/UC9m0MMRX5dl4x1tcS3hmOwxrJ4YkrTT5Aj+AxPnQqC/Y5C7rMYG2TDUit X54n5lQR9HCBt53ElkMeirueeHikr967anl32qZ9taBIT/irIR0uxCOODF/WHJq42sSz x0r6FrOV5tSe3kvftlYtWDC2qhaSyLTsI12TACUxUfsVxe9ZR6dOZi4IqSXRpqQc9wCD IQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1t7ZTcfgKbtCrh+Z8QzaoA6bXs0GJ9EG7KZ7T9mNkyo=; b=WHqMqu/DmVhuH5qT1udM260biPdfViaPaims0hB7I9+Xax4Z3U4NY0MPys+zvOg3Q4 wu+4jPLN3T5rSPFgtk4LMKoefyg6GE/ccbPtskXc4pXI8U46aoAEduEXx6c3cbqHHv2t S6QM2YNF50jqMtGCFXj2FK9NNQkVuQkZUNHOIjMH3++J262TsrXX2MfUoEF3z7vafKaH bNMKmH3SJSUaG1Cqmr3dQrb/E5py7RGL8bZRLC//M3sN7gwz31LDu+R4pwFz8UaOYHFz KmaL9kVp9Et7ZlkaBUb5VjiXKTjKVYUH1Rm7LWmWX3WvKsR0Fmryvm97vA+evEcNzjlw UmwA== X-Gm-Message-State: AOAM532K9MEsTyomKvqcavKnJLxS3jtms7oFViWmatUzJaiA/Mq40/AO s++ifNP4tyAoeYz9fgBRenoZxw== X-Google-Smtp-Source: ABdhPJzh0mo9Te1Jek3HXgFffthHCfqhTf4wEFIFy/INCb3Ksp0Y0whGDEpzp1MDM0LMhP07MuB7fA== X-Received: by 2002:a17:902:7c0d:b0:155:d507:3cf0 with SMTP id x13-20020a1709027c0d00b00155d5073cf0mr501879pll.103.1648663331634; Wed, 30 Mar 2022 11:02:11 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id be11-20020a056a001f0b00b004fb29215dd9sm14648311pfb.30.2022.03.30.11.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 11:02:11 -0700 (PDT) Date: Wed, 30 Mar 2022 18:02:07 +0000 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , David Matlack , Jim Mattson , David Dunn , Jing Zhang , Junaid Shahid Subject: Re: [PATCH v3 10/11] KVM: x86/MMU: Require reboot permission to disable NX hugepages Message-ID: References: <20220330174621.1567317-1-bgardon@google.com> <20220330174621.1567317-11-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330174621.1567317-11-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022, Ben Gardon wrote: > Ensure that the userspace actor attempting to disable NX hugepages has > permission to reboot the system. Since disabling NX hugepages would > allow a guest to crash the system, it is similar to reboot permissions. This patch needs to be squashed with the patch that introduces the capability, otherwise you're introdcuing a bug and then fixing it in the same series.