From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CEE6C433F5 for ; Thu, 31 Mar 2022 09:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233999AbiCaJaW (ORCPT ); Thu, 31 Mar 2022 05:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234003AbiCaJ3Z (ORCPT ); Thu, 31 Mar 2022 05:29:25 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3E91FF422; Thu, 31 Mar 2022 02:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648718846; x=1680254846; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mPcmSRFysKdQJULNHMdsCcsem8XlXgWIUxePX6FqmbU=; b=e66tOk8W/E0fWH/7ffuke1+vLmGKS753EjTf+Sd7H3LTwjwjfFeP1Sdk YPpDOxKDp9J3lm6ztf4Y2sZyok/q7i/5Mh27rz2dDbeibrWRSnxJfQEnQ ybUq5UXSGsve3t1spi7ROQJmFLUpMPUMzAuvl24/6xG++3wUVwdB+YMe1 o8kjdbK31UAN0JFkzz13QVzhs/Bxi6pFzGr4V0qK0PCixxICLJo+ws0CT qlKHibwceo1P53bs2hMoY0KKXPvuv/t6+fbjXs2aBnr2mY68zRo7LwQoE HfRxHo6Wozc1ANd14UWLSntZEK+tRDYBWSNoFmKFBhhrQyxlS+tlgxhvo w==; X-IronPort-AV: E=McAfee;i="6200,9189,10302"; a="239705897" X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="239705897" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 02:27:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="695423344" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 31 Mar 2022 02:27:23 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 31 Mar 2022 12:27:23 +0300 Date: Thu, 31 Mar 2022 12:27:23 +0300 From: Heikki Krogerus To: Won Chung Cc: Tomas Winkler , Mika Westerberg , Benson Leung , Prashant Malani , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] misc/mei: Add NULL check to component match callback functions Message-ID: References: <20220331084918.2592699-1-wonchung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331084918.2592699-1-wonchung@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Won, On Thu, Mar 31, 2022 at 08:49:18AM +0000, Won Chung wrote: > Component match callback functions need to check if expected data is > passed to them. Without this check, it can cause a NULL pointer > dereference when another driver registers a component before i915 > drivers have their component master fully bind. > > Fixes: 1e8d19d9b0dfc ("mei: hdcp: bind only with i915 on the same PCH") > Fixes: c2004ce99ed73 ("mei: pxp: export pavp client to me client bus") > Suggested-by: Heikki Krogerus > Suggested-by: Mika Westerberg > Signed-off-by: Won Chung > Cc: stable@vger.kernel.org > --- > Changes from v2: > - Correctly add "Suggested-by" tag > - Add "Cc: stable@vger.kernel.org" > > Changes from v1: > - Add "Fixes" tag > - Send to stable@vger.kernel.org You are sending these really fast. Before you send the next one, please wait for at least one day. thanks, -- heikki