From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE57EC433EF for ; Thu, 31 Mar 2022 17:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbiCaRXe (ORCPT ); Thu, 31 Mar 2022 13:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbiCaRXe (ORCPT ); Thu, 31 Mar 2022 13:23:34 -0400 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAFD61DEAAF; Thu, 31 Mar 2022 10:21:46 -0700 (PDT) Received: by mail-oi1-f172.google.com with SMTP id q129so221871oif.4; Thu, 31 Mar 2022 10:21:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nsenYJDFXdH82jpjiqunff4Tj/nrgLEIwwTNVx3c7KA=; b=IpNQyL+iL3z4TYEEHvoBFfdo87GdoZ0FD/jpEvHvDhc2QyAsp1+Nrv3DGFkA7J2Uz1 riylqVozQnr2znIZ9/ks8dtd0X0BZpfAxtYN1E2B/phG9lzc66cCm85FmMl+DgldljCg 0/csav/Aa5hyWXIIOI0S2+zHzO1h7c4yqbdVHRLHV5WoRhtWLf2GJxWS77pb11z2yBGB RMzKPEwZzOrPn/qe1RxZ7PWLh0yAS+Fkf8Zb9SCEsCGMKH8MBRsZuXTJbSXlO+hVo/0E ft9qcWON9mkWYApqly6sfWO3aiJFZsnD4ERnIRqy/WAPPSORFY03rYXj0FTztScrSU9F WKlA== X-Gm-Message-State: AOAM533mHYcXzX53THcyWVBrLpHE9nWbh0b5SYFHva1SIlwP9OZfD8a1 /ci5JfUKZBI1MzjVlD4aDg== X-Google-Smtp-Source: ABdhPJwnl2uSafHwFjFXClVThGjT6z4BqxQOEpHGBmTRRQm3pFwVVUFoxpHVcYXm7rCBrefSq1tsJA== X-Received: by 2002:a05:6808:118f:b0:2d4:13f1:8504 with SMTP id j15-20020a056808118f00b002d413f18504mr2962544oil.90.1648747305999; Thu, 31 Mar 2022 10:21:45 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id f8-20020a4ace88000000b00321598cd45dsm12006oos.33.2022.03.31.10.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 10:21:44 -0700 (PDT) Received: (nullmailer pid 1168272 invoked by uid 1000); Thu, 31 Mar 2022 17:21:43 -0000 Date: Thu, 31 Mar 2022 12:21:43 -0500 From: Rob Herring To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Vinod Koul , Martin =?utf-8?Q?Povi=C5=A1er?= , Hector Martin , Sven Peter , Krzysztof Kozlowski , Alyssa Rosenzweig , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC Message-ID: References: <20220330164458.93055-1-povik+lin@cutebit.org> <20220330164458.93055-2-povik+lin@cutebit.org> <265B2992-06E5-4E45-A971-B170A385EFD4@cutebit.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Mar 31, 2022 at 06:13:53PM +0200, Martin Povišer wrote: > > > On 31. 3. 2022, at 16:10, Vinod Koul wrote: > > > > On 31-03-22, 09:06, Martin Povišer wrote: > >> > >>> On 31. 3. 2022, at 8:50, Martin Povišer wrote: > >>>> > >>>> On 31. 3. 2022, at 7:23, Vinod Koul wrote: > >>>> > >>>> On 30-03-22, 18:44, Martin Povišer wrote: > >>>>> Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio > >>>>> samples on Apple SoCs from the "Apple Silicon" family. > >>>>> > >>>>> Signed-off-by: Martin Povišer > >>>>> --- > >>>>> .../devicetree/bindings/dma/apple,admac.yaml | 73 +++++++++++++++++++ > >>>>> 1 file changed, 73 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/dma/apple,admac.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..34f76a9a2983 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml > >>> > >>>>> + apple,internal-irq-destination: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + description: Index influencing internal routing of the IRQs > >>>>> + within the peripheral. > >>>> > >>>> do you have more details for this, is this for peripheral and if so > >>>> suited to be in dam-cells? > >>> > >>> By peripheral I meant the DMA controller itself here. > > > > Dmaengine convention is that peripheral is device which we are doing dma > > to/from, like audio controller/fifo here > > > >>> Effectively the controller has four independent IRQ outputs and the driver > >>> needs to know which one we are using. (It need not be the same output even > >>> for different ADMAC instances on one die.) > > > > That smells like a mux to me.. why not use dma-requests for this? > > I am not sure that’s right. Reading the dmaengine docs, DMA requests seem to have > to do with the DMA-controller-to-peripheral connection, but the proposed property > tells us which of four independent IRQ outputs of the DMA controller we actually > have in the interrupts= property. That is, it has to do with the DMA-controller-to-CPU > connection. Why do they have to be different? IRQF_SHARED doesn't work? Why can't you request each IRQ until it succeeds? What happens when there are 5 DMA controllers? If using more than 1 interrupt will never work or be needed, then I'm inclined to say just describe that 1 interrupt. Yes, that goes against 'describe all the h/w', but there's always exceptions. I suppose you need to know which 'interrupts' index (output) you are using. If so, you can do something like this: interrupts = <-1>, <-1>, <3 0>, <-1>; Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E8F5C433EF for ; Thu, 31 Mar 2022 17:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mx9J6rNgY+OymkTv9ODLpkOclrG/EpJQugRCpiR1ZM8=; b=zMTiArDgqBRVvY tblcPYv5jPaWr/ivxSLc5c3Yb9ZVVadu/1MZ+BismOOktHqvcmkvDI4k/lhT4r2EgXd380K7SfXsv ppta5Jd+jZQ9GcBsbeJ/ssExmdiCdhZyfmTO5ggOHQK7Ys0A5m0/qxBJ4X2y2G7L2VtN1dXsbxJoy rUWO0qKX96FM6eZD+QT0B4blg11g1IheHdAf7/MWhBK7m3tpimrmn1ljLr7gb7wY2k48hMUr/jo0y RKvffbG8EIqoc0hxxDsO3c3wsPPRnkyUbcdBPH58GtsvWrobqw13BmwuaxfdwkJq9zQ73NENZgL2q LXx4ejBgnEArJHuYuFng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZyUZ-0035Sk-Sf; Thu, 31 Mar 2022 17:21:52 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZyUW-0035Re-Bg for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 17:21:49 +0000 Received: by mail-oi1-f172.google.com with SMTP id z8so227638oix.3 for ; Thu, 31 Mar 2022 10:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nsenYJDFXdH82jpjiqunff4Tj/nrgLEIwwTNVx3c7KA=; b=WyEgH9Oz69UNsnU7krpbVA+o/Nra8EfeRC0mZxUSuEhJFTjtdSCtxfTyv6yBRk8i5t jIGRAzyOl3xtMrcMDrCqFjf6Vv9wmjo93cElBwjAZWhg0BEWqr8LbHj3FqdrLQdy0cLQ E/NTNcXxD566GmkDpxRlyDFGd4vMSuAGpdLMbsvP+c7mvLMmv3rouLLHPtwtAkXoj2lu +1ruEbd5NXSLj2upKNxgb1BfCZdxjxsy22/wXPCn3kzx0Eiglua40GyRt0aVgZIFtazr lA7PMk/0FhFjvfJzfTqziMKNq7MzCeF8ohWt6IjrEk80hqVwmwNSUdzq6+ReIwHdD5w3 k3ZA== X-Gm-Message-State: AOAM5324llDfyo3HvQZc8peZxHE0D5VH16qFB44HSliUrzLMCVtUKTAM gXpMXK0a/Y4kdfFqaAaPLg2ZmFdZEw== X-Google-Smtp-Source: ABdhPJwnl2uSafHwFjFXClVThGjT6z4BqxQOEpHGBmTRRQm3pFwVVUFoxpHVcYXm7rCBrefSq1tsJA== X-Received: by 2002:a05:6808:118f:b0:2d4:13f1:8504 with SMTP id j15-20020a056808118f00b002d413f18504mr2962544oil.90.1648747305999; Thu, 31 Mar 2022 10:21:45 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id f8-20020a4ace88000000b00321598cd45dsm12006oos.33.2022.03.31.10.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 10:21:44 -0700 (PDT) Received: (nullmailer pid 1168272 invoked by uid 1000); Thu, 31 Mar 2022 17:21:43 -0000 Date: Thu, 31 Mar 2022 12:21:43 -0500 From: Rob Herring To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Vinod Koul , Martin =?utf-8?Q?Povi=C5=A1er?= , Hector Martin , Sven Peter , Krzysztof Kozlowski , Alyssa Rosenzweig , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC Message-ID: References: <20220330164458.93055-1-povik+lin@cutebit.org> <20220330164458.93055-2-povik+lin@cutebit.org> <265B2992-06E5-4E45-A971-B170A385EFD4@cutebit.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_102148_441198_20B80BB8 X-CRM114-Status: GOOD ( 24.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMzEsIDIwMjIgYXQgMDY6MTM6NTNQTSArMDIwMCwgTWFydGluIFBvdmnFoWVy IHdyb3RlOgo+IAo+ID4gT24gMzEuIDMuIDIwMjIsIGF0IDE2OjEwLCBWaW5vZCBLb3VsIDx2a291 bEBrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gT24gMzEtMDMtMjIsIDA5OjA2LCBNYXJ0aW4g UG92acWhZXIgd3JvdGU6Cj4gPj4gCj4gPj4+IE9uIDMxLiAzLiAyMDIyLCBhdCA4OjUwLCBNYXJ0 aW4gUG92acWhZXIgPHBvdmlrQGN1dGViaXQub3JnPiB3cm90ZToKPiA+Pj4+IAo+ID4+Pj4gT24g MzEuIDMuIDIwMjIsIGF0IDc6MjMsIFZpbm9kIEtvdWwgPHZrb3VsQGtlcm5lbC5vcmc+IHdyb3Rl Ogo+ID4+Pj4gCj4gPj4+PiBPbiAzMC0wMy0yMiwgMTg6NDQsIE1hcnRpbiBQb3ZpxaFlciB3cm90 ZToKPiA+Pj4+PiBBcHBsZSdzIEF1ZGlvIERNQSBDb250cm9sbGVyIChBRE1BQykgaXMgdXNlZCB0 byBmZXRjaCBhbmQgc3RvcmUgYXVkaW8KPiA+Pj4+PiBzYW1wbGVzIG9uIEFwcGxlIFNvQ3MgZnJv bSB0aGUgIkFwcGxlIFNpbGljb24iIGZhbWlseS4KPiA+Pj4+PiAKPiA+Pj4+PiBTaWduZWQtb2Zm LWJ5OiBNYXJ0aW4gUG92acWhZXIgPHBvdmlrK2xpbkBjdXRlYml0Lm9yZz4KPiA+Pj4+PiAtLS0K PiA+Pj4+PiAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvYXBwbGUsYWRtYWMueWFtbCAgfCA3 MyArKysrKysrKysrKysrKysrKysrCj4gPj4+Pj4gMSBmaWxlIGNoYW5nZWQsIDczIGluc2VydGlv bnMoKykKPiA+Pj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2RtYS9hcHBsZSxhZG1hYy55YW1sCj4gPj4+Pj4gCj4gPj4+Pj4gZGlmZiAtLWdp dCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvYXBwbGUsYWRtYWMueWFt bCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvYXBwbGUsYWRtYWMueWFt bAo+ID4+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPj4+Pj4gaW5kZXggMDAwMDAwMDAwMDAw Li4zNGY3NmE5YTI5ODMKPiA+Pj4+PiAtLS0gL2Rldi9udWxsCj4gPj4+Pj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9hcHBsZSxhZG1hYy55YW1sCj4gPj4+IAo+ ID4+Pj4+ICsgIGFwcGxlLGludGVybmFsLWlycS1kZXN0aW5hdGlvbjoKPiA+Pj4+PiArICAgICRy ZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3VpbnQzMgo+ID4+Pj4+ICsgICAg ZGVzY3JpcHRpb246IEluZGV4IGluZmx1ZW5jaW5nIGludGVybmFsIHJvdXRpbmcgb2YgdGhlIElS UXMKPiA+Pj4+PiArICAgICAgd2l0aGluIHRoZSBwZXJpcGhlcmFsLgo+ID4+Pj4gCj4gPj4+PiBk byB5b3UgaGF2ZSBtb3JlIGRldGFpbHMgZm9yIHRoaXMsIGlzIHRoaXMgZm9yIHBlcmlwaGVyYWwg YW5kIGlmIHNvCj4gPj4+PiBzdWl0ZWQgdG8gYmUgaW4gZGFtLWNlbGxzPwo+ID4+PiAKPiA+Pj4g QnkgcGVyaXBoZXJhbCBJIG1lYW50IHRoZSBETUEgY29udHJvbGxlciBpdHNlbGYgaGVyZS4gCj4g PiAKPiA+IERtYWVuZ2luZSBjb252ZW50aW9uIGlzIHRoYXQgcGVyaXBoZXJhbCBpcyBkZXZpY2Ug d2hpY2ggd2UgYXJlIGRvaW5nIGRtYQo+ID4gdG8vZnJvbSwgbGlrZSBhdWRpbyBjb250cm9sbGVy L2ZpZm8gaGVyZQo+ID4gCj4gPj4+IEVmZmVjdGl2ZWx5IHRoZSBjb250cm9sbGVyIGhhcyBmb3Vy IGluZGVwZW5kZW50IElSUSBvdXRwdXRzIGFuZCB0aGUgZHJpdmVyCj4gPj4+IG5lZWRzIHRvIGtu b3cgd2hpY2ggb25lIHdlIGFyZSB1c2luZy4gKEl0IG5lZWQgbm90IGJlIHRoZSBzYW1lIG91dHB1 dCBldmVuCj4gPj4+IGZvciBkaWZmZXJlbnQgQURNQUMgaW5zdGFuY2VzIG9uIG9uZSBkaWUuKQo+ ID4gCj4gPiBUaGF0IHNtZWxscyBsaWtlIGEgbXV4IHRvIG1lLi4gd2h5IG5vdCB1c2UgZG1hLXJl cXVlc3RzIGZvciB0aGlzPwo+IAo+IEkgYW0gbm90IHN1cmUgdGhhdOKAmXMgcmlnaHQuIFJlYWRp bmcgdGhlIGRtYWVuZ2luZSBkb2NzLCBETUEgcmVxdWVzdHMgc2VlbSB0byBoYXZlCj4gdG8gZG8g d2l0aCB0aGUgRE1BLWNvbnRyb2xsZXItdG8tcGVyaXBoZXJhbCBjb25uZWN0aW9uLCBidXQgdGhl IHByb3Bvc2VkIHByb3BlcnR5Cj4gdGVsbHMgdXMgd2hpY2ggb2YgZm91ciBpbmRlcGVuZGVudCBJ UlEgb3V0cHV0cyBvZiB0aGUgRE1BIGNvbnRyb2xsZXIgd2UgYWN0dWFsbHkKPiBoYXZlIGluIHRo ZSBpbnRlcnJ1cHRzPSBwcm9wZXJ0eS4gVGhhdCBpcywgaXQgaGFzIHRvIGRvIHdpdGggdGhlIERN QS1jb250cm9sbGVyLXRvLUNQVQo+IGNvbm5lY3Rpb24uCgpXaHkgZG8gdGhleSBoYXZlIHRvIGJl IGRpZmZlcmVudD8gSVJRRl9TSEFSRUQgZG9lc24ndCB3b3JrPwoKV2h5IGNhbid0IHlvdSByZXF1 ZXN0IGVhY2ggSVJRIHVudGlsIGl0IHN1Y2NlZWRzPwoKV2hhdCBoYXBwZW5zIHdoZW4gdGhlcmUg YXJlIDUgRE1BIGNvbnRyb2xsZXJzPwoKSWYgdXNpbmcgbW9yZSB0aGFuIDEgaW50ZXJydXB0IHdp bGwgbmV2ZXIgd29yayBvciBiZSBuZWVkZWQsIHRoZW4gSSdtIAppbmNsaW5lZCB0byBzYXkganVz dCBkZXNjcmliZSB0aGF0IDEgaW50ZXJydXB0LiBZZXMsIHRoYXQgZ29lcyBhZ2FpbnN0IAonZGVz Y3JpYmUgYWxsIHRoZSBoL3cnLCBidXQgdGhlcmUncyBhbHdheXMgZXhjZXB0aW9ucy4gSSBzdXBw b3NlIHlvdSAKbmVlZCB0byBrbm93IHdoaWNoICdpbnRlcnJ1cHRzJyBpbmRleCAob3V0cHV0KSB5 b3UgYXJlIHVzaW5nLiBJZiBzbywgeW91IApjYW4gZG8gc29tZXRoaW5nIGxpa2UgdGhpczoKCmlu dGVycnVwdHMgPSA8LTE+LCA8LTE+LCA8MyAwPiwgPC0xPjsKClJvYgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=