From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2106FC433FE for ; Fri, 1 Apr 2022 10:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344035AbiDAKew (ORCPT ); Fri, 1 Apr 2022 06:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344001AbiDAKeq (ORCPT ); Fri, 1 Apr 2022 06:34:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B9EC426E57B for ; Fri, 1 Apr 2022 03:32:56 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46D3B13D5 for ; Fri, 1 Apr 2022 03:32:56 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 08CA43F66F for ; Fri, 1 Apr 2022 03:32:55 -0700 (PDT) Date: Fri, 1 Apr 2022 11:32:43 +0100 From: Liviu Dudau To: Sudeep Holla Cc: Kees Cook , Lorenzo Pieralisi , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: vexpress/spc: Avoid negative array index when !SMP Message-ID: References: <20220331190443.851661-1-keescook@chromium.org> <20220401101147.xtweqtftmtwa3txk@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220401101147.xtweqtftmtwa3txk@bogus> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2022 at 11:11:47AM +0100, Sudeep Holla wrote: > On Fri, Apr 01, 2022 at 10:28:29AM +0100, Liviu Dudau wrote: > > On Thu, Mar 31, 2022 at 12:04:43PM -0700, Kees Cook wrote: > > > When building multi_v7_defconfig+CONFIG_SMP=n, -Warray-bounds exposes > > > a couple negative array index accesses: > > > > > > arch/arm/mach-vexpress/spc.c: In function 've_spc_clk_init': > > > arch/arm/mach-vexpress/spc.c:583:21: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds] > > > 583 | if (init_opp_table[cluster]) > > > | ~~~~~~~~~~~~~~^~~~~~~~~ > > > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table' > > > 556 | bool init_opp_table[MAX_CLUSTERS] = { false }; > > > | ^~~~~~~~~~~~~~ > > > arch/arm/mach-vexpress/spc.c:592:18: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds] > > > 592 | init_opp_table[cluster] = true; > > > | ~~~~~~~~~~~~~~^~~~~~~~~ > > > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table' > > > 556 | bool init_opp_table[MAX_CLUSTERS] = { false }; > > > | ^~~~~~~~~~~~~~ > > > > > > Skip this logic when built !SMP. > > > > > > Cc: Liviu Dudau > > > Cc: Sudeep Holla > > > Cc: Lorenzo Pieralisi > > > Cc: Russell King > > > Cc: linux-arm-kernel@lists.infradead.org > > > Signed-off-by: Kees Cook > > > > Acked-by: Liviu Dudau > > > > Sudeep, can you please take this through your tree for sending it to arm-soc? > > > > Sure, I will do that as soon as -rc1 is out. Cheers, much appreciated! Best regards, Liviu > > -- > Regards, > Sudeep -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C4BFC433F5 for ; Fri, 1 Apr 2022 10:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TtTduqvVr8gPRQAwsF6h+/UF1jPAFCRPlz5x6IoFfc4=; b=gdcnKW0XWvyVCy P4iRPnO/rmuZyQKMTIH1KtkCYfgafq07iIAzhwYFNQR9x8ghI1GHfoUjKqOwMa7H/rWXCJluITu/E fsxfVa2+95lpHfhzD2ROIjnw0lfmYnG6Hl+Whl1pzmhOcw3OyXuvt7pKwyiIqFcKsvM3P3XzTOaW/ 83Mqcgx958kTrmuQUuO5OWmdu7i2uNfC998unSNuVUB3GhgyX9thDCqzP0G14ZnR9CE2DLJwUxrV0 jEQFcKoKlnou6kUKo6zvANio+nXj2oyc483rq8HtzjKZUNFewzC4SwtSIyxQgy+qpCd+PvLexlME8 vpakYmCOzwyC/5+S3FJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naEaT-005C2x-SF; Fri, 01 Apr 2022 10:33:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naEaP-005C0u-2l for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 10:32:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A8DD139F for ; Fri, 1 Apr 2022 03:32:55 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C06423F66F for ; Fri, 1 Apr 2022 03:32:54 -0700 (PDT) Date: Fri, 1 Apr 2022 11:32:43 +0100 From: Liviu Dudau To: Sudeep Holla Cc: Kees Cook , Lorenzo Pieralisi , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: vexpress/spc: Avoid negative array index when !SMP Message-ID: References: <20220331190443.851661-1-keescook@chromium.org> <20220401101147.xtweqtftmtwa3txk@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220401101147.xtweqtftmtwa3txk@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_033257_230564_48E1394E X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMDEsIDIwMjIgYXQgMTE6MTE6NDdBTSArMDEwMCwgU3VkZWVwIEhvbGxhIHdy b3RlOgo+IE9uIEZyaSwgQXByIDAxLCAyMDIyIGF0IDEwOjI4OjI5QU0gKzAxMDAsIExpdml1IER1 ZGF1IHdyb3RlOgo+ID4gT24gVGh1LCBNYXIgMzEsIDIwMjIgYXQgMTI6MDQ6NDNQTSAtMDcwMCwg S2VlcyBDb29rIHdyb3RlOgo+ID4gPiBXaGVuIGJ1aWxkaW5nIG11bHRpX3Y3X2RlZmNvbmZpZytD T05GSUdfU01QPW4sIC1XYXJyYXktYm91bmRzIGV4cG9zZXMKPiA+ID4gYSBjb3VwbGUgbmVnYXRp dmUgYXJyYXkgaW5kZXggYWNjZXNzZXM6Cj4gPiA+IAo+ID4gPiBhcmNoL2FybS9tYWNoLXZleHBy ZXNzL3NwYy5jOiBJbiBmdW5jdGlvbiAndmVfc3BjX2Nsa19pbml0JzoKPiA+ID4gYXJjaC9hcm0v bWFjaC12ZXhwcmVzcy9zcGMuYzo1ODM6MjE6IHdhcm5pbmc6IGFycmF5IHN1YnNjcmlwdCAtMSBp cyBiZWxvdyBhcnJheSBib3VuZHMgb2YgJ2Jvb2xbMl0nIHtha2EgJ19Cb29sWzJdJ30gWy1XYXJy YXktYm91bmRzXQo+ID4gPiAgIDU4MyB8ICAgaWYgKGluaXRfb3BwX3RhYmxlW2NsdXN0ZXJdKQo+ ID4gPiAgICAgICB8ICAgICAgIH5+fn5+fn5+fn5+fn5+Xn5+fn5+fn5+Cj4gPiA+IGFyY2gvYXJt L21hY2gtdmV4cHJlc3Mvc3BjLmM6NTU2Ojc6IG5vdGU6IHdoaWxlIHJlZmVyZW5jaW5nICdpbml0 X29wcF90YWJsZScKPiA+ID4gICA1NTYgfCAgYm9vbCBpbml0X29wcF90YWJsZVtNQVhfQ0xVU1RF UlNdID0geyBmYWxzZSB9Owo+ID4gPiAgICAgICB8ICAgICAgIF5+fn5+fn5+fn5+fn5+Cj4gPiA+ IGFyY2gvYXJtL21hY2gtdmV4cHJlc3Mvc3BjLmM6NTkyOjE4OiB3YXJuaW5nOiBhcnJheSBzdWJz Y3JpcHQgLTEgaXMgYmVsb3cgYXJyYXkgYm91bmRzIG9mICdib29sWzJdJyB7YWthICdfQm9vbFsy XSd9IFstV2FycmF5LWJvdW5kc10KPiA+ID4gICA1OTIgfCAgICBpbml0X29wcF90YWJsZVtjbHVz dGVyXSA9IHRydWU7Cj4gPiA+ICAgICAgIHwgICAgfn5+fn5+fn5+fn5+fn5efn5+fn5+fn4KPiA+ ID4gYXJjaC9hcm0vbWFjaC12ZXhwcmVzcy9zcGMuYzo1NTY6Nzogbm90ZTogd2hpbGUgcmVmZXJl bmNpbmcgJ2luaXRfb3BwX3RhYmxlJwo+ID4gPiAgIDU1NiB8ICBib29sIGluaXRfb3BwX3RhYmxl W01BWF9DTFVTVEVSU10gPSB7IGZhbHNlIH07Cj4gPiA+ICAgICAgIHwgICAgICAgXn5+fn5+fn5+ fn5+fn4KPiA+ID4gCj4gPiA+IFNraXAgdGhpcyBsb2dpYyB3aGVuIGJ1aWx0ICFTTVAuCj4gPiA+ IAo+ID4gPiBDYzogTGl2aXUgRHVkYXUgPGxpdml1LmR1ZGF1QGFybS5jb20+Cj4gPiA+IENjOiBT dWRlZXAgSG9sbGEgPHN1ZGVlcC5ob2xsYUBhcm0uY29tPgo+ID4gPiBDYzogTG9yZW56byBQaWVy YWxpc2kgPGxvcmVuem8ucGllcmFsaXNpQGFybS5jb20+Cj4gPiA+IENjOiBSdXNzZWxsIEtpbmcg PGxpbnV4QGFybWxpbnV4Lm9yZy51az4KPiA+ID4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBLZWVzIENvb2sgPGtlZXNjb29rQGNo cm9taXVtLm9yZz4KPiA+IAo+ID4gQWNrZWQtYnk6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRhdUBh cm0uY29tPgo+ID4gCj4gPiBTdWRlZXAsIGNhbiB5b3UgcGxlYXNlIHRha2UgdGhpcyB0aHJvdWdo IHlvdXIgdHJlZSBmb3Igc2VuZGluZyBpdCB0byBhcm0tc29jPwo+ID4KPiAKPiBTdXJlLCBJIHdp bGwgZG8gdGhhdCBhcyBzb29uIGFzIC1yYzEgaXMgb3V0LgoKQ2hlZXJzLCBtdWNoIGFwcHJlY2lh dGVkIQoKQmVzdCByZWdhcmRzLApMaXZpdQoKPiAKPiAtLSAKPiBSZWdhcmRzLAo+IFN1ZGVlcAoK LS0gCj09PT09PT09PT09PT09PT09PT09CnwgSSB3b3VsZCBsaWtlIHRvIHwKfCBmaXggdGhlIHdv cmxkLCAgfAp8IGJ1dCB0aGV5J3JlIG5vdCB8CnwgZ2l2aW5nIG1lIHRoZSAgIHwKIFwgc291cmNl IGNvZGUhICAvCiAgLS0tLS0tLS0tLS0tLS0tCiAgICDCr1xfKOODhClfL8KvCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==