From: Borislav Petkov <bp@alien8.de>
To: Cathy Zhang <cathy.zhang@intel.com>
Cc: linux-sgx@vger.kernel.org, x86@kernel.org, jarkko@kernel.org,
reinette.chatre@intel.com, dave.hansen@intel.com,
ashok.raj@intel.com
Subject: Re: [RFC PATCH v3 09/10] x86/cpu: Call ENCLS[EUPDATESVN] procedure in microcode update
Date: Fri, 1 Apr 2022 16:29:42 +0200 [thread overview]
Message-ID: <YkcMVh2ostXlhr5t@zn.tnic> (raw)
In-Reply-To: <20220401142409.26215-10-cathy.zhang@intel.com>
On Fri, Apr 01, 2022 at 10:24:08PM +0800, Cathy Zhang wrote:
> @@ -2086,6 +2087,14 @@ void microcode_check(void)
>
> perf_check_microcode();
>
> + /*
> + * SGX related microcode update requires EUPDATESVN to update CPUSVN, which
> + * will destroy all enclaves to ensure EPC is not in use. If SGX is configured
> + * and EUPDATESVN is supported, call the EUPDATESVN procecure.
> + */
> + if (IS_ENABLED(CONFIG_X86_SGX) && (cpuid_eax(SGX_CPUID) & SGX_CPUID_EUPDATESVN))
Stick all that above...
> + update_cpusvn_intel();
...inside this function so that you have only the call here. Inside the
function you can do all the ifdeffery, checking and commenting and so
on. Just like perf_check_microcode() does.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-04-01 14:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:23 [RFC PATCH v3 00/10] Support microcode updates affecting SGX Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 01/10] x86/sgx: Introduce mechanism to prevent new initializations of EPC pages Cathy Zhang
2022-04-03 8:13 ` Jarkko Sakkinen
2022-04-06 3:31 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 02/10] x86/sgx: Provide VA page non-NULL owner Cathy Zhang
2022-04-03 8:29 ` Jarkko Sakkinen
2022-04-01 14:24 ` [RFC PATCH v3 03/10] x86/sgx: Save enclave pointer for VA page Cathy Zhang
2022-04-03 10:08 ` Jarkko Sakkinen
2022-04-06 3:31 ` Zhang, Cathy
2022-04-06 6:33 ` Jarkko Sakkinen
2022-04-01 14:24 ` [RFC PATCH v3 04/10] x86/sgx: Keep record for SGX VA and Guest page type Cathy Zhang
2022-04-03 10:11 ` Jarkko Sakkinen
2022-04-06 3:38 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section Cathy Zhang
2022-04-03 10:14 ` Jarkko Sakkinen
2022-04-06 4:00 ` Zhang, Cathy
2022-04-06 6:34 ` Jarkko Sakkinen
2022-04-01 14:24 ` [RFC PATCH v3 06/10] x86/sgx: Forced EPC page zapping for EUPDATESVN Cathy Zhang
2022-04-03 10:20 ` Jarkko Sakkinen
2022-04-06 4:21 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 07/10] x86/sgx: Define error codes for ENCLS[EUPDATESVN] Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 08/10] x86/sgx: Implement ENCLS[EUPDATESVN] Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 09/10] x86/cpu: Call ENCLS[EUPDATESVN] procedure in microcode update Cathy Zhang
2022-04-01 14:29 ` Borislav Petkov [this message]
2022-04-02 2:54 ` Zhang, Cathy
2022-04-01 15:42 ` Dave Hansen
2022-04-02 3:02 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 10/10] x86/sgx: Call ENCLS[EUPDATESVN] during SGX initialization Cathy Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkcMVh2ostXlhr5t@zn.tnic \
--to=bp@alien8.de \
--cc=ashok.raj@intel.com \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@intel.com \
--cc=jarkko@kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.