From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDA3C46467 for ; Mon, 4 Apr 2022 22:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380942AbiDDWHh (ORCPT ); Mon, 4 Apr 2022 18:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379042AbiDDQXp (ORCPT ); Mon, 4 Apr 2022 12:23:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 819A2BC0B for ; Mon, 4 Apr 2022 09:21:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 46B8AB8182F for ; Mon, 4 Apr 2022 16:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E8ECC2BBE4; Mon, 4 Apr 2022 16:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649089307; bh=12OqAgUFqo0o0nuRsjoOTKREg/x8VwVcYoOLde88fz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LwWB/0q9+NvxDslstiuPLQ3SRqHNZAv1ybSR1/YtRUtS4E6SdC5geH9/JV3SkXo29 RE1fmiDc8vAP9AyVDSP+VWhhAzyRhkGHOnIlWCoy0AGFZCUrhjMkTWOjm6gdbPvrUY tw8MdE3Jfprd/JMoRgO1sq6EE9vSewPWXlbQsm8Y= Date: Mon, 4 Apr 2022 18:21:43 +0200 From: Greg Kroah-Hartman To: Linus Torvalds Cc: Guenter Roeck , Larry Finger , Oded Gabbay , Jiri Slaby , Linux Kernel Mailing List Subject: Re: Linux 5.18-rc1 Message-ID: References: <20220404022239.GA1186352@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 08:32:16AM -0700, Linus Torvalds wrote: > On Sun, Apr 3, 2022 at 9:23 PM Guenter Roeck wrote: > > > > Oops. Sorry, I thought it was big endian. No idea why. I'll update > > subject and description and resend. > > I see your updated patch, but for some reason 'b4' is unhappy about it, with > > $ b4 am 20220404134338.3276991-1-linux@roeck-us.net > > causing > > ✗ [PATCH v3] staging: r8188eu: Fix PPPoE tag insertion on little > endian systems > --- > ✗ BADSIG: DKIM/roeck-us.net > > your DKIM looks fine on the messages I see, but now that I look at it > on the mailing list, I notice that your DKIM really is very wrong, and > has a lot of headers that a DKIM signature should *not* have. > > Your DKIM signature includes header names that are very much for list > management, so by definition DKIM will fail for any email you send > through a mailing list. Headers like > "Resent-From:Resent-Sender:Resent-To:Resent-Cc > :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe" etc. > > The DKIM setup should protect the meaningful headers that matter to > the sender, not things that the mail system will validly add when it > passes through. > > So the DKIM header list should be things like > ":To:From:Cc:Message-Id:Date:Subject:" > > Not things like "Sender" or mailing list things. > > Anyway, I was going to just commit it directly, but with the DKIM > verification failing, I was a bit less eager to. And then I noticed > that you used "be16_to_cpu()" - which is technically correct - which > doesn't match the other code in that file. I've taken this in my tree now and will get it to you for -rc2 if you don't want to take it. And yes, I see the dkim issue as well, I haven't started complaining about to people yet as lots of people have problem email setups. Should we start pushing back? thanks, greg k-h