From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3446AC433F5 for ; Tue, 5 Apr 2022 13:05:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 668B410E559; Tue, 5 Apr 2022 13:05:51 +0000 (UTC) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29D3710E559 for ; Tue, 5 Apr 2022 13:05:50 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id l9-20020a05600c4f0900b0038ccd1b8642so1501178wmq.0 for ; Tue, 05 Apr 2022 06:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5OoGrDH7nK9oFjsVTIEbOFtr4JmfdoVI2IyJ2wjIRyw=; b=bwrq0C1ajirhKSzPeBMF9M4xumTAECxTEkjAVIr9N/f/e13Ws70HiJje2vSD+LozFa WUKJttLtri9u8/VPFQ2yn2Kkj0BQy1trEq672pajS5zZ/h1OQ6nKRlGo0D03FrtkyN4H Y0bN8C0MwXLOOCzJf+mdEvBEreMuYHq2M+zd0TjqMEAcIwaUmgwUV6GfFt9qt+tzpHxQ 9gUZLRS0Fk5mCX7CEFWx7sVga6DYaeYUQxz4S4fcCrhGOy+RdDXIbu6N9B5MQQguGj1m zKgbRV3tdh3m78Oo3Qi0QwtP8oq301EPtUHMoYxmcZ9W7sNBWZSEljuxnga2xR+tUrBU 2DAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5OoGrDH7nK9oFjsVTIEbOFtr4JmfdoVI2IyJ2wjIRyw=; b=ntpi1214BEj0Bkg7oj5TNgho/blsUlbTDMHCKMxtMincjIpgo+xD6I65C9WiYTnZ4B VZ98GpZQyZVAhBL+tsT3FJOrOc2ixT2RDacOts7wUdfci7X5DonfrWenBRfjdj1l9ST1 ius6hS3HNPewKLEMlCkIT6nXIozdvKPzEidOX/1LRk7tq6BibjuFdpAkOG8OVe0ebBMT b7jlHKitCqcNibqzHUP3eDhtcnVc0yFLsz/H3sDthyz9V3Cym4ViOsV8iyKv96Slu1Dz h9kpDrV+WyzBZC98dOX+nL4Nxfujw8q7QQ5qcgXMczS4IplAJk1i1O/nPKIbEgW+LZIP AVbw== X-Gm-Message-State: AOAM532ncYY8s5mp74Sf3O+mo9szx7g5Ql6pQqxYp8sCAiZuqN2/o5YI 4J3Ufw1lLiA0RsJ8YI3svMo= X-Google-Smtp-Source: ABdhPJwlDd/JO2QncqV+Qg7YsvFj5rwcuVsPA18gfL0PHrdH/061R20sU1lTWEubutb8Zv6bVjYCWg== X-Received: by 2002:a05:600c:4e92:b0:38c:73e8:7dcd with SMTP id f18-20020a05600c4e9200b0038c73e87dcdmr3141891wmq.196.1649163948642; Tue, 05 Apr 2022 06:05:48 -0700 (PDT) Received: from debian (host-78-145-97-89.as13285.net. [78.145.97.89]) by smtp.gmail.com with ESMTPSA id b8-20020a05600c4e0800b0038c6c37efc3sm2099463wmq.12.2022.04.05.06.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 06:05:48 -0700 (PDT) Date: Tue, 5 Apr 2022 14:05:46 +0100 From: Sudip Mukherjee To: Thomas Zimmermann Subject: Re: fbdev: Fix unregistering of framebuffers without device Message-ID: References: <20220404194402.29974-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404194402.29974-1-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Xiyu Yang , Guenter Roeck , Tetsuo Handa , Daniel Vetter , deller@gmx.de, Zheyu Ma , javierm@redhat.com, Matthew Wilcox , hdegoede@redhat.com, stable@vger.kernel.org, Zhen Lei , Alex Deucher , sam@ravnborg.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le is shown below. > > > Tested with 5.17 on qemu ppc64le emulation. > > Signed-off-by: Thomas Zimmermann > Fixes: 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal") > Reported-by: Sudip Mukherjee > Cc: Zack Rusin > Cc: Javier Martinez Canillas > Cc: Hans de Goede > Cc: stable@vger.kernel.org # v5.11+ > Cc: Helge Deller > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Zheyu Ma > Cc: Xiyu Yang > Cc: Zhen Lei > Cc: Matthew Wilcox > Cc: Alex Deucher > Cc: Tetsuo Handa > Cc: Guenter Roeck > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Link: https://lore.kernel.org/all/YkHXO6LGHAN0p1pq@debian/ # [1] > Reviewed-by: Daniel Vetter > --- Tested-by: Sudip Mukherjee -- Regards Sudip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06467C433F5 for ; Tue, 5 Apr 2022 14:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239866AbiDEOfr (ORCPT ); Tue, 5 Apr 2022 10:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384976AbiDEOSh (ORCPT ); Tue, 5 Apr 2022 10:18:37 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119DB90CF3; Tue, 5 Apr 2022 06:05:50 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 123-20020a1c1981000000b0038b3616a71aso1604718wmz.4; Tue, 05 Apr 2022 06:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5OoGrDH7nK9oFjsVTIEbOFtr4JmfdoVI2IyJ2wjIRyw=; b=bwrq0C1ajirhKSzPeBMF9M4xumTAECxTEkjAVIr9N/f/e13Ws70HiJje2vSD+LozFa WUKJttLtri9u8/VPFQ2yn2Kkj0BQy1trEq672pajS5zZ/h1OQ6nKRlGo0D03FrtkyN4H Y0bN8C0MwXLOOCzJf+mdEvBEreMuYHq2M+zd0TjqMEAcIwaUmgwUV6GfFt9qt+tzpHxQ 9gUZLRS0Fk5mCX7CEFWx7sVga6DYaeYUQxz4S4fcCrhGOy+RdDXIbu6N9B5MQQguGj1m zKgbRV3tdh3m78Oo3Qi0QwtP8oq301EPtUHMoYxmcZ9W7sNBWZSEljuxnga2xR+tUrBU 2DAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5OoGrDH7nK9oFjsVTIEbOFtr4JmfdoVI2IyJ2wjIRyw=; b=zf+BPAt4X7IdBIOf+l3NHv+JKYGsFy3H6CEd3lVL2yl0c4JzIoAf3EE+aUkThidlEs BFHkTZzGKNZY2H3J1Bbu22ZrNQBkmtFsOvcre35FcHEnkH3mbBLVWY/fx33gz4xfuJrs zuHOKGZSxPlcUKIpocP5jO3IWO3U+QfjrryTOWHDCTwKvjpbUSAxCzSNvmlFtaXSpWts TCZ7uDIGvzws5NFvV/reV0DV2zDzEEhHwiDG8wdD8kW2puM4Jm7/lSXmkLlJ+QC16qwr MGJGZZ8aSjyXmt5v/eR4dXPIqV+zX/v3+yQNGvaA8eKBM3ex8mJ86jHt/Zc8MuFKUhhj pJ/A== X-Gm-Message-State: AOAM533XS/NqRYmr1whMYbaAl7V7+R8Q+Nwmhz3E6eamnWHNDFJ40UPc A9aWrseiFDM8sHrBHmMq83Y= X-Google-Smtp-Source: ABdhPJwlDd/JO2QncqV+Qg7YsvFj5rwcuVsPA18gfL0PHrdH/061R20sU1lTWEubutb8Zv6bVjYCWg== X-Received: by 2002:a05:600c:4e92:b0:38c:73e8:7dcd with SMTP id f18-20020a05600c4e9200b0038c73e87dcdmr3141891wmq.196.1649163948642; Tue, 05 Apr 2022 06:05:48 -0700 (PDT) Received: from debian (host-78-145-97-89.as13285.net. [78.145.97.89]) by smtp.gmail.com with ESMTPSA id b8-20020a05600c4e0800b0038c6c37efc3sm2099463wmq.12.2022.04.05.06.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 06:05:48 -0700 (PDT) Date: Tue, 5 Apr 2022 14:05:46 +0100 From: Sudip Mukherjee To: Thomas Zimmermann Cc: daniel@ffwll.ch, deller@gmx.de, sam@ravnborg.org, javierm@redhat.com, zackr@vmware.com, hdegoede@redhat.com, linux-fbdev@vger.kernel.org, Matthew Wilcox , Xiyu Yang , Tetsuo Handa , Daniel Vetter , Zheyu Ma , stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Zhen Lei , Alex Deucher , Guenter Roeck Subject: Re: fbdev: Fix unregistering of framebuffers without device Message-ID: References: <20220404194402.29974-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404194402.29974-1-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le is shown below. > > > Tested with 5.17 on qemu ppc64le emulation. > > Signed-off-by: Thomas Zimmermann > Fixes: 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal") > Reported-by: Sudip Mukherjee > Cc: Zack Rusin > Cc: Javier Martinez Canillas > Cc: Hans de Goede > Cc: stable@vger.kernel.org # v5.11+ > Cc: Helge Deller > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Zheyu Ma > Cc: Xiyu Yang > Cc: Zhen Lei > Cc: Matthew Wilcox > Cc: Alex Deucher > Cc: Tetsuo Handa > Cc: Guenter Roeck > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Link: https://lore.kernel.org/all/YkHXO6LGHAN0p1pq@debian/ # [1] > Reviewed-by: Daniel Vetter > --- Tested-by: Sudip Mukherjee -- Regards Sudip