From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7621CC433FE for ; Tue, 5 Apr 2022 14:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237060AbiDEOI6 (ORCPT ); Tue, 5 Apr 2022 10:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381431AbiDEMya (ORCPT ); Tue, 5 Apr 2022 08:54:30 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6F15F2A25E for ; Tue, 5 Apr 2022 04:58:27 -0700 (PDT) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 27F3F60196; Tue, 5 Apr 2022 13:54:48 +0200 (CEST) Date: Tue, 5 Apr 2022 13:58:24 +0200 From: Pablo Neira Ayuso To: Lukas Straub Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] meta time: use uint64_t instead of time_t Message-ID: References: <20220405101016.855221490@web.de> <20220405101026.867817071@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220405101026.867817071@web.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Apr 05, 2022 at 10:41:14AM +0000, Lukas Straub wrote: > time_t may be 32 bit on some platforms and thus can't fit a timestamp > with nanoseconds resolution. This causes overflows and ultimatively > breaks meta time expressions on such platforms. > > Fix this by using uint64_t instead. Applied, thanks