From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8DE9C433F5 for ; Tue, 5 Apr 2022 20:54:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 279BE10EDF6; Tue, 5 Apr 2022 20:54:57 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C1B410ED42 for ; Tue, 5 Apr 2022 20:54:55 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id j12so306313wrb.5 for ; Tue, 05 Apr 2022 13:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=dMIxaOA+PwGmGbUBgSF+BtNgTUc4RKGxiEJxcOGGW41WPS35KSWlB4hv7i4DbpxOGC ZH1S+U4+vSggXY1XAGmMMGqiGDAAFbM1TiIfR+O950jkhP22hrN5zpqEUFn8ZJUif7W1 UT9mutnETTYpsxdjQi923ezsNRj0CTq+AgkAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=ey33IinxNLZEI63wzGpSw6kHYmVRn/V6GYgiPhGImEoHQAVVjA1z+ios9Mu5/+ECRr k24eetZU3feX0fUghGYiSNNA9MC1OLgEfeZ2dhc3Y97EueMJe24ASLEUE7s8+//4YFbv GjoE53Mnay0ArzyP+yD3qrDlrbaovvu5iF0Kl+vJVWEgESS0vuVuacwtZTn7+Sja89x9 lc2XPNN0EA/WgIYj5/+qf6C+LW7mIZ6yh77SfpCG0S3I8X+krtmkfgbqZuQREjLigsEa xB9rzNAUDW4wWcY0R24EDy4u5Bo4mI9+3mawRBsI16wD9gevmDh2csvb19Bei1NkaNzT FcwA== X-Gm-Message-State: AOAM5309x2HJcN+93+ydtAmOi/fRYdAUDVSzGCawSxoActrayIBeQv/q lsBS+czKC0bMZvlQqvI8LGINTg== X-Google-Smtp-Source: ABdhPJyhXpgIjQQcv0SKxB4ADopYBn4Ma33nCG5hGhtlwq04P9w9qJQ0mEskhuSP+q2j89By5mUeGg== X-Received: by 2002:adf:f24d:0:b0:206:96b:4ea1 with SMTP id b13-20020adff24d000000b00206096b4ea1mr4059467wrp.694.1649192093853; Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s1-20020adfb781000000b002060d4a8bd9sm8008923wre.17.2022.04.05.13.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Date: Tue, 5 Apr 2022 22:54:51 +0200 From: Daniel Vetter To: Tetsuo Handa Subject: Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor Message-ID: Mail-Followup-To: Tetsuo Handa , DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, LKML , Daniel Vetter , Claudio Suarez , Du Cheng , Thomas Zimmermann , Greg Kroah-Hartman References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , Du Cheng , Daniel Vetter , Intel Graphics Development , LKML , DRI Development , Claudio Suarez , Greg Kroah-Hartman , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote: > On 2022/02/09 6:08, Daniel Vetter wrote: > > @@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info, > > ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL); > > if (!ops) > > err = -ENOMEM; > > + > > + INIT_DELAYED_WORK(&ops->cursor_work, fb_flashcursor); > > } > > > > if (!err) { > > Memory allocation fault injection will hit NULL pointer dereference. The error handling here is convoluted and I got this wrong, but a later patch to extract an fbcon_open() helper fixes it. I'll fix this small bisect issue for v3 anyway, thanks for taking a look at the patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A5FBC433EF for ; Tue, 5 Apr 2022 20:54:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A96B10ED56; Tue, 5 Apr 2022 20:54:56 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DEA510ED56 for ; Tue, 5 Apr 2022 20:54:55 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b19so266390wrh.11 for ; Tue, 05 Apr 2022 13:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=dMIxaOA+PwGmGbUBgSF+BtNgTUc4RKGxiEJxcOGGW41WPS35KSWlB4hv7i4DbpxOGC ZH1S+U4+vSggXY1XAGmMMGqiGDAAFbM1TiIfR+O950jkhP22hrN5zpqEUFn8ZJUif7W1 UT9mutnETTYpsxdjQi923ezsNRj0CTq+AgkAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=cXZHdJ1ICdTSPS5T95YE9vzscu2qL4VljEOrfKA6cj6xOxsHINcFUNkUtfaKRKW7sF gjI5gWUVFWXpFitt9Y9Bvy12YND6pskJzQVD7MTsBASx8KymyT+FEi41tdZZyabfw4TU GfRgOMVUX2kHCHYdhPPx0+TN9s4dm2BRYDa+bDDMscSGsEC9c8W9/iT+A5EuDOqtyD2E TbdI1iKl+FvGIXhpzfh5jlBeFs3vZ+Dcqg1/0JRzFX3DbbFzk1PMnznSRqpMrV+NyxPB pg6FJSwLUI0FwIkcU8Q1BOCrLww+539l4H1Yi9Tw5RRhc/pakQn/QUBRtax7kiLqcqXy 68IA== X-Gm-Message-State: AOAM530QIHYgsXrR9vNAGuaEJqbdCjHuomsfH7zuo1vvfKPaEh76x/cA ACu2jCQ+X5MfKCDpCLGo2a3e0A== X-Google-Smtp-Source: ABdhPJyhXpgIjQQcv0SKxB4ADopYBn4Ma33nCG5hGhtlwq04P9w9qJQ0mEskhuSP+q2j89By5mUeGg== X-Received: by 2002:adf:f24d:0:b0:206:96b:4ea1 with SMTP id b13-20020adff24d000000b00206096b4ea1mr4059467wrp.694.1649192093853; Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s1-20020adfb781000000b002060d4a8bd9sm8008923wre.17.2022.04.05.13.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Date: Tue, 5 Apr 2022 22:54:51 +0200 From: Daniel Vetter To: Tetsuo Handa Message-ID: Mail-Followup-To: Tetsuo Handa , DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, LKML , Daniel Vetter , Claudio Suarez , Du Cheng , Thomas Zimmermann , Greg Kroah-Hartman References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH v2 06/19] fbcon: Use delayed work for cursor X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thomas Zimmermann , Du Cheng , Daniel Vetter , Intel Graphics Development , LKML , DRI Development , Greg Kroah-Hartman , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote: > On 2022/02/09 6:08, Daniel Vetter wrote: > > @@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info, > > ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL); > > if (!ops) > > err = -ENOMEM; > > + > > + INIT_DELAYED_WORK(&ops->cursor_work, fb_flashcursor); > > } > > > > if (!err) { > > Memory allocation fault injection will hit NULL pointer dereference. The error handling here is convoluted and I got this wrong, but a later patch to extract an fbcon_open() helper fixes it. I'll fix this small bisect issue for v3 anyway, thanks for taking a look at the patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21168C43217 for ; Wed, 6 Apr 2022 02:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1848960AbiDFCbn (ORCPT ); Tue, 5 Apr 2022 22:31:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386454AbiDEVuj (ORCPT ); Tue, 5 Apr 2022 17:50:39 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA2E910C531 for ; Tue, 5 Apr 2022 13:54:55 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id w4so256649wrg.12 for ; Tue, 05 Apr 2022 13:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=dMIxaOA+PwGmGbUBgSF+BtNgTUc4RKGxiEJxcOGGW41WPS35KSWlB4hv7i4DbpxOGC ZH1S+U4+vSggXY1XAGmMMGqiGDAAFbM1TiIfR+O950jkhP22hrN5zpqEUFn8ZJUif7W1 UT9mutnETTYpsxdjQi923ezsNRj0CTq+AgkAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=9NHEHnuZ3EwIt6oRfVHzwUDeTZ1Be9ZvXyD0BUY2xlM=; b=OWMvk60gBmzPIhQzdeNDQ0khF8GvvxrWUfyowoXwkkz00Ze75Lr3my4O524lu+9Xxz vlX4f9E3hKbdSBG2eWSC65oaiMY6jzkht1fmXI5nfLeWfX/vItQkTMC5SSpInYW23x1D Wo43CgWD1q1oQk1GA+GTUwY8SdSB0c19tcg78AOke1g1fybj8jXmPtjp/YDDIp4C1F0B ve15jYVQjhDNhYhjpKq1PPHrUoeG8Axclo0td204pITLPSyMol9Ub9S4L8CReiO2kZEO 6boMZZtBaxjgs1j7IMPFPZOn93UrkjdVLngi6D1POf1131GUeNXFYYFt1lEp6tlHRk/V 31bg== X-Gm-Message-State: AOAM531EFLZzeF5IAsMw3tdSU3yhiCMTmrRYXh/8aqEkjCKqoiU74i9G bO6mqK8seWCF73IDGWDT82PmAg== X-Google-Smtp-Source: ABdhPJyhXpgIjQQcv0SKxB4ADopYBn4Ma33nCG5hGhtlwq04P9w9qJQ0mEskhuSP+q2j89By5mUeGg== X-Received: by 2002:adf:f24d:0:b0:206:96b:4ea1 with SMTP id b13-20020adff24d000000b00206096b4ea1mr4059467wrp.694.1649192093853; Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s1-20020adfb781000000b002060d4a8bd9sm8008923wre.17.2022.04.05.13.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 13:54:53 -0700 (PDT) Date: Tue, 5 Apr 2022 22:54:51 +0200 From: Daniel Vetter To: Tetsuo Handa Cc: Daniel Vetter , DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, LKML , Daniel Vetter , Daniel Vetter , Claudio Suarez , Du Cheng , Thomas Zimmermann , Greg Kroah-Hartman Subject: Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor Message-ID: Mail-Followup-To: Tetsuo Handa , DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, LKML , Daniel Vetter , Claudio Suarez , Du Cheng , Thomas Zimmermann , Greg Kroah-Hartman References: <20220208210824.2238981-1-daniel.vetter@ffwll.ch> <20220208210824.2238981-7-daniel.vetter@ffwll.ch> <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f6d61f4-042f-8c9d-23ed-da6f1dcb20d0@I-love.SAKURA.ne.jp> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote: > On 2022/02/09 6:08, Daniel Vetter wrote: > > @@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info, > > ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL); > > if (!ops) > > err = -ENOMEM; > > + > > + INIT_DELAYED_WORK(&ops->cursor_work, fb_flashcursor); > > } > > > > if (!err) { > > Memory allocation fault injection will hit NULL pointer dereference. The error handling here is convoluted and I got this wrong, but a later patch to extract an fbcon_open() helper fixes it. I'll fix this small bisect issue for v3 anyway, thanks for taking a look at the patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch