From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <shy828301@gmail.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>,
Dave Chinner <david@fromorbit.com>,
Hillf Danton <hdanton@sina.com>, MM <linux-mm@kvack.org>,
Mel Gorman <mgorman@techsingularity.net>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Yu Zhao <yuzhao@google.com>, David Hildenbrand <david@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] mm/vmscan: add periodic slab shrinker
Date: Tue, 5 Apr 2022 22:21:53 +0100 [thread overview]
Message-ID: <Ykyy8RfJgWDOGylv@casper.infradead.org> (raw)
In-Reply-To: <CAHbLzko=bjLhhJXjcs0Uh-g3x9vV1gQZjEU2JqxVehqSb1UGkQ@mail.gmail.com>
On Tue, Apr 05, 2022 at 01:58:59PM -0700, Yang Shi wrote:
> Yeah, I agree it actually doesn't make too much sense to return the
> number of reclaimed objects. Other part of vmscan returns the number
> of base pages, the sizes of slab objects are varied, it may be much
> smaller than a page, for example, dentry may be 192 bytes.
From the point of view of vmscan, it only cares about the number of pages
freed because it's trying to free pages. But from the point of view of
trying to keep the number of non-useful objects in check, the number of
objects freed is more important, and it doesn't matter whether we ended
up freeing any pages because we made memory available for this slab cache.
next prev parent reply other threads:[~2022-04-06 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 7:21 [RFC] mm/vmscan: add periodic slab shrinker Hillf Danton
2022-04-02 17:54 ` Roman Gushchin
2022-04-03 0:56 ` Hillf Danton
2022-04-04 1:09 ` Dave Chinner
2022-04-04 5:14 ` Hillf Danton
2022-04-04 18:32 ` Roman Gushchin
2022-04-04 19:08 ` Roman Gushchin
2022-04-05 5:17 ` Dave Chinner
2022-04-05 16:35 ` Roman Gushchin
2022-04-05 20:58 ` Yang Shi
2022-04-05 21:21 ` Matthew Wilcox [this message]
2022-04-06 0:01 ` Dave Chinner
2022-04-06 4:14 ` Hillf Danton
2022-04-21 19:03 ` Kent Overstreet
2022-04-21 23:55 ` Dave Chinner
2022-04-05 21:31 ` Roman Gushchin
2022-04-06 0:11 ` Dave Chinner
2022-04-05 17:22 ` Stephen Brennan
2022-04-05 21:18 ` Matthew Wilcox
2022-04-05 23:54 ` Dave Chinner
2022-04-06 1:06 ` Stephen Brennan
2022-04-06 3:52 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykyy8RfJgWDOGylv@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=roman.gushchin@linux.dev \
--cc=shy828301@gmail.com \
--cc=stephen.s.brennan@oracle.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.