All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/3] KVM test infrastructure
Date: Wed, 20 Apr 2022 11:52:23 +0200	[thread overview]
Message-ID: <Yl/X1+luV4T+ZA+1@yuki> (raw)
In-Reply-To: <1148ebad-dce6-dbcb-63e5-db7131f914b9@suse.cz>

Hi!
> >> I didn't #include the tst_res_flags.h because the main LTP include
> >> directory is not passed to the preprocessor when compiling KVM payload.
> >> I'd have to do it like this:
> >> #include "../../../../include/tst_res_flags.h"
> > 
> > And I guess that this is on purpose right?
> > 
> > As we can easily add it by adding -I$(top_src_dir)/include/ to the
> > CFLAGS.
> 
> Yes, this is on purpose. I want any #include of standard LTP headers to
> trigger error because the vast majority of the functions declared in
> there are not available in KVM guest library. So should I add the dirty
> #include or should I keep the duplicate definition of tst_res flags?

I wonder what is cleaner solution. I do not like either one that much to
be honest, but I guess that I slightly prefer the ugly relative path
over copying the definitions over.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-04-20  9:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 11:33 [LTP] [PATCH v2 0/3] KVM testing Martin Doucha
2022-03-31 11:33 ` [LTP] [PATCH v2 1/3] Add AX_CHECK_COMPILE_FLAG() autoconf macro Martin Doucha
2022-04-01 22:04   ` Petr Vorel
2022-04-21 11:53   ` Cyril Hrubis
2022-03-31 11:33 ` [LTP] [PATCH v2 2/3] KVM test infrastructure Martin Doucha
2022-04-11  9:46   ` Richard Palethorpe
2022-04-14 10:25   ` Cyril Hrubis
2022-04-14 15:04     ` Martin Doucha
2022-04-20  9:11       ` Cyril Hrubis
2022-04-20  9:33         ` Martin Doucha
2022-04-20  9:52           ` Cyril Hrubis [this message]
2022-03-31 11:33 ` [LTP] [PATCH v2 3/3] Add test for CVE 2021-38198 Martin Doucha
2022-04-11  9:56   ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl/X1+luV4T+ZA+1@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.