All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-16 11:14 ` Alaa Mohamed
  0 siblings, 0 replies; 19+ messages in thread
From: Alaa Mohamed @ 2022-04-16 11:14 UTC (permalink / raw)
  To: outreachy
  Cc: jesse.brandeburg, anthony.l.nguyen, davem, kuba, pabeni,
	intel-wired-lan, netdev, linux-kernel, ira.weiny,
	eng.alaamohamedsoliman.am

Convert kmap() to kmap_local_page()

With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible.

Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
changes in V2:
	fix kunmap_local path value to take address of the mapped page.
---
changes in V3:
	edit commit message to be clearer
---
 drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 2a5782063f4c..c14fc871dd41 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
 
 	frame_size >>= 1;
 
-	data = kmap(rx_buffer->page);
+	data = kmap_local_page(rx_buffer->page);
 
 	if (data[3] != 0xFF ||
 	    data[frame_size + 10] != 0xBE ||
 	    data[frame_size + 12] != 0xAF)
 		match = false;
 
-	kunmap(rx_buffer->page);
+	kunmap_local(data);
 
 	return match;
 }
-- 
2.35.2


^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-04-19 13:37 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 11:14 [PATCH v3] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page() Alaa Mohamed
2022-04-16 11:14 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 11:31 ` Julia Lawall
2022-04-16 11:31   ` [Intel-wired-lan] " Julia Lawall
2022-04-16 13:14   ` Alaa Mohamed
2022-04-18 22:19     ` Ira Weiny
2022-04-18 22:19       ` [Intel-wired-lan] " Ira Weiny
2022-04-19 13:37       ` Alaa Mohamed
2022-04-19 13:37         ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 13:18   ` Alaa Mohamed
2022-04-16 13:18     ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 14:09     ` Julia Lawall
2022-04-16 14:09       ` [Intel-wired-lan] " Julia Lawall
2022-04-16 15:52       ` Fabio M. De Francesco
2022-04-16 15:52         ` [Intel-wired-lan] " Fabio M. De Francesco
2022-04-16 16:28         ` Fabio M. De Francesco
2022-04-16 21:43         ` Fabio M. De Francesco
2022-04-16 22:21         ` Fabio M. De Francesco
2022-04-17  7:07           ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.