All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Shelekhin <k.shelekhin@yadro.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Christie <michael.christie@oracle.com>,
	<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<linux@yadro.com>
Subject: Re: [PATCH] scsi: target: core: Silence the message about unknown VPD pages
Date: Tue, 19 Apr 2022 11:29:57 +0300	[thread overview]
Message-ID: <Yl5zBRgS2z4PtbA+@yadro.com> (raw)
In-Reply-To: <yq1r15t93gh.fsf@ca-mkp.ca.oracle.com>

On Mon, Apr 18, 2022 at 11:08:12PM -0400, Martin K. Petersen wrote:
> Konstantin,
> 
> > Target does not support some VPD pages and is very verbose about it.
> > Sometimes initiators don't bother and just keep sending the same
> > request from time to time, filling up the logs.
> >
> > This patch lowers the message priority to debug.
> 
> This essentially means the message will never be seen since it is not
> particularly common to twiddle the syslog level. Have you considered
> pr_err_once() or similar?

Hi,

Basically I was going the same route as with this message:

  pr_debug_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n"

IMO it's kinda the same situation. I'm not sure that not implemented VPD
will be of any interest to anyone except for the developers.

Also if I recall correctly pr_err_once() will be triggered once per code
line, not per message, so it's possible to actually lose the info if
more that one page is not implemented.

  reply	other threads:[~2022-04-19  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 21:26 [PATCH] scsi: target: core: Silence the message about unknown VPD pages Konstantin Shelekhin
2022-04-19  3:08 ` Martin K. Petersen
2022-04-19  8:29   ` Konstantin Shelekhin [this message]
2022-05-03  0:51 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl5zBRgS2z4PtbA+@yadro.com \
    --to=k.shelekhin@yadro.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@yadro.com \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.