From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1667A; Tue, 19 Apr 2022 13:35:50 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5DFB2E0014; Tue, 19 Apr 2022 13:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650375343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n2gXfB12UETk/0YkCHJoIk+2+NcrnNVkqApXWSoKx1A=; b=GEuJKEtyxj2/+YziJQOOA+FTzEB5IngtS596j1m9yXkig3BMgyV7ahEYVrhAumjrKgoSXy 5IrTcokHfYXTkkA2yQUOeAm8/xbI0jFpxqd8ROjKpubNqK7o9y3zO+5qNuHLwKXhyNfg9N OL6aS0p0xJ9NfYLfQlsehG9UGUeAAP8gXoozWzEIW7X/5AKCWmW9bJyP9rgAkGcDkupTBt Apf57pUrZj6TaIhntYLJw0aSqzVaT2hr1SiSRdJ9tsqydxkxIS+Q6z/FKOZkLCApOzGZ1R DzQw2lDfwVH+RYDaBigDB+dpAwq1D4XPxru9ZntK8wqTsLuLR/nYH+bi32gaTg== Date: Tue, 19 Apr 2022 15:35:40 +0200 From: Paul Kocialkowski To: Rob Herring Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v3 2/4] dt-bindings: media: sun6i-a31-csi: Add ISP output port Message-ID: References: <20220415153708.637804-1-paul.kocialkowski@bootlin.com> <20220415153708.637804-3-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ARCMrhh6iwx1/baF" Content-Disposition: inline In-Reply-To: --ARCMrhh6iwx1/baF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rob, On Tue 19 Apr 22, 08:08, Rob Herring wrote: > On Fri, Apr 15, 2022 at 05:37:06PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > >=20 > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > >=20 > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > >=20 > > Signed-off-by: Paul Kocialkowski > > --- > > .../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a3= 1-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-cs= i.yaml > > index 53aa6dbe8e2c..1b41a6008195 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > @@ -87,6 +87,20 @@ properties: > > =20 > > additionalProperties: false > > =20 > > + port@2: > > + $ref: /schemas/graph.yaml#/$defs/port-base >=20 > If there are not any custom properties, then use=20 > '/schemas/graph.yaml#/properties/port' and drop the 'properties' below. That's right, nothing specific about it. It just represents an internal FIFO between the different blocks. Thanks, I think this also applies to a number of other bindings I submitted in these series. Paul > > + description: ISP output port > > + > > + properties: > > + reg: > > + const: 2 > > + > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > anyOf: > > - required: > > - port@0 > > --=20 > > 2.35.2 > >=20 > >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --ARCMrhh6iwx1/baF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmJeuqwACgkQ3cLmz3+f v9HqMggAmP/958OcmYqTH1jIFaa7MSn0NwtiZYpWsEdszQdFikJbEDrDmOzM0GMQ VPGG4kmVyjpEt/E71a7P7SSmPn6Az7NzuUqmKWXqSZdddA1unOXpwJMH2cadG5Lu TUgb/fw0or93UOmr9yriT2aOq4RHcPt1kPVnnK8jg3KOlph60MuxdQsqiR/mMr1W 5YYVbyQTJxqVB6ldyy+y8vkA3GDIMEO6Lqef5ishLQTvlcjNanNlNxThXtShm28l BfE+eWclHe/vdCVRvxmEW2eG4NhE0ndLbPsHUEUPmt861JA5QTYykA49n7sBWmZp GxX55AcFR6KBxiJ6qv4/iQRpcL4iYg== =Jy+S -----END PGP SIGNATURE----- --ARCMrhh6iwx1/baF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7DE2C433EF for ; Tue, 19 Apr 2022 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Usis6DwpPlFRUfLKh0ZJnEElKeeiR7zdd6IgNz2rdnQ=; b=3h5V94peUayPQ2Piaqy/xgvGLY Q31BnQ0q/CMor9RkJih3p8InHXFcawNST1tp3XLgG3i0pgLUPClt8qrBaUea6Vq+Gi0KvxcP2f7K8 GtkHRRV/GjM8ZbX7vgRq72QgJAYBu/hcmLHxoL1FxSNTR/oV1wApRhjIiVWB30jNRNxPmkDqOz4UU P8bdr4HYDCSkiTyHFWwLN6J0XcChlZyGDcVeuggyLNpRexd6YXJqv1MzTmCDXFDrAb5xfW3ZFPJEA 2ZuzUP2rPbaZcqulqfExh70ZzfkJR1WNSHO7Q46PwjlR4yxfj7PcVta05KTPSqXwlJXc8v/O+NhOv ynmwWlhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngoR3-0046AN-L0; Tue, 19 Apr 2022 14:02:30 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngo1F-003tkt-R0 for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 13:35:54 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5DFB2E0014; Tue, 19 Apr 2022 13:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650375343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n2gXfB12UETk/0YkCHJoIk+2+NcrnNVkqApXWSoKx1A=; b=GEuJKEtyxj2/+YziJQOOA+FTzEB5IngtS596j1m9yXkig3BMgyV7ahEYVrhAumjrKgoSXy 5IrTcokHfYXTkkA2yQUOeAm8/xbI0jFpxqd8ROjKpubNqK7o9y3zO+5qNuHLwKXhyNfg9N OL6aS0p0xJ9NfYLfQlsehG9UGUeAAP8gXoozWzEIW7X/5AKCWmW9bJyP9rgAkGcDkupTBt Apf57pUrZj6TaIhntYLJw0aSqzVaT2hr1SiSRdJ9tsqydxkxIS+Q6z/FKOZkLCApOzGZ1R DzQw2lDfwVH+RYDaBigDB+dpAwq1D4XPxru9ZntK8wqTsLuLR/nYH+bi32gaTg== Date: Tue, 19 Apr 2022 15:35:40 +0200 From: Paul Kocialkowski To: Rob Herring Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v3 2/4] dt-bindings: media: sun6i-a31-csi: Add ISP output port Message-ID: References: <20220415153708.637804-1-paul.kocialkowski@bootlin.com> <20220415153708.637804-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_063550_228080_2A48E8B4 X-CRM114-Status: GOOD ( 23.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2033343900841904239==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2033343900841904239== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ARCMrhh6iwx1/baF" Content-Disposition: inline --ARCMrhh6iwx1/baF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rob, On Tue 19 Apr 22, 08:08, Rob Herring wrote: > On Fri, Apr 15, 2022 at 05:37:06PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > >=20 > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > >=20 > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > >=20 > > Signed-off-by: Paul Kocialkowski > > --- > > .../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a3= 1-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-cs= i.yaml > > index 53aa6dbe8e2c..1b41a6008195 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > @@ -87,6 +87,20 @@ properties: > > =20 > > additionalProperties: false > > =20 > > + port@2: > > + $ref: /schemas/graph.yaml#/$defs/port-base >=20 > If there are not any custom properties, then use=20 > '/schemas/graph.yaml#/properties/port' and drop the 'properties' below. That's right, nothing specific about it. It just represents an internal FIFO between the different blocks. Thanks, I think this also applies to a number of other bindings I submitted in these series. Paul > > + description: ISP output port > > + > > + properties: > > + reg: > > + const: 2 > > + > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > anyOf: > > - required: > > - port@0 > > --=20 > > 2.35.2 > >=20 > >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --ARCMrhh6iwx1/baF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmJeuqwACgkQ3cLmz3+f v9HqMggAmP/958OcmYqTH1jIFaa7MSn0NwtiZYpWsEdszQdFikJbEDrDmOzM0GMQ VPGG4kmVyjpEt/E71a7P7SSmPn6Az7NzuUqmKWXqSZdddA1unOXpwJMH2cadG5Lu TUgb/fw0or93UOmr9yriT2aOq4RHcPt1kPVnnK8jg3KOlph60MuxdQsqiR/mMr1W 5YYVbyQTJxqVB6ldyy+y8vkA3GDIMEO6Lqef5ishLQTvlcjNanNlNxThXtShm28l BfE+eWclHe/vdCVRvxmEW2eG4NhE0ndLbPsHUEUPmt861JA5QTYykA49n7sBWmZp GxX55AcFR6KBxiJ6qv4/iQRpcL4iYg== =Jy+S -----END PGP SIGNATURE----- --ARCMrhh6iwx1/baF-- --===============2033343900841904239== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2033343900841904239==--