From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static
Date: Tue, 19 Apr 2022 16:19:55 +0200 [thread overview]
Message-ID: <Yl7FC9M0hz7kQM4j@kroah.com> (raw)
In-Reply-To: <20220419133616.544255-1-trix@redhat.com>
On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static?
>
> vchiq_platform_init is only used in vchiq_arm.c. Single file variables should
> not be global so change vchiq_platform_init's storage-class specifier to static.
You did not change a variable, you changed a function type.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v2: refomat commit log
Why did you not fix the build breakage?
{sigh}
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static
Date: Tue, 19 Apr 2022 16:19:55 +0200 [thread overview]
Message-ID: <Yl7FC9M0hz7kQM4j@kroah.com> (raw)
In-Reply-To: <20220419133616.544255-1-trix@redhat.com>
On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static?
>
> vchiq_platform_init is only used in vchiq_arm.c. Single file variables should
> not be global so change vchiq_platform_init's storage-class specifier to static.
You did not change a variable, you changed a function type.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v2: refomat commit log
Why did you not fix the build breakage?
{sigh}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-19 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 13:36 [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static Tom Rix
2022-04-19 13:36 ` Tom Rix
2022-04-19 14:19 ` Greg KH [this message]
2022-04-19 14:19 ` Greg KH
2022-05-03 3:07 ` kernel test robot
2022-05-03 3:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl7FC9M0hz7kQM4j@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gascoar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.