From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013F87A for ; Tue, 19 Apr 2022 14:19:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41271C385A5; Tue, 19 Apr 2022 14:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650377998; bh=pFVocPAAyxNwE+EAgAOFl3aRkOLQgd7KM/MSQo7oSns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tUC4esakcVmVf6Lifp1odfO1Kh5p1ZHfE8rXBAhkSrB3L7xkPaoqaXaxqSyb8e8/5 1g0JtHAE9hplmxTNMdJlBiqb+kHyuM/9wzvqlge6w5OgrDvLBZZ3CwMim1dd9SavEZ 4pM5mUs9If6XW2itCchuIQSZ92Zoi6Wl2pvIG4GI= Date: Tue, 19 Apr 2022 16:19:55 +0200 From: Greg KH To: Tom Rix Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static Message-ID: References: <20220419133616.544255-1-trix@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133616.544255-1-trix@redhat.com> On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote: > Smatch reports this issue > vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static? > > vchiq_platform_init is only used in vchiq_arm.c. Single file variables should > not be global so change vchiq_platform_init's storage-class specifier to static. You did not change a variable, you changed a function type. > > Signed-off-by: Tom Rix > --- > v2: refomat commit log Why did you not fix the build breakage? {sigh} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CDB8C433EF for ; Tue, 19 Apr 2022 15:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TSLTcCTDRkqj9KAAU1ueY2JeP2jpnLy9/ASYhZ1g188=; b=ai0pC3FSUWX3cR FjjVPc+ky4HQOtzRHNxGqNPAE8t3En+fPvZ/lBOEPqLqCH+1dxb4FkynAcOKG/B2QnVuejw2vu1Ce uheNMVWeqac0QeiPvRWaM2gA7Siiou05ct7nM72djRCn7I1v/EgHBkm1WNjGZfAHv09lrU5sNKUyc 90JjDoJFR+3vd3d3QNeG2fP93Pdwx8POru11gdGWvaS2yNZzf/+6HUEKxsnOlLZcZM+RT0pYtr84j MgjpzLNa0cs82u9z9M5yEWmYHtw/CwdDpuez2pdmpyQmFP3I1+lwICQfOq9IXr88wcYzqKzUYT0K/ A4ArdmiWhX8aCv7YedyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpW6-004Y8A-T0; Tue, 19 Apr 2022 15:11:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngohz-004D54-NO; Tue, 19 Apr 2022 14:20:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B4C760765; Tue, 19 Apr 2022 14:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41271C385A5; Tue, 19 Apr 2022 14:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650377998; bh=pFVocPAAyxNwE+EAgAOFl3aRkOLQgd7KM/MSQo7oSns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tUC4esakcVmVf6Lifp1odfO1Kh5p1ZHfE8rXBAhkSrB3L7xkPaoqaXaxqSyb8e8/5 1g0JtHAE9hplmxTNMdJlBiqb+kHyuM/9wzvqlge6w5OgrDvLBZZ3CwMim1dd9SavEZ 4pM5mUs9If6XW2itCchuIQSZ92Zoi6Wl2pvIG4GI= Date: Tue, 19 Apr 2022 16:19:55 +0200 From: Greg KH To: Tom Rix Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static Message-ID: References: <20220419133616.544255-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419133616.544255-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_071959_848876_3377B915 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote: > Smatch reports this issue > vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static? > > vchiq_platform_init is only used in vchiq_arm.c. Single file variables should > not be global so change vchiq_platform_init's storage-class specifier to static. You did not change a variable, you changed a function type. > > Signed-off-by: Tom Rix > --- > v2: refomat commit log Why did you not fix the build breakage? {sigh} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel