From: Roman Gushchin <roman.gushchin@linux.dev>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH] mm: do not call add_nr_deferred() with zero deferred
Date: Tue, 19 Apr 2022 09:42:30 -0700 [thread overview]
Message-ID: <Yl7mdguNR3CabMAN@carbon> (raw)
In-Reply-To: <59404249-de0c-c569-d04a-9da38ed14b0a@redhat.com>
On Tue, Apr 19, 2022 at 02:56:06PM +0200, David Hildenbrand wrote:
> On 16.04.22 02:41, Roman Gushchin wrote:
> > add_nr_deferred() is often called with next_deferred equal to 0.
> > For instance, it's happening under low memory pressure for any
> > shrinkers with a low number of cached objects. A corresponding trace
> > looks like:
> > <...>-619914 [005] .... 467456.345160: mm_shrink_slab_end: \
> > super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 \
> > unused scan count 0 new scan count 0 total_scan 0 \
> > last shrinker return val 0
> >
> > <...>-619914 [005] .... 467456.345371: mm_shrink_slab_end: \
> > super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 \
> > unused scan count 0 new scan count 0 total_scan 0 \
> > last shrinker return val 0
> >
> > <...>-619914 [005] .... 467456.345380: mm_shrink_slab_end: \
> > super_cache_scan+0x0/0x1a0 0000000087027f06: nid: 1 unused \
> > scan count 0 new scan count 0 total_scan 0 \
> > last shrinker return val 0
> >
> > This lead to unnecessary checks and atomic operations, which can be
> > avoided by checking next_deferred for not being zero before calling
> > add_nr_deferred(). In this case the mm_shrink_slab_end trace point
> > will get a potentially slightly outdated "new scan count" value, but
> > it's totally fine.
>
> Sufficient improvement to justify added complexity for anybody reading
> that code?
I don't have any numbers and really doubt the difference is significant,
however the added complexity is also small: one "if" statement.
Anyway, if you feel strongly against this change, I'm fine with dropping it.
>
> >
> > Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
> > ---
> > mm/vmscan.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index d4a7d2bd276d..19d3d4fa1aad 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -808,7 +808,10 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl,
> > * move the unused scan count back into the shrinker in a
> > * manner that handles concurrent updates.
> > */
> > - new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl);
> > + if (next_deferred)
> > + new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl);
> > + else
> > + new_nr = nr;
> >
> > trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, total_scan);
> > return freed;
>
> And if we still want to do this optimization, why not put it into
> add_nr_deferred()?
Because of the semantics of add_nr_deferred(), which returns the deferred value.
It's not used for anything except tracing, so maybe it's a place for another
change.
Thanks!
next prev parent reply other threads:[~2022-04-19 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 0:41 [PATCH] mm: do not call add_nr_deferred() with zero deferred Roman Gushchin
2022-04-19 12:56 ` David Hildenbrand
2022-04-19 16:42 ` Roman Gushchin [this message]
2022-04-19 16:57 ` David Hildenbrand
2022-04-20 23:30 ` Yang Shi
2022-04-22 1:19 ` Dave Chinner
2022-04-22 2:36 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl7mdguNR3CabMAN@carbon \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dchinner@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.