From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB6FC433EF for ; Sat, 9 Apr 2022 01:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237452AbiDIBEq (ORCPT ); Fri, 8 Apr 2022 21:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbiDIBEn (ORCPT ); Fri, 8 Apr 2022 21:04:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D33F22CB3AA for ; Fri, 8 Apr 2022 18:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649466157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RbsAzZvTljYo+RBJswsnAR5lYXPWhOrtFUVWlHUhygc=; b=aF5cMbJ0KTGzUFcr8O6W6KQ1wtTwCTALG8AEJuMqHzfh5QttYw0QPDOZnasxsn0TeV8j7V DOsL7qazhKYMG4T6OjdNjFFPhIzAfIW2h0J83/72Vj3iBfaugRnPBdxMy3Dln/T7RZXcUU O7UdBrWV+FIljTvXt8ym1BgGwjEIYyQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-4QYPejBPMdmQgr3pUtPhmw-1; Fri, 08 Apr 2022 21:02:34 -0400 X-MC-Unique: 4QYPejBPMdmQgr3pUtPhmw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44E792999B23; Sat, 9 Apr 2022 01:02:34 +0000 (UTC) Received: from localhost (ovpn-12-19.pek2.redhat.com [10.72.12.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAB83C44CC0; Sat, 9 Apr 2022 01:02:32 +0000 (UTC) Date: Sat, 9 Apr 2022 09:02:29 +0800 From: Baoquan He To: kernel test robot Cc: akpm@linux-foundation.org, willy@infradead.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, hch@lst.de, yangtiezhu@loongson.cn, amit.kachhap@arm.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter Message-ID: References: <20220408090636.560886-2-bhe@redhat.com> <202204082128.JKXXDGpa-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202204082128.JKXXDGpa-lkp@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/22 at 09:17pm, kernel test robot wrote: > Hi Baoquan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on powerpc/next] > [also build test WARNING on s390/features linus/master v5.18-rc1 next-20220408] > [cannot apply to tip/x86/core hnaz-mm/master arm64/for-next/core] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/Convert-vmcore-to-use-an-iov_iter/20220408-170846 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: sh-randconfig-s032-20220408 (https://download.01.org/0day-ci/archive/20220408/202204082128.JKXXDGpa-lkp@intel.com/config) > compiler: sh4-linux-gcc (GCC) 11.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross Thanks for reporting this, do I need to try this on ppc system? I tried on x86_64 system, for the 1st step, I got this: [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross /root/bin/make.cross: No such file or directory What else should I do to proceed? Thanks Baoquan > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/intel-lab-lkp/linux/commit/a5e42962f5c0bea73aa382a2415094b4bd6c6c73 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Baoquan-He/Convert-vmcore-to-use-an-iov_iter/20220408-170846 > git checkout a5e42962f5c0bea73aa382a2415094b4bd6c6c73 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash arch/sh/kernel/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *addr @@ got void [noderef] __iomem * @@ > arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr > arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem * > > vim +23 arch/sh/kernel/crash_dump.c > > 13 > 14 ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, > 15 size_t csize, unsigned long offset) > 16 { > 17 void __iomem *vaddr; > 18 > 19 if (!csize) > 20 return 0; > 21 > 22 vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE); > > 23 csize = copy_to_iter(vaddr + offset, csize, iter); > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Date: Sat, 9 Apr 2022 09:02:29 +0800 Subject: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter In-Reply-To: <202204082128.JKXXDGpa-lkp@intel.com> References: <20220408090636.560886-2-bhe@redhat.com> <202204082128.JKXXDGpa-lkp@intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org On 04/08/22 at 09:17pm, kernel test robot wrote: > Hi Baoquan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on powerpc/next] > [also build test WARNING on s390/features linus/master v5.18-rc1 next-20220408] > [cannot apply to tip/x86/core hnaz-mm/master arm64/for-next/core] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/Convert-vmcore-to-use-an-iov_iter/20220408-170846 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: sh-randconfig-s032-20220408 (https://download.01.org/0day-ci/archive/20220408/202204082128.JKXXDGpa-lkp at intel.com/config) > compiler: sh4-linux-gcc (GCC) 11.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross Thanks for reporting this, do I need to try this on ppc system? I tried on x86_64 system, for the 1st step, I got this: [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross /root/bin/make.cross: No such file or directory What else should I do to proceed? Thanks Baoquan > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/intel-lab-lkp/linux/commit/a5e42962f5c0bea73aa382a2415094b4bd6c6c73 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Baoquan-He/Convert-vmcore-to-use-an-iov_iter/20220408-170846 > git checkout a5e42962f5c0bea73aa382a2415094b4bd6c6c73 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash arch/sh/kernel/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *addr @@ got void [noderef] __iomem * @@ > arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr > arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem * > > vim +23 arch/sh/kernel/crash_dump.c > > 13 > 14 ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, > 15 size_t csize, unsigned long offset) > 16 { > 17 void __iomem *vaddr; > 18 > 19 if (!csize) > 20 return 0; > 21 > 22 vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE); > > 23 csize = copy_to_iter(vaddr + offset, csize, iter); > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5935148838643269917==" MIME-Version: 1.0 From: Baoquan He To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 RESEND 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter Date: Sat, 09 Apr 2022 09:02:29 +0800 Message-ID: In-Reply-To: <202204082128.JKXXDGpa-lkp@intel.com> List-Id: --===============5935148838643269917== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 04/08/22 at 09:17pm, kernel test robot wrote: > Hi Baoquan, > = > Thank you for the patch! Perhaps something to improve: > = > [auto build test WARNING on powerpc/next] > [also build test WARNING on s390/features linus/master v5.18-rc1 next-202= 20408] > [cannot apply to tip/x86/core hnaz-mm/master arm64/for-next/core] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/Convert= -vmcore-to-use-an-iov_iter/20220408-170846 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git= next > config: sh-randconfig-s032-20220408 (https://download.01.org/0day-ci/arch= ive/20220408/202204082128.JKXXDGpa-lkp(a)intel.com/config) > compiler: sh4-linux-gcc (GCC) 11.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross Thanks for reporting this, do I need to try this on ppc system? I tried on x86_64 system, for the 1st step, I got this: [ ~]# wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/ma= ke.cross -O ~/bin/make.cross /root/bin/make.cross: No such file or directory What else should I do to proceed? Thanks Baoquan > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/intel-lab-lkp/linux/commit/a5e42962f5c0bea73= aa382a2415094b4bd6c6c73 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Baoquan-He/Convert-vmcore-to-use= -an-iov_iter/20220408-170846 > git checkout a5e42962f5c0bea73aa382a2415094b4bd6c6c73 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cro= ss C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH= =3Dsh SHELL=3D/bin/bash arch/sh/kernel/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > = > sparse warnings: (new ones prefixed by >>) > >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in a= rgument 1 (different address spaces) @@ expected void const *addr @@ = got void [noderef] __iomem * @@ > arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *ad= dr > arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __io= mem * > = > vim +23 arch/sh/kernel/crash_dump.c > = > 13 = > 14 ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, > 15 size_t csize, unsigned long offset) > 16 { > 17 void __iomem *vaddr; > 18 = > 19 if (!csize) > 20 return 0; > 21 = > 22 vaddr =3D ioremap(pfn << PAGE_SHIFT, PAGE_SIZE); > > 23 csize =3D copy_to_iter(vaddr + offset, csize, iter); > = > -- = > 0-DAY CI Kernel Test Service > https://01.org/lkp >=20 --===============5935148838643269917==--