Re: [PATCH v3 11/12] serial: 8250_lpss: Use 32-bit reads

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Johan Hovold" <johan@kernel.org>,
	heiko@sntech.de, giulio.benetti@micronovasrl.com,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 11/12] serial: 8250_lpss: Use 32-bit reads
Date: Mon, 11 Apr 2022 14:12:09 +0300	[thread overview]
Message-ID: <YlQNCYb/eUkgcugl@smile.fi.intel.com> (raw)
In-Reply-To: <20220411083321.9131-12-ilpo.jarvinen@linux.intel.com>

On Mon, Apr 11, 2022 at 11:33:20AM +0300, Ilpo Järvinen wrote:
> Use 32-bit reads in order to not lose higher bits of DW
> UART regs.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Maybe it needs an additional words that currently the driver doesn't
use anything from the upper bits, that's why it's not a fix.

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/tty/serial/8250/8250_lpss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index 0f5af061e0b4..4ba43bef9933 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -330,7 +330,7 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	uart.port.irq = pci_irq_vector(pdev, 0);
>  	uart.port.private_data = &lpss->data;
>  	uart.port.type = PORT_16550A;
> -	uart.port.iotype = UPIO_MEM;
> +	uart.port.iotype = UPIO_MEM32;
>  	uart.port.regshift = 2;
>  	uart.port.uartclk = lpss->board->base_baud * 16;
>  	uart.port.flags = UPF_SHARE_IRQ | UPF_FIXED_PORT | UPF_FIXED_TYPE;
> -- 
> 2.30.2
> 

-- 
With Best Regards,
Andy Shevchenko