All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH] include/linux/find: Fix documentation
Date: Mon, 11 Apr 2022 18:48:17 +0300	[thread overview]
Message-ID: <YlRNwV3jlikHfu/v@smile.fi.intel.com> (raw)
In-Reply-To: <20220411150555.26023-1-anna-maria@linutronix.de>

On Mon, Apr 11, 2022 at 05:05:55PM +0200, Anna-Maria Behnsen wrote:
> The order of the arguments in function documentation doesn't fit the
> implementation. Change the documentation so that it corresponds to the
> code. This prevent people to get confused when reading the documentation.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
> ---
>  include/linux/find.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/find.h b/include/linux/find.h
> index 5bb6db213bcb..424ef67d4a42 100644
> --- a/include/linux/find.h
> +++ b/include/linux/find.h
> @@ -21,8 +21,8 @@ extern unsigned long _find_last_bit(const unsigned long *addr, unsigned long siz
>  /**
>   * find_next_bit - find the next set bit in a memory region
>   * @addr: The address to base the search on
> - * @offset: The bitnumber to start searching at
>   * @size: The bitmap size in bits
> + * @offset: The bitnumber to start searching at
>   *
>   * Returns the bit number for the next set bit
>   * If no bits are set, returns @size.
> @@ -50,8 +50,8 @@ unsigned long find_next_bit(const unsigned long *addr, unsigned long size,
>   * find_next_and_bit - find the next set bit in both memory regions
>   * @addr1: The first address to base the search on
>   * @addr2: The second address to base the search on
> - * @offset: The bitnumber to start searching at
>   * @size: The bitmap size in bits
> + * @offset: The bitnumber to start searching at
>   *
>   * Returns the bit number for the next set bit
>   * If no bits are set, returns @size.
> @@ -79,8 +79,8 @@ unsigned long find_next_and_bit(const unsigned long *addr1,
>  /**
>   * find_next_zero_bit - find the next cleared bit in a memory region
>   * @addr: The address to base the search on
> - * @offset: The bitnumber to start searching at
>   * @size: The bitmap size in bits
> + * @offset: The bitnumber to start searching at
>   *
>   * Returns the bit number of the next zero bit
>   * If no bits are zero, returns @size.
> -- 
> 2.20.1
> 

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-04-11 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 15:05 [PATCH] include/linux/find: Fix documentation Anna-Maria Behnsen
2022-04-11 15:48 ` Andy Shevchenko [this message]
2022-04-11 17:20   ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlRNwV3jlikHfu/v@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=anna-maria@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=tglx@linutronix.de \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.