All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	Jeff Dike <jdike@addtoit.com>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	regressions@lists.linux.dev
Subject: Re: [PATCH 1/1] um: fix error return code in winch_tramp()
Date: Mon, 11 Apr 2022 10:48:36 -0700	[thread overview]
Message-ID: <YlRp9KR1mp3/4Txo@thelio-3990X> (raw)
In-Reply-To: <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at>

Hi Richard,

On Sun, Apr 10, 2022 at 11:33:33AM +0200, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
> > Von: "Thorsten Leemhuis" <regressions@leemhuis.info>
> > Hi, this is your Linux kernel regression tracker. Top-posting for once,
> > to make this easily accessible to everyone.
> > 
> > Zhen Lei, Richard, what's up here? Below regression report is more than
> > two weeks old now and afaics didn't even get a single reply.
> 
> Sorry, but UML is leisure pursuit, so I can only work on it when my
> schedule permits it.

No worries, it is easy enough to work around for our use case.

> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > 
> > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > reports on my table. I can only look briefly into most of them and lack
> > knowledge about most of the areas they concern. I thus unfortunately
> > will sometimes get things wrong or miss something important. I hope
> > that's not the case here; if you think it is, don't hesitate to tell me
> > in a public reply, it's in everyone's interest to set the public record
> > straight.
> > 
> > 
> > 
> > On 23.03.22 20:41, Nathan Chancellor wrote:
> 
> [...]
> 
> >> in case it helps. I am happy to provide more information or test patches
> >> as necessary.
> 
> Nathan, can you provide me the error code from os_set_fd_block()?
> My best guess is that setting the fd is optional here and UML does
> not expect failure here.

I attempted to print out the error code but it seems like there is no
output in the console after "reboot: System halted". If I add an
unconditional print right before the call to os_set_fd_block(), I see it
during start up but I do not see it during shutdown. Is there some way
to see that console output during shutdown?

Cheers,
Nathan

WARNING: multiple messages have this Message-ID
From: Nathan Chancellor <nathan@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	Jeff Dike <jdike@addtoit.com>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	regressions@lists.linux.dev
Subject: Re: [PATCH 1/1] um: fix error return code in winch_tramp()
Date: Mon, 11 Apr 2022 10:48:36 -0700	[thread overview]
Message-ID: <YlRp9KR1mp3/4Txo@thelio-3990X> (raw)
In-Reply-To: <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at>

Hi Richard,

On Sun, Apr 10, 2022 at 11:33:33AM +0200, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
> > Von: "Thorsten Leemhuis" <regressions@leemhuis.info>
> > Hi, this is your Linux kernel regression tracker. Top-posting for once,
> > to make this easily accessible to everyone.
> > 
> > Zhen Lei, Richard, what's up here? Below regression report is more than
> > two weeks old now and afaics didn't even get a single reply.
> 
> Sorry, but UML is leisure pursuit, so I can only work on it when my
> schedule permits it.

No worries, it is easy enough to work around for our use case.

> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > 
> > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > reports on my table. I can only look briefly into most of them and lack
> > knowledge about most of the areas they concern. I thus unfortunately
> > will sometimes get things wrong or miss something important. I hope
> > that's not the case here; if you think it is, don't hesitate to tell me
> > in a public reply, it's in everyone's interest to set the public record
> > straight.
> > 
> > 
> > 
> > On 23.03.22 20:41, Nathan Chancellor wrote:
> 
> [...]
> 
> >> in case it helps. I am happy to provide more information or test patches
> >> as necessary.
> 
> Nathan, can you provide me the error code from os_set_fd_block()?
> My best guess is that setting the fd is optional here and UML does
> not expect failure here.

I attempted to print out the error code but it seems like there is no
output in the console after "reboot: System halted". If I add an
unconditional print right before the call to os_set_fd_block(), I see it
during start up but I do not see it during shutdown. Is there some way
to see that console output during shutdown?

Cheers,
Nathan

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  reply	other threads:[~2022-04-11 17:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  3:22 [PATCH 1/1] um: fix error return code in winch_tramp() Zhen Lei
2021-05-08  3:22 ` Zhen Lei
2021-05-08  9:13 ` Anton Ivanov
2021-05-08  9:13   ` Anton Ivanov
2022-03-23 19:41 ` Nathan Chancellor
2022-03-23 19:41   ` Nathan Chancellor
2022-03-24 12:40   ` Thorsten Leemhuis
2022-03-24 12:40     ` Thorsten Leemhuis
2022-05-31  8:17     ` [PATCH 1/1] um: fix error return code in winch_tramp() #forregzbot Thorsten Leemhuis
2022-04-10  8:41   ` [PATCH 1/1] um: fix error return code in winch_tramp() Thorsten Leemhuis
2022-04-10  8:41     ` Thorsten Leemhuis
2022-04-10  9:33     ` Richard Weinberger
2022-04-10  9:33       ` Richard Weinberger
2022-04-11 17:48       ` Nathan Chancellor [this message]
2022-04-11 17:48         ` Nathan Chancellor
2022-04-11 18:45         ` Richard Weinberger
2022-04-11 18:45           ` Richard Weinberger
2022-05-20  6:08           ` Thorsten Leemhuis
2022-05-20  6:08             ` Thorsten Leemhuis
2022-05-20 15:55             ` Nathan Chancellor
2022-05-20 15:55               ` Nathan Chancellor
2022-05-20 17:18               ` Johannes Berg
2022-05-20 17:18                 ` Johannes Berg
2022-05-20 17:31                 ` Nathan Chancellor
2022-05-20 17:31                   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlRp9KR1mp3/4Txo@thelio-3990X \
    --to=nathan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=maxdamage@aladin.ro \
    --cc=ndesaulniers@google.com \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=richard@nod.at \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.