From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7F61865 for ; Mon, 11 Apr 2022 17:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF972C385A3; Mon, 11 Apr 2022 17:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649699318; bh=mCeBQOom8NlCqItQrm9XkYJs+WtEQ7iDURD9UYCLHig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ir/2lHuJv7zwqFbKoSPNY+qIWk9ERT5Mml9ZcphpRERQegxuRqmiywJ7CkwOv6iYX 5AGYTBi4GJjXlmfB0KqxW9Ld6ACpKkHUMo2p3FvusvVDBkO/ighSmQZj9YVd1bw8Cx /yrXAaWmJk1R5FtavTvDOdcc75FEr4rRjSLV3iA7BQfs7h0juJg9ZV0tYw/NEXLq4o OVNkrRvqAbmVvwXDr/Jdgcy4a9ycDQn1HdCzxuklCx6dmDjAEICt4jkb8PFsR4gPma QoLcRkvezyV+J9xLLaXjs6gpMeamBRJNzEmX4czA5wn8loX6V1XsXe/ye0FTgpRbLQ C+QJTZdq+bnyg== Date: Mon, 11 Apr 2022 10:48:36 -0700 From: Nathan Chancellor To: Richard Weinberger Cc: Thorsten Leemhuis , Zhen Lei , Jeff Dike , anton ivanov , Andrew Morton , Eduard-Gabriel Munteanu , linux-um , linux-kernel , Nick Desaulniers , regressions@lists.linux.dev Subject: Re: [PATCH 1/1] um: fix error return code in winch_tramp() Message-ID: References: <20210508032239.2177-1-thunder.leizhen@huawei.com> <1b03d888-cea3-3e6f-087f-daeb5642a975@leemhuis.info> <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at> Hi Richard, On Sun, Apr 10, 2022 at 11:33:33AM +0200, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- > > Von: "Thorsten Leemhuis" > > Hi, this is your Linux kernel regression tracker. Top-posting for once, > > to make this easily accessible to everyone. > > > > Zhen Lei, Richard, what's up here? Below regression report is more than > > two weeks old now and afaics didn't even get a single reply. > > Sorry, but UML is leisure pursuit, so I can only work on it when my > schedule permits it. No worries, it is easy enough to work around for our use case. > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of > > reports on my table. I can only look briefly into most of them and lack > > knowledge about most of the areas they concern. I thus unfortunately > > will sometimes get things wrong or miss something important. I hope > > that's not the case here; if you think it is, don't hesitate to tell me > > in a public reply, it's in everyone's interest to set the public record > > straight. > > > > > > > > On 23.03.22 20:41, Nathan Chancellor wrote: > > [...] > > >> in case it helps. I am happy to provide more information or test patches > >> as necessary. > > Nathan, can you provide me the error code from os_set_fd_block()? > My best guess is that setting the fd is optional here and UML does > not expect failure here. I attempted to print out the error code but it seems like there is no output in the console after "reboot: System halted". If I add an unconditional print right before the call to os_set_fd_block(), I see it during start up but I do not see it during shutdown. Is there some way to see that console output during shutdown? Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndy9X-009xyg-Uy for linux-um@lists.infradead.org; Mon, 11 Apr 2022 17:48:41 +0000 Date: Mon, 11 Apr 2022 10:48:36 -0700 From: Nathan Chancellor Subject: Re: [PATCH 1/1] um: fix error return code in winch_tramp() Message-ID: References: <20210508032239.2177-1-thunder.leizhen@huawei.com> <1b03d888-cea3-3e6f-087f-daeb5642a975@leemhuis.info> <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1087614384.239493.1649583213699.JavaMail.zimbra@nod.at> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Richard Weinberger Cc: Thorsten Leemhuis , Zhen Lei , Jeff Dike , anton ivanov , Andrew Morton , Eduard-Gabriel Munteanu , linux-um , linux-kernel , Nick Desaulniers , regressions@lists.linux.dev Hi Richard, On Sun, Apr 10, 2022 at 11:33:33AM +0200, Richard Weinberger wrote: > ----- Urspr=FCngliche Mail ----- > > Von: "Thorsten Leemhuis" > > Hi, this is your Linux kernel regression tracker. Top-posting for once, > > to make this easily accessible to everyone. > > = > > Zhen Lei, Richard, what's up here? Below regression report is more than > > two weeks old now and afaics didn't even get a single reply. > = > Sorry, but UML is leisure pursuit, so I can only work on it when my > schedule permits it. No worries, it is easy enough to work around for our use case. > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > = > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of > > reports on my table. I can only look briefly into most of them and lack > > knowledge about most of the areas they concern. I thus unfortunately > > will sometimes get things wrong or miss something important. I hope > > that's not the case here; if you think it is, don't hesitate to tell me > > in a public reply, it's in everyone's interest to set the public record > > straight. > > = > > = > > = > > On 23.03.22 20:41, Nathan Chancellor wrote: > = > [...] > = > >> in case it helps. I am happy to provide more information or test patch= es > >> as necessary. > = > Nathan, can you provide me the error code from os_set_fd_block()? > My best guess is that setting the fd is optional here and UML does > not expect failure here. I attempted to print out the error code but it seems like there is no output in the console after "reboot: System halted". If I add an unconditional print right before the call to os_set_fd_block(), I see it during start up but I do not see it during shutdown. Is there some way to see that console output during shutdown? Cheers, Nathan _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um