From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31788C4321E for ; Tue, 12 Apr 2022 11:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233095AbiDLLod (ORCPT ); Tue, 12 Apr 2022 07:44:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350968AbiDLLli (ORCPT ); Tue, 12 Apr 2022 07:41:38 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C67E50446 for ; Tue, 12 Apr 2022 03:23:24 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id g18so10755428wrb.10 for ; Tue, 12 Apr 2022 03:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PWMqY36PdhLmPkOzVF3q3fwHeKiOtTKe2AjxmCLE4AM=; b=rxPkFbXFz9aCNjSPQJCPwsRgNusOv6QOeU6kHeI7J2jLUpfCOO7NPqnM6zMHlWJPlf c1flepjryToeCDaC4JFADEtJTlrVPVeJkLG4Un7QDQFozlTM4ojPUd7Qy7AV7Nnmg7VR o6aMqa6PuHkNAywHEzkjenaw5mFQCqftxZVV7QphwAB4tIuB7lE+D/8nVP1xT8t/c2gE S+UWahfMmnDhXFy8IAYIU+k/SBFRn8N1iRznqKcBa3s/5mKo4812cUFjYTQdXHQWZpks t5jejttpdawk3BTjhZouX1n+M8NeHYQ2aaGiBC/i0pijXEDRINDJ3stJYWMU9svnI6xy mNEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PWMqY36PdhLmPkOzVF3q3fwHeKiOtTKe2AjxmCLE4AM=; b=kaRx6npVGQYK+dAnEfgdCnFP+4BwLrY2U8l2TNVSTet96VCNeC8xxBVbWLhEFRcUcA JDnxNIErdFrhgJpR+6FscIWhbDE1z5A4yW/J59rOxJk/lLJRgerFvpXCJ1phKwyOL4Gi 7B1Zh4tfWLtynlmi3r6QO4SN2JB0MzeBrctWTXjYykkIAyI7Gxpm93WxW5a+joQSOzol mW4c5A3cqALED59H+okoFs6k7vAgY3KDmLhK+6DrLqpkAAEXUBMG2krAfnoSVXN7T1am +Wx/ZqsyBR2pGwsUdzWuWjeCyynNxHrrm/iRdbH4NwFu0331bVaQ+QWRnxk4NPInVd4v OakQ== X-Gm-Message-State: AOAM532/C7R0ZvaLJI5l6pVPtAg++B0sEIGytkw671mFD6+r5fPN3mq1 Y4TWyQk9SnTh71VhYg1dSYUnQQ== X-Google-Smtp-Source: ABdhPJyU87YmXxLZxW7oXhFtjM8IEwsiPrNqUd6sNpFKh9QYGd776pDXXzthW10OfB72M9oSz7/6cw== X-Received: by 2002:adf:ff86:0:b0:207:a89b:f532 with SMTP id j6-20020adfff86000000b00207a89bf532mr6176553wrr.558.1649759002672; Tue, 12 Apr 2022 03:23:22 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id b1-20020a05600018a100b00207ab2305d5sm3803038wri.16.2022.04.12.03.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 03:23:22 -0700 (PDT) Date: Tue, 12 Apr 2022 11:23:20 +0100 From: Lee Jones To: Johannes Berg Cc: kernel test robot , 0day robot , "David S. Miller" , Jakub Kicinski , Paolo Abeni , LKML , lkp@lists.01.org, stable@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [nl80211] 584f2e43bb: hwsim.ap_country.fail Message-ID: References: <20220401105046.1952815-1-lee.jones@linaro.org> <20220405091420.GD17553@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 11 Apr 2022, Johannes Berg wrote: > On Mon, 2022-04-11 at 10:25 +0100, Lee Jones wrote: > > So what exactly happened here?  What does this failure tell us? > > Probably nothing. > > > Is the LKP test broken or did I overlook something in the kernel > > patch? > > I think the test is just randomly fluking out. > > > How does LKP make use of NL80211_ATTR_REG_ALPHA2? > > > > I'm struggling to find any mention of 'hostapd.py' or 'ap_country' in > > LKP [0].  Are these benchmarks bespoke add-ons? > > > > it's running the tests from hostap: > https://w1.fi/cgit/hostap/tree/tests/hwsim > > Anyway, I think we'd better fix the issue like this: > > - [NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 }, > + /* allow 3 for NUL-termination, we used to declare this NLA_STRING */ > + [NL80211_ATTR_REG_ALPHA2] = NLA_POLICY_RANGE(NLA_BINARY, 2, 3), > > > What do you think? I'm not entirely sure of the semantics, but so long as it ensures the user declares enough space to hold both Bytes of data, I'd be happy. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5026108706701372917==" MIME-Version: 1.0 From: Lee Jones To: lkp@lists.01.org Subject: Re: [nl80211] 584f2e43bb: hwsim.ap_country.fail Date: Tue, 12 Apr 2022 11:23:20 +0100 Message-ID: In-Reply-To: List-Id: --===============5026108706701372917== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, 11 Apr 2022, Johannes Berg wrote: > On Mon, 2022-04-11 at 10:25 +0100, Lee Jones wrote: > > So what exactly happened here?=C2=A0 What does this failure tell us? > = > Probably nothing. > = > > Is the LKP test broken or did I overlook something in the kernel > > patch? > = > I think the test is just randomly fluking out. > = > > How does LKP make use of NL80211_ATTR_REG_ALPHA2? > > = > > I'm struggling to find any mention of 'hostapd.py' or 'ap_country' in > > LKP [0].=C2=A0 Are these benchmarks bespoke add-ons? = > > = > = > it's running the tests from hostap: > https://w1.fi/cgit/hostap/tree/tests/hwsim > = > Anyway, I think we'd better fix the issue like this: > = > - [NL80211_ATTR_REG_ALPHA2] =3D { .type =3D NLA_STRING, .len =3D 2 = }, > + /* allow 3 for NUL-termination, we used to declare this NLA_STRIN= G */ > + [NL80211_ATTR_REG_ALPHA2] =3D NLA_POLICY_RANGE(NLA_BINARY, 2, 3), > = > = > What do you think? I'm not entirely sure of the semantics, but so long as it ensures the user declares enough space to hold both Bytes of data, I'd be happy. -- = Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] Principal Technical Lead - Developer Services Linaro.org =E2=94=82 Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog --===============5026108706701372917==--