All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Klaus Jensen <its@irrelevant.dk>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique
Date: Tue, 12 Apr 2022 11:46:17 -0700	[thread overview]
Message-ID: <YlXI+dfftyuoJPPG@bombadil.infradead.org> (raw)
In-Reply-To: <20220411055455.GA14480@lst.de>

On Mon, Apr 11, 2022 at 07:54:55AM +0200, Christoph Hellwig wrote:
> It would be great if qemu could switch to a new PCI ID after this is
> fixed as that simplifies the quirking.

Thanks,  I think it's worth to re-iterate why:

The most directly visible problem is that this breaks the                                                                                                                                     
/dev/disk/by-id/ links - all devices would have to point to the same                                                                                                                          
one, and which one actually shows up is somewhat random.  This basically                                                                                                                      
means random corruption if people actually use the links or the uuid                                                                                                                          
functionality in any other way.

  Luis


  parent reply	other threads:[~2022-04-12 18:46 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 19:28 properly validate the nvme uniqueue identifiers are unique v2 Christoph Hellwig
2022-02-24 19:28 ` [PATCH 1/4] nvme: cleanup __nvme_check_ids Christoph Hellwig
2022-02-24 22:50   ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 2/4] nvme: fix the check for duplicate unique identifiers Christoph Hellwig
2022-02-24 22:51   ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 3/4] nvme: check for duplicate identifiers earlier Christoph Hellwig
2022-02-24 22:52   ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Christoph Hellwig
2022-02-24 22:54   ` Chaitanya Kulkarni
2022-04-08  1:04   ` Luis Chamberlain
2022-04-08  5:29     ` Christoph Hellwig
2022-04-08  7:19       ` Klaus Jensen
2022-04-08 16:10         ` Christoph Hellwig
2022-04-08 17:46           ` Luis Chamberlain
2022-04-11  5:05             ` Christoph Hellwig
2022-04-11  5:54               ` Christoph Hellwig
2022-04-11  6:01                 ` Klaus Jensen
2022-04-11  6:09                   ` Christoph Hellwig
2022-04-11  6:11                     ` Klaus Jensen
2022-04-12 18:46                 ` Luis Chamberlain [this message]
2022-04-18 23:30                 ` Alan Adamson
2022-04-20  7:36                   ` Christoph Hellwig
2022-06-06 20:35                     ` Alan Adamson
2022-06-06 21:38                       ` Keith Busch
2022-06-06 21:51                         ` Alan Adamson
2022-06-06 21:58                           ` Keith Busch
2022-06-06 23:11                             ` Alan Adamson
2022-06-07 19:01                               ` Keith Busch
2022-06-08  7:48                               ` Christoph Hellwig
2022-06-08  7:52                       ` Christoph Hellwig
2022-06-08 18:11                         ` Alan Adamson
2022-06-08 19:04                           ` Keith Busch
2022-06-09  0:30                             ` Chaitanya Kulkarni
2022-06-09 15:11                               ` Alan Adamson
2022-06-09  3:53                             ` Christoph Hellwig
2022-06-10  0:27                               ` Alan Adamson
2022-06-10 14:12                                 ` Keith Busch
2022-06-15 20:15                                   ` Alan Adamson
2022-06-17  9:01                                     ` Christoph Hellwig
2022-06-21 18:40                                       ` Alan Adamson
2022-06-21 19:11                                         ` Keith Busch
2022-06-21 20:39                                           ` Alan Adamson
2022-06-22 11:00                                           ` Christoph Hellwig
2022-06-22 15:45                                             ` Alan Adamson
2022-02-24 19:38 ` properly validate the nvme uniqueue identifiers are unique v2 Keith Busch
2022-06-05  1:58 [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Stefan
2022-06-06  6:40 ` Christoph Hellwig
2022-06-06 12:42   ` Stefan
2022-06-06 15:03     ` Christoph Hellwig
2022-06-06 14:51   ` Keith Busch
2022-06-06 15:06     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlXI+dfftyuoJPPG@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=hch@lst.de \
    --cc=its@irrelevant.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.