From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08924C433F5 for ; Wed, 13 Apr 2022 05:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232431AbiDMFfI (ORCPT ); Wed, 13 Apr 2022 01:35:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiDMFfF (ORCPT ); Wed, 13 Apr 2022 01:35:05 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E1AF2FFD6 for ; Tue, 12 Apr 2022 22:32:43 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A84EE8061; Wed, 13 Apr 2022 05:30:07 +0000 (UTC) Date: Wed, 13 Apr 2022 08:32:40 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Tomi Valkeinen , Devarsh Thakkar , linux-kernel@vger.kernel.org, jyri.sarha@iki.fi, tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, a-bhatia1@ti.com, r-ravikumar@ti.com, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Message-ID: References: <20220314113739.18000-1-devarsht@ti.com> <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> <20220412212049.gjnel7aubol56azk@earache> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412212049.gjnel7aubol56azk@earache> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nishanth Menon [220412 21:18]: > On 17:24-20220412, Tomi Valkeinen wrote: > > Hi, > > > > On 14/03/2022 13:37, Devarsh Thakkar wrote: > > > Soft reset the display subsystem controller on startup and wait for > > > the reset to complete. This helps the scenario where display was > > > already in use by some other core before the linux was booted. > > > > The reason the omapdrm doesn't do a reset is that the PM features on some of > > the DSS registers were set and controlled outside dss driver, so the dss > > driver could not do a reset just like that. That design was carried to the > > tidss driver, although I'm not sure if the reason is valid on AM6 and J7 > > platforms. > > > > If that reasoning is not valid, this patch is ok and: > > > > Reviewed-by: Tomi Valkeinen Yeah seems OK to me for tidss, I don't think there's any other layer to do this in a generic way for k3 devices currently. The thing to check here is that the sysconfig register gets properly initialized to the right state after reset. For PM, likely the syconfig value after reset is not correct, but that can be reconfigured later on as needed. > Tony - sysc control for older omap devices still control this directly? Yes, for a reason. The reset affects the entire interconnect target module, and disabling clockdomain autoidle needs to be considered for enable. For omaps, the resets are handled in a generic way for all the TI devices by ti-sysc. With ti-sysc, the reset is done before probing dss devices on init in sysc_init_module(). The dss related quirk handling is done in sysc_pre_reset_quirk_dss(). If needed, we could add support for reset framework to ti-sysc for omapdrm to call. But so far there has not been much of a need for that, I think 8250_omap could use reset framework if available though. Anyways, sounds like there's no need to do a similar dss reset in omapdrm. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F49C433F5 for ; Wed, 13 Apr 2022 05:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sh51CJuVfEnbniK6DoYlf13wXsLqEXRLnQeznXzNbEw=; b=IMJT9BhAsiacQs wE6yuUvw4gnEum3Dj439VmESkqCwBr6YzZA3bKMUdQLc2eXD8YSWdPRB6F6EakuV9Xp30V0jVvwP6 4ywirWJm0cu0S4HFLAXwgAjcByz5kriTEtvr7swJIy0hBy1evx+3ZJlsvXiKqDmimg9somP64XPaF KZuT5ZD7DbANkVic77lyHN1+xunOGyNBKYgUH4JmBn6Zkoe8z6JVrcO4AznWkqRvjucW5HV/mrEn7 nn028vsDpHCwfZFHKuRZsOZS4kIjzf1uzi/xdcDgq/Sg2y3pVnK5PgXYvgY8+6nA/cRdafCFfmBag PXzrvdShdBrhzC/F6BTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neVcW-00GpqY-9z; Wed, 13 Apr 2022 05:32:48 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neVcT-00Gpq9-9m for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 05:32:46 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A84EE8061; Wed, 13 Apr 2022 05:30:07 +0000 (UTC) Date: Wed, 13 Apr 2022 08:32:40 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Tomi Valkeinen , Devarsh Thakkar , linux-kernel@vger.kernel.org, jyri.sarha@iki.fi, tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, a-bhatia1@ti.com, r-ravikumar@ti.com, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Message-ID: References: <20220314113739.18000-1-devarsht@ti.com> <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> <20220412212049.gjnel7aubol56azk@earache> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220412212049.gjnel7aubol56azk@earache> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_223245_420662_3B7F3697 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Nishanth Menon [220412 21:18]: > On 17:24-20220412, Tomi Valkeinen wrote: > > Hi, > > > > On 14/03/2022 13:37, Devarsh Thakkar wrote: > > > Soft reset the display subsystem controller on startup and wait for > > > the reset to complete. This helps the scenario where display was > > > already in use by some other core before the linux was booted. > > > > The reason the omapdrm doesn't do a reset is that the PM features on some of > > the DSS registers were set and controlled outside dss driver, so the dss > > driver could not do a reset just like that. That design was carried to the > > tidss driver, although I'm not sure if the reason is valid on AM6 and J7 > > platforms. > > > > If that reasoning is not valid, this patch is ok and: > > > > Reviewed-by: Tomi Valkeinen Yeah seems OK to me for tidss, I don't think there's any other layer to do this in a generic way for k3 devices currently. The thing to check here is that the sysconfig register gets properly initialized to the right state after reset. For PM, likely the syconfig value after reset is not correct, but that can be reconfigured later on as needed. > Tony - sysc control for older omap devices still control this directly? Yes, for a reason. The reset affects the entire interconnect target module, and disabling clockdomain autoidle needs to be considered for enable. For omaps, the resets are handled in a generic way for all the TI devices by ti-sysc. With ti-sysc, the reset is done before probing dss devices on init in sysc_init_module(). The dss related quirk handling is done in sysc_pre_reset_quirk_dss(). If needed, we could add support for reset framework to ti-sysc for omapdrm to call. But so far there has not been much of a need for that, I think 8250_omap could use reset framework if available though. Anyways, sounds like there's no need to do a similar dss reset in omapdrm. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 939FDC433F5 for ; Wed, 13 Apr 2022 05:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE33B112184; Wed, 13 Apr 2022 05:42:09 +0000 (UTC) X-Greylist: delayed 565 seconds by postgrey-1.36 at gabe; Wed, 13 Apr 2022 05:42:08 UTC Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A96D112183 for ; Wed, 13 Apr 2022 05:42:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A84EE8061; Wed, 13 Apr 2022 05:30:07 +0000 (UTC) Date: Wed, 13 Apr 2022 08:32:40 +0300 From: Tony Lindgren To: Nishanth Menon Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Message-ID: References: <20220314113739.18000-1-devarsht@ti.com> <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> <20220412212049.gjnel7aubol56azk@earache> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412212049.gjnel7aubol56azk@earache> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Devarsh Thakkar , tomba@kernel.org, airlied@linux.ie, Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, a-bhatia1@ti.com, vigneshr@ti.com, laurent.pinchart@ideasonboard.com, jyri.sarha@iki.fi, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, r-ravikumar@ti.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Nishanth Menon [220412 21:18]: > On 17:24-20220412, Tomi Valkeinen wrote: > > Hi, > > > > On 14/03/2022 13:37, Devarsh Thakkar wrote: > > > Soft reset the display subsystem controller on startup and wait for > > > the reset to complete. This helps the scenario where display was > > > already in use by some other core before the linux was booted. > > > > The reason the omapdrm doesn't do a reset is that the PM features on some of > > the DSS registers were set and controlled outside dss driver, so the dss > > driver could not do a reset just like that. That design was carried to the > > tidss driver, although I'm not sure if the reason is valid on AM6 and J7 > > platforms. > > > > If that reasoning is not valid, this patch is ok and: > > > > Reviewed-by: Tomi Valkeinen Yeah seems OK to me for tidss, I don't think there's any other layer to do this in a generic way for k3 devices currently. The thing to check here is that the sysconfig register gets properly initialized to the right state after reset. For PM, likely the syconfig value after reset is not correct, but that can be reconfigured later on as needed. > Tony - sysc control for older omap devices still control this directly? Yes, for a reason. The reset affects the entire interconnect target module, and disabling clockdomain autoidle needs to be considered for enable. For omaps, the resets are handled in a generic way for all the TI devices by ti-sysc. With ti-sysc, the reset is done before probing dss devices on init in sysc_init_module(). The dss related quirk handling is done in sysc_pre_reset_quirk_dss(). If needed, we could add support for reset framework to ti-sysc for omapdrm to call. But so far there has not been much of a need for that, I think 8250_omap could use reset framework if available though. Anyways, sounds like there's no need to do a similar dss reset in omapdrm. Regards, Tony