From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0700C433F5 for ; Wed, 13 Apr 2022 08:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbiDMILw (ORCPT ); Wed, 13 Apr 2022 04:11:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbiDMILv (ORCPT ); Wed, 13 Apr 2022 04:11:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 533C16384; Wed, 13 Apr 2022 01:09:28 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D96CF80F5; Wed, 13 Apr 2022 08:06:52 +0000 (UTC) Date: Wed, 13 Apr 2022 11:09:26 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Daniel Lezcano , Keerthy , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Message-ID: References: <20220412131644.59195-1-tony@atomide.com> <20220412131644.59195-2-tony@atomide.com> <1c455b6e-0009-6f8b-15c8-2a352479c5f2@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Tony Lindgren [220413 06:08]: > * Krzysztof Kozlowski [220412 17:04]: > > Hmmm, in your previous version I had impression that first clock is not > > the same on every flavor. Now it looks the same, so clocks you could > > simplify even more: > > 1. Define full list in main properties (not in allOf) with minItems:1 > > 2. Use maxItems:1, for this "else:" case. > > > > This could greatly reduce amount of code you need and keep the actual > > definition of clocks in main properties (not in allOf; allOf are only to > > constrain it). > > OK thanks I'll check. I think we can assume the first clock is "fck" if > it is configured at all. Yup, this works nicely :) Will send out v4 set. Thanks, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B33BFC433EF for ; Wed, 13 Apr 2022 08:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JdNNUXhELt0HvyTQEi38etPi2OfdJQ7mdhBLbpYvx88=; b=pO3mT5I6JoHwjM G0aSEymXaK/PofpmI3/O7/nfotVRT7690Ul+qgM63jXtcCxr5Pc2Zstwt1ZnnSiUcLN3XHBtSCbHJ C6xFKHSTWlgIZsc04gRLSViwBjlp5L/2TMGuDBl+Ukm2n0clr0uSHJhJJ5Uh2Lgsof5UzYxysRJiI 6FsccGgWsr/KMth6Ttbm+ZzGybLADG6v8s/NNagZ11/KCJRCIQGpfg6HDpkzRa2Uba3rTrvDfvk8U IfmbOLurBKq1wSUVLuASMCtSkMWFy4MdkeuZq6x1bYkxKsXEM1m0fqE2tDfq2DHyDR/TqFrihxuzH qufwWmmS1mRA3aYIHAfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neY4R-00HY59-Ug; Wed, 13 Apr 2022 08:09:48 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neY4O-00HY37-Lx for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 08:09:46 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D96CF80F5; Wed, 13 Apr 2022 08:06:52 +0000 (UTC) Date: Wed, 13 Apr 2022 11:09:26 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Daniel Lezcano , Keerthy , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Message-ID: References: <20220412131644.59195-1-tony@atomide.com> <20220412131644.59195-2-tony@atomide.com> <1c455b6e-0009-6f8b-15c8-2a352479c5f2@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_010944_781327_EB71567E X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [220413 06:08]: > * Krzysztof Kozlowski [220412 17:04]: > > Hmmm, in your previous version I had impression that first clock is not > > the same on every flavor. Now it looks the same, so clocks you could > > simplify even more: > > 1. Define full list in main properties (not in allOf) with minItems:1 > > 2. Use maxItems:1, for this "else:" case. > > > > This could greatly reduce amount of code you need and keep the actual > > definition of clocks in main properties (not in allOf; allOf are only to > > constrain it). > > OK thanks I'll check. I think we can assume the first clock is "fck" if > it is configured at all. Yup, this works nicely :) Will send out v4 set. Thanks, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel